devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vincent Pelletier <plr.vincent@gmail.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: Rob Herring <robh+dt@kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Qiu Wenbo <qiuwenbo@kylinos.com.cn>,
	devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	David Abdurachmanov <david.abdurachmanov@sifive.com>
Subject: Re: [PATCH] riscv: dts: sifive unmatched: Name gpio lines.
Date: Tue, 16 Nov 2021 10:17:13 +0000	[thread overview]
Message-ID: <20211116101713.77a0df69@gmail.com> (raw)
In-Reply-To: <11612716.TMCrJ2abzX@diego>

Hello,

On Tue, 16 Nov 2021 10:39:04 +0100, Heiko Stübner <heiko@sntech.de> wrote:
> Hi Vincent,
> 
> Am Dienstag, 16. November 2021, 01:52:56 CET schrieb Vincent Pelletier:
> > Follow the pin descriptions given in the version 3 of the board schematics.
> > 
> > Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>  
> 
> when sending a patch series with "git format-patch -6" and friends will
> automcatically generate x/y additions like "[PATCH 1/6]" and so on.
> 
> Please try to keep them around when sending, as automated tools for patch
> handling like "b4", stumble when they encounter a patch series without them.

Actually my intent was to not make this a series, as in my understanding
independent patches should/may be submitted separately from each other.
They just happen to be stacked, and in this order, in my working copy,
but should not functionally have any dependency on one another (I
believe they should even apply cleanly in any order).

It is only after sending that I realised that
  git send-email --no-thread [...] v5.16-rc1..riscv_for_upstream
still decided to thread the emails...
Which indeed makes my use of "--no-numbered" a mistake. Sorry for not
checking --dry-run output more closely.

> In this case a
> 
> 	b4 am f6512cc50dc31a086e00ed59c63ea60d8c148fc4.1637023980.git.plr.vincent@gmail.com
> 
> [first patch in the series]
> will actually only retrieve the last patch
> 
> 	"[PATCH] riscv: dts: sifive unmatched: Link the tmp451 with its power supply."
> 
> as it thinks it's a new version of the first one.
> 
> 
> Thanks
> Heiko
> 
> > ---
> >  arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > index 4f66919215f6..305a086e5207 100644
> > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > @@ -245,4 +245,8 @@ &pwm1 {
> >  
> >  &gpio {
> >  	status = "okay";
> > +	gpio-line-names = "J29.1", "PMICNTB", "PMICSHDN", "J8.1", "J8.3",
> > +		"PCIe_PWREN", "THERM", "UBRDG_RSTN", "PCIe_PERSTN",
> > +		"ULPI_RSTN", "J8.2", "UHUB_RSTN", "GEMGXL_RST", "J8.4",
> > +		"EN_VDD_SD", "SD_CD";
> >  };
> >   
> 
> 
> 
> 




-- 
Vincent Pelletier
GPG fingerprint 983A E8B7 3B91 1598 7A92 3845 CAC9 3691 4257 B0C1

  reply	other threads:[~2021-11-16 10:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16  0:52 [PATCH] riscv: dts: sifive unmatched: Name gpio lines Vincent Pelletier
2021-11-16  0:52 ` [PATCH] riscv: dts: sifive unmatched: Expose the board ID eeprom Vincent Pelletier
2021-11-16  0:52 ` [PATCH] riscv: dts: sifive unmatched: Expose the PMIC sub-functions Vincent Pelletier
2021-11-16  0:52 ` [PATCH] riscv: dts: sifive unmatched: Expose the FU740 core supply regulator Vincent Pelletier
2021-11-16  9:53   ` Heiko Stübner
2021-11-16 11:08     ` Krzysztof Kozlowski
2021-11-16 11:13       ` Heiko Stübner
2021-11-16 10:44   ` Krzysztof Kozlowski
2021-11-16  0:53 ` [PATCH] riscv: dts: sifive unmatched: Fix regulator for board rev3 Vincent Pelletier
2021-11-16  0:53 ` [PATCH] riscv: dts: sifive unmatched: Link the tmp451 with its power supply Vincent Pelletier
2021-11-16 11:04   ` Krzysztof Kozlowski
2021-11-16  9:39 ` [PATCH] riscv: dts: sifive unmatched: Name gpio lines Heiko Stübner
2021-11-16 10:17   ` Vincent Pelletier [this message]
2021-11-16 11:05     ` Krzysztof Kozlowski
2021-11-16 10:36 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211116101713.77a0df69@gmail.com \
    --to=plr.vincent@gmail.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=david.abdurachmanov@sifive.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=qiuwenbo@kylinos.com.cn \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).