From: Maxime Ripard <maxime@cerno.tech>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, "Chen-Yu Tsai" <wens@csie.org>,
"Jernej Škrabec" <jernej.skrabec@gmail.com>
Subject: UnevaluatedProperties and DWMAC
Date: Tue, 16 Nov 2021 14:56:55 +0100 [thread overview]
Message-ID: <20211116135655.kwco2hlozt2omp7m@gilmour> (raw)
[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]
Hi Rob,
Thanks for updating jsonschema and supporting the 2019.09 Draft. I tried
to do this recently but struggled a bit.
As you can imagine, I went along and ran it on the Allwinner SoCs and it
looks like there's a weird interaction between unevaluatedProperties and
Documentation/devicetree/bindings/net/snps,dwmac.yaml
Indeed, schemas using it (allwinner,sun7i-a20-gmac.yaml is a rather
straightforward example) seem to fail the unevaluatedProperties check,
like:
.../arch/arm/boot/dts/sun7i-a20-wexler-tab7200.dt.yaml: ethernet@1c50000: Unevaluated properties are not allowed ('snps,pbl', 'snps,fixed-burst', 'snps,force_sf_dma_mode', 'mdio' were unexpected)
From schema: .../Documentation/devicetree/bindings/net/allwinner,sun7i-a20-gmac.yaml
All these properties are definitely in snps,dwmac.yaml, and it's pretty
much the only issue when running dtbs_check across all the sunxi DTs, so
unevaluatedProperties seems to be working just fine as well.
I first wondered if it could be because of the custom select clause in
snps,dwmac.yaml that doesn't include the allwinner,sun7i-a20-gmac
compatible, but even removing that clause entirely doesn't improve the
situation.
Do you have an idea of what could be going on?
Thanks!
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
reply other threads:[~2021-11-16 13:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211116135655.kwco2hlozt2omp7m@gilmour \
--to=maxime@cerno.tech \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=robh@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).