From: "William A. Kennington III" <wak@google.com>
To: robh+dt@kernel.org, mark.rutland@arm.com, avifishman70@gmail.com,
tali.perry1@gmail.com
Cc: joel@jms.id.au, openbmc@lists.ozlabs.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
"William A. Kennington III" <wak@google.com>
Subject: [PATCH] ARM: dts: nuvoton: Fix FIU reg definition
Date: Tue, 16 Nov 2021 17:25:12 -0800 [thread overview]
Message-ID: <20211117012512.1081593-1-wak@google.com> (raw)
The current definitions have a reg-name for "memory", but no
corresponding reg space defined. These values were taken from the
NPCM7xx documentation and tested on real hardware.
Without this definition, the FIU driver does not take advantage of
direct read support.
Signed-off-by: William A. Kennington III <wak@google.com>
---
arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi
index aca0e0e390d8..c164ec9fc96f 100644
--- a/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi
+++ b/arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi
@@ -181,7 +181,7 @@ fiu0: spi@fb000000 {
compatible = "nuvoton,npcm750-fiu";
#address-cells = <1>;
#size-cells = <0>;
- reg = <0xfb000000 0x1000>;
+ reg = <0xfb000000 0x1000>, <0x80000000 0x10000000>;
reg-names = "control", "memory";
clocks = <&clk NPCM7XX_CLK_SPI0>;
clock-names = "clk_spi0";
@@ -192,7 +192,7 @@ fiu3: spi@c0000000 {
compatible = "nuvoton,npcm750-fiu";
#address-cells = <1>;
#size-cells = <0>;
- reg = <0xc0000000 0x1000>;
+ reg = <0xc0000000 0x1000>, <0xa0000000 0x20000000>;
reg-names = "control", "memory";
clocks = <&clk NPCM7XX_CLK_SPI3>;
clock-names = "clk_spi3";
@@ -265,7 +265,7 @@ fiux: spi@fb001000 {
compatible = "nuvoton,npcm750-fiu";
#address-cells = <1>;
#size-cells = <0>;
- reg = <0xfb001000 0x1000>;
+ reg = <0xfb001000 0x1000>, <0xf8000000 0x2000000>;
reg-names = "control", "memory";
clocks = <&clk NPCM7XX_CLK_SPIX>;
clock-names = "clk_spix";
--
2.34.0.rc1.387.gb447b232ab-goog
reply other threads:[~2021-11-17 1:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211117012512.1081593-1-wak@google.com \
--to=wak@google.com \
--cc=avifishman70@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).