From: Shawn Guo <shawnguo@kernel.org>
To: David Heidelberg <david@ixit.cz>
Cc: Rob Herring <robh+dt@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Heiko Stuebner <heiko@sntech.de>,
~okias/devicetree@lists.sr.ht, phone-devel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2 2/3] arm64: dts: make dts use gpio-fan matrix instead of array
Date: Sun, 21 Nov 2021 16:55:00 +0800 [thread overview]
Message-ID: <20211121085457.GN31998@dragon> (raw)
In-Reply-To: <20211029114948.41841-2-david@ixit.cz>
On Fri, Oct 29, 2021 at 01:49:45PM +0200, David Heidelberg wrote:
> No functional changes.
>
> Adjust to comply with dt-schema requirements
> and make possible to validate values.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 9 +++++----
> arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts | 2 +-
You may want to split it per platform, so that corresponding platform
maintainer can pick them up.
Shawn
> arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi | 2 +-
> arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts | 5 +++--
> 4 files changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> index 86bdc0baf032..fbbcacf24f2e 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> @@ -52,10 +52,11 @@ gpio_fan: gpio-fan {
> gpios = <&gpio GPIODV_14 GPIO_ACTIVE_HIGH
> &gpio GPIODV_15 GPIO_ACTIVE_HIGH>;
> /* Dummy RPM values since fan is optional */
> - gpio-fan,speed-map = <0 0
> - 1 1
> - 2 2
> - 3 3>;
> + gpio-fan,speed-map =
> + <0 0>,
> + <1 1>,
> + <2 2>,
> + <3 3>;
> #cooling-cells = <2>;
> };
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts b/arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts
> index a3b9d615a3b4..e34045d10a12 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts
> @@ -39,7 +39,7 @@ reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
>
> fan: gpio-fan {
> compatible = "gpio-fan";
> - gpio-fan,speed-map = <0 0 8600 1>;
> + gpio-fan,speed-map = <0 0>, <8600 1>;
> gpios = <&gpio3 5 GPIO_ACTIVE_HIGH>;
> #cooling-cells = <2>;
> pinctrl-names = "default";
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
> index 46b0f97a0b1c..4af535866d1f 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi
> @@ -44,7 +44,7 @@ dc_12v: dc-12v {
> fan0: gpio-fan {
> #cooling-cells = <2>;
> compatible = "gpio-fan";
> - gpio-fan,speed-map = <0 0 3000 1>;
> + gpio-fan,speed-map = <0 0>, <3000 1>;
> gpios = <&gpio1 RK_PC2 GPIO_ACTIVE_HIGH>;
> status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
> index 4d4b2a301b1a..8af3763daaba 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.dts
> @@ -30,8 +30,9 @@ gmac1_clkin: external-gmac1-clock {
> fan: gpio_fan {
> compatible = "gpio-fan";
> gpios = <&gpio0 RK_PD5 GPIO_ACTIVE_HIGH>;
> - gpio-fan,speed-map = <0 0
> - 4500 1>;
> + gpio-fan,speed-map =
> + < 0 0>,
> + <4500 1>;
> #cooling-cells = <2>;
> };
>
> --
> 2.33.0
>
next prev parent reply other threads:[~2021-11-21 8:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 11:49 [PATCH v2 1/3] ARM: dts: make dts use gpio-fan matrix instead of array David Heidelberg
2021-10-29 11:49 ` [PATCH v2 2/3] arm64: " David Heidelberg
2021-10-31 19:39 ` Martin Blumenstingl
2023-01-26 10:00 ` Neil Armstrong
2021-10-31 22:16 ` Heiko Stuebner
2021-11-21 8:55 ` Shawn Guo [this message]
2021-11-02 9:30 ` [PATCH v2 1/3] ARM: " Simon Guinot
2021-11-02 10:54 ` David Heidelberg
2021-11-02 13:00 ` Simon Guinot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211121085457.GN31998@dragon \
--to=shawnguo@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=jbrunet@baylibre.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=~okias/devicetree@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).