From: Maxime Ripard <maxime@cerno.tech>
To: Jernej Skrabec <jernej.skrabec@gmail.com>
Cc: wens@csie.org, robh+dt@kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
Michael Klein <michael@fossekall.de>
Subject: Re: [PATCH] ARM: dts: sun8i: Adjust power key nodes
Date: Tue, 23 Nov 2021 11:32:19 +0100 [thread overview]
Message-ID: <20211123103219.4y2pjywt2uxunc5s@gilmour> (raw)
In-Reply-To: <20211122213637.922088-1-jernej.skrabec@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
Hi,
On Mon, Nov 22, 2021 at 10:36:37PM +0100, Jernej Skrabec wrote:
> Several H3 and one H2+ board have power key nodes, which are slightly
> off. Some are missing wakeup-source property and some have BTN_0 code
> assigned instead of KEY_POWER.
>
> Adjust them, so they can function as intended by designer.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> [BananaPi M2 Zero changes]
> Signed-off-by: Michael Klein <michael@fossekall.de>
This looks a bit weird. If Michael is the author, then his SoB should be
here first and mentioned either in From or Co-developed-by.
If you are, I'm not sure why he's mentioned?
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2021-11-23 10:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-22 21:36 [PATCH] ARM: dts: sun8i: Adjust power key nodes Jernej Skrabec
2021-11-23 10:32 ` Maxime Ripard [this message]
2021-11-23 16:42 ` Jernej Škrabec
2021-11-26 16:25 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211123103219.4y2pjywt2uxunc5s@gilmour \
--to=maxime@cerno.tech \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=michael@fossekall.de \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox