From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1E10C4332F for ; Wed, 24 Nov 2021 16:49:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232392AbhKXQwV (ORCPT ); Wed, 24 Nov 2021 11:52:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349239AbhKXQwU (ORCPT ); Wed, 24 Nov 2021 11:52:20 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A400C061574 for ; Wed, 24 Nov 2021 08:49:11 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpvSF-00070K-Mz; Wed, 24 Nov 2021 17:49:07 +0100 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mpvSF-0004cO-6B; Wed, 24 Nov 2021 17:49:07 +0100 Date: Wed, 24 Nov 2021 17:49:07 +0100 From: Michael Tretter To: Sakari Ailus Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Marek Vasut , Rob Herring , Mauro Carvalho Chehab , p.zabel@pengutronix.de, Ian Arkver , kernel@pengutronix.de, Hans Verkuil Subject: Re: [PATCH v8 2/3] media: dt-bindings: Add Intersil ISL79987 DT bindings Message-ID: <20211124164907.GD20126@pengutronix.de> Mail-Followup-To: Michael Tretter , Sakari Ailus , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Marek Vasut , Rob Herring , Mauro Carvalho Chehab , p.zabel@pengutronix.de, Ian Arkver , kernel@pengutronix.de, Hans Verkuil References: <20211123101517.3656935-1-m.tretter@pengutronix.de> <20211123101517.3656935-3-m.tretter@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 17:28:20 up 279 days, 19:52, 136 users, load average: 0.05, 0.12, 0.14 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 23 Nov 2021 13:07:00 +0200, Sakari Ailus wrote: > On Tue, Nov 23, 2021 at 11:15:16AM +0100, Michael Tretter wrote: > > From: Marek Vasut > > > > Add bindings for the Intersil ISL79987 analog to MIPI CSI-2 decoder. > > > > Signed-off-by: Marek Vasut > > Cc: Sakari Ailus > > Cc: Mauro Carvalho Chehab > > Cc: Rob Herring > > Cc: devicetree@vger.kernel.org > > To: linux-media@vger.kernel.org > > Signed-off-by: Michael Tretter > > Reviewed-by: Rob Herring > > --- > > Changelog: > > > > v8: none > > > > v7: none > > > > v6: none > > > > v5: none > > > > v4: none > > > > v3: > > > > - rename pd-gpios property to powerdown-gpios > > - reference graph.yaml for ports/port properties > > - remove reference to video-interfaces.txt > > - remove unnecessary description of ports property > > > > v2: > > > > - convert binding to yaml > > - change description to match only isl79987 > > - replace num-inputs property with multiple ports > > - add reset gpio > > --- > > .../bindings/media/i2c/isil,isl79987.yaml | 100 ++++++++++++++++++ > > 1 file changed, 100 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/isil,isl79987.yaml > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/isil,isl79987.yaml b/Documentation/devicetree/bindings/media/i2c/isil,isl79987.yaml > > new file mode 100644 > > index 000000000000..aee4a5966df3 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/i2c/isil,isl79987.yaml > > @@ -0,0 +1,100 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/i2c/isil,isl79987.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Intersil ISL79987 Analog to MIPI CSI-2 decoder > > + > > +maintainers: > > + - Michael Tretter > > + - Marek Vasut > > + > > +description: > > + The Intersil ISL79987 is an analog to MIPI CSI-2 decoder which is capable of > > + receiving up to four analog stream and multiplexing them into up to four MIPI > > + CSI-2 virtual channels, using one MIPI clock lane and 1/2 data lanes. > > + > > +properties: > > + compatible: > > + enum: > > + - isil,isl79987 > > + > > + reg: > > + maxItems: 1 > > + > > + reset-gpios: > > + maxItems: 1 > > + description: > > + A GPIO spec for the RSTB pin (active high) > > + > > + powerdown-gpios: > > + maxItems: 1 > > + description: > > + A GPIO spec for the Power Down pin (active high) > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: Output port > > I think you need need the data-lanes property for endpoints on this port. Thanks. The bot also found that the clock-lanes property is missing, too. The following specification seems to satisfy the checker, but I'm not completely sure, if it is actually correct: port@0: $ref: /schemas/graph.yaml#/$defs/port-base unevaluatedProperties: false description: Output port properties: endpoint: $ref: /schemas/media/video-interfaces.yaml# unevaluatedProperties: false properties: clock-lanes: maxItems: 1 data-lanes: minItems: 1 maxItems: 2 required: - clock-lanes - data-lanes Is this how I can correctly add the clock-lanes and data-lanes properties to the endpoint? Michael > > > + > > + patternProperties: > > + "^port@[1-4]$": > > + $ref: /schemas/graph.yaml#/properties/port > > + description: Input ports > > + > > + required: > > + - port@0 > > + > > +additionalProperties: false > > + > > +required: > > + - compatible > > + - reg > > + - ports > > + > > +examples: > > + - | > > + #include > > + > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + isl7998x_mipi@44 { > > + compatible = "isil,isl79987"; > > + reg = <0x44>; > > + powerdown-gpios = <&gpio3 27 GPIO_ACTIVE_HIGH>; > > + reset-gpios = <&gpio3 28 GPIO_ACTIVE_HIGH>; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + isl79987_out: endpoint { > > + remote-endpoint = <&mipi_csi2_in>; > > + clock-lanes = <0>; > > + data-lanes = <1 2>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + endpoint { > > + remote-endpoint = <&camera_0>; > > + }; > > + }; > > + > > + port@2 { > > + reg = <2>; > > + endpoint { > > + remote-endpoint = <&camera_1>; > > + }; > > + }; > > + }; > > + }; > > + }; > > -- > Kind regards, > > Sakari Ailus >