[PATCH] dt-bindings: dma: snps,dw-axi-dmac: Group tuples in snps properties

[PATCH] dt-bindings: dma: snps,dw-axi-dmac: Group tuples in snps properties

[Geert Uytterhoeven]

To improve human readability and enable automatic validation, the tuples
in "snps,block-size" and "snps,priority" properties should be grouped
using angle brackets.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
index 79e241498e2532ce..90d9274e5464e396 100644
--- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
+++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
@@ -120,7 +120,7 @@ examples:
          dma-channels = <4>;
          snps,dma-masters = <2>;
          snps,data-width = <3>;
-         snps,block-size = <4096 4096 4096 4096>;
-         snps,priority = <0 1 2 3>;
+         snps,block-size = <4096>, <4096>, <4096>, <4096>;
+         snps,priority = <0>, <1>, <2>, <3>;
          snps,axi-max-burst-len = <16>;
      };
-- 
2.25.1

Re: [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Group tuples in snps properties

[Rob Herring]

On Thu, Nov 25, 2021 at 04:19:18PM +0100, Geert Uytterhoeven wrote:
> To improve human readability and enable automatic validation, the tuples
> in "snps,block-size" and "snps,priority" properties should be grouped
> using angle brackets.

For these, the tools should allow either way. Where are you seeing an 
error?

I tried to rationalize which way should be 'correct' and gave up. I 
think bracketing only makes sense for matrix and phandle+arg cases.

> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>  Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> index 79e241498e2532ce..90d9274e5464e396 100644
> --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> @@ -120,7 +120,7 @@ examples:
>           dma-channels = <4>;
>           snps,dma-masters = <2>;
>           snps,data-width = <3>;
> -         snps,block-size = <4096 4096 4096 4096>;
> -         snps,priority = <0 1 2 3>;
> +         snps,block-size = <4096>, <4096>, <4096>, <4096>;
> +         snps,priority = <0>, <1>, <2>, <3>;
>           snps,axi-max-burst-len = <16>;
>       };
> -- 
> 2.25.1
> 
> 

Re: [PATCH] dt-bindings: dma: snps,dw-axi-dmac: Group tuples in snps properties

[Geert Uytterhoeven]

Hi Rob,

On Wed, Dec 1, 2021 at 11:44 PM Rob Herring <robh@kernel.org> wrote:
> On Thu, Nov 25, 2021 at 04:19:18PM +0100, Geert Uytterhoeven wrote:
> > To improve human readability and enable automatic validation, the tuples
> > in "snps,block-size" and "snps,priority" properties should be grouped
> > using angle brackets.
>
> For these, the tools should allow either way. Where are you seeing an
> error?

Good to know. I'm not seeing any errors.

> I tried to rationalize which way should be 'correct' and gave up. I
> think bracketing only makes sense for matrix and phandle+arg cases.

That makes sense.  And "interrupts" is special, because it's really a
short-hand for "interrupts-extended", with the phandle specified by
"interrupt-parent" at the same or a higher level.

Hence I'll drop this patch.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds