Re: [PATCH v3 1/2] dt-bindings: watchdog: renesas,wdt: Add support for RZ/G2L

[Guenter Roeck <linux@roeck-us.net>]

On Mon, Nov 22, 2021 at 11:35:53AM +0000, Biju Das wrote:
> Describe the WDT hardware in the RZ/G2L series.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> V2->v3:
>  * No change.
> V1->V2:
>  * No Change
> RFC->V1:
>  * Added clock-names and interrupt-names as required properties for RZ/G2L
>  * Re-order clocknames with internal module clock first
> ---
>  .../bindings/watchdog/renesas,wdt.yaml        | 75 ++++++++++++++-----
>  1 file changed, 57 insertions(+), 18 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml b/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
> index ab66d3f0c476..91a98ccd4226 100644
> --- a/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml
> @@ -10,9 +10,6 @@ maintainers:
>    - Wolfram Sang <wsa+renesas@sang-engineering.com>
>    - Geert Uytterhoeven <geert+renesas@glider.be>
>  
> -allOf:
> -  - $ref: "watchdog.yaml#"
> -
>  properties:
>    compatible:
>      oneOf:
> @@ -22,6 +19,11 @@ properties:
>                - renesas,r7s9210-wdt      # RZ/A2
>            - const: renesas,rza-wdt       # RZ/A
>  
> +      - items:
> +          - enum:
> +              - renesas,r9a07g044-wdt    # RZ/G2{L,LC}
> +          - const: renesas,rzg2l-wdt     # RZ/G2L
> +
>        - items:
>            - enum:
>                - renesas,r8a7742-wdt      # RZ/G1H
> @@ -56,11 +58,13 @@ properties:
>    reg:
>      maxItems: 1
>  
> -  interrupts:
> -    maxItems: 1
> +  interrupts: true
>  
> -  clocks:
> -    maxItems: 1
> +  interrupt-names: true
> +
> +  clocks: true
> +
> +  clock-names: true
>  
>    power-domains:
>      maxItems: 1
> @@ -75,17 +79,52 @@ required:
>    - reg
>    - clocks
>  
> -if:
> -  not:
> -    properties:
> -      compatible:
> -        contains:
> -          enum:
> -            - renesas,rza-wdt
> -then:
> -  required:
> -    - power-domains
> -    - resets
> +allOf:
> +  - $ref: "watchdog.yaml#"
> +
> +  - if:
> +      not:
> +        properties:
> +          compatible:
> +            contains:
> +              enum:
> +                - renesas,rza-wdt
> +    then:
> +      required:
> +        - power-domains
> +        - resets
> +
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - renesas,rzg2l-wdt
> +    then:
> +      properties:
> +        interrupts:
> +          maxItems: 2
> +        interrupt-names:
> +          items:
> +            - const: wdt
> +            - const: perrout
> +        clocks:
> +          items:
> +            - description: Register access clock
> +            - description: Main clock
> +        clock-names:
> +          items:
> +            - const: pclk
> +            - const: oscclk
> +      required:
> +        - clock-names
> +        - interrupt-names
> +    else:
> +      properties:
> +        interrupts:
> +          maxItems: 1
> +        clocks:
> +          maxItems: 1
>  
>  additionalProperties: false
>  
> -- 
> 2.17.1
>