From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9B14C433EF for ; Thu, 2 Dec 2021 07:25:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239190AbhLBH2s convert rfc822-to-8bit (ORCPT ); Thu, 2 Dec 2021 02:28:48 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:51813 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235587AbhLBH2s (ORCPT ); Thu, 2 Dec 2021 02:28:48 -0500 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id DEABCE0008; Thu, 2 Dec 2021 07:25:21 +0000 (UTC) Date: Thu, 2 Dec 2021 08:25:21 +0100 From: Miquel Raynal To: Rob Herring Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Pratyush Yadav , Michael Walle , linux-mtd@lists.infradead.org, Mark Brown , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, Thomas Petazzoni , Michal Simek Subject: Re: [PATCH v2 2/5] dt-bindings: mtd: spi-nor: Allow external properties Message-ID: <20211202082521.77c2837f@xps13> In-Reply-To: References: <20211126163450.394861-1-miquel.raynal@bootlin.com> <20211126163450.394861-3-miquel.raynal@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, robh@kernel.org wrote on Wed, 1 Dec 2021 18:05:41 -0600: > On Fri, Nov 26, 2021 at 05:34:47PM +0100, Miquel Raynal wrote: > > Setting "additionalProperties: false" will refuse any generic SPI > > property while they should be of course authorized. In practice it looks > > like many people used compatibles different than "jedec,spi-nor" in > > order to workaround this limitation because otherwise no SPI property > > could be used in the examples. Use "unevaluatedProperties: false" > > instead to allow defined properties to be used. It is likely that at the > > time of the conversion to yaml of the jedec file, the unevaluated > > keyword was not yet introduced. > > > > Fixes: 3ff9ee2a8890 ("dt-bindings: mtd: spi-nor: Convert to DT schema format") > > Signed-off-by: Miquel Raynal > > --- > > Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml > > index ed590d7c6e37..81be0620b264 100644 > > --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml > > +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml > > @@ -88,7 +88,7 @@ patternProperties: > > "^otp(-[0-9]+)?$": > > type: object > > > > -additionalProperties: false > > +unevaluatedProperties: false > > This has no effect unless you have referenced some other schema here. > The series I referenced will solve what your trying to solve I think. Maybe this is not the right fix indeed, but my understanding of json reaches its bounds here. Without this change, any example in this file that references a spi-controller.yaml property (which is correctly defined) will throw an error. The fact is, all the examples out there with a spi-nor flash using the jedec,spi-nor compatible *cannot* contain any spi-controller.yaml property, otherwise the tooling errors out. This is a real issue. I will give Pratyush's series a try. Thanks, Miquèl