devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marten Lindahl <martenli@axis.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: "Mårten Lindahl" <Marten.Lindahl@axis.com>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Jaehoon Chung" <jh80.chung@samsung.com>,
	"Doug Anderson" <dianders@google.com>, kernel <kernel@axis.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH 1/4] dt-bindings: mmc: exynos-dw-mshc: Add support for ARTPEC-8
Date: Fri, 3 Dec 2021 13:00:07 +0100	[thread overview]
Message-ID: <20211203120007.GA23260@axis.com> (raw)
In-Reply-To: <c6a44fd1-ad48-06cc-4a96-818ca124afca@canonical.com>

On Thu, Dec 02, 2021 at 09:41:05AM +0100, Krzysztof Kozlowski wrote:

Hi Krzysztof!
Thanks for looking at this!

> On 01/12/2021 16:38, Mårten Lindahl wrote:
> > The ARTPEC-8 SoC has a DWMMC controller that is compatible with the
> > Exynos 7 version v2.70a. The main differences from Exynos 7 is that it
> > does not support HS400 and has extended data read timeout.
> > 
> > Add compatibility string "samsung,artpec8-dw-mshc" for ARTPEC-8.
> > 
> > Signed-off-by: Mårten Lindahl <marten.lindahl@axis.com>
> > ---
> >  Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
> > index 0419a63f73a0..161be451a1f0 100644
> > --- a/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
> > +++ b/Documentation/devicetree/bindings/mmc/exynos-dw-mshc.txt
> > @@ -22,6 +22,8 @@ Required Properties:
> >  	  specific extensions.
> >  	- "samsung,exynos7-dw-mshc-smu": for controllers with Samsung Exynos7
> >  	  specific extensions having an SMU.
> > +	- "samsung,artpec8-dw-mshc": for controllers with ARTPEC-8 specific
> > +	  extensions.
> 
> Artpec8 does not look like Samsung, so vendor prefix does not match.

Since the IP is very similar, I just copied the vendor prefix from the others,
but ok, I will change it to 'axis'.

Kind regards
Mårten

> 
> Best regards,
> Krzysztof

  reply	other threads:[~2021-12-03 12:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-01 15:38 [PATCH 0/4] Add ARTPEC-8 support to DWMMC controller Mårten Lindahl
2021-12-01 15:38 ` [PATCH 1/4] dt-bindings: mmc: exynos-dw-mshc: Add support for ARTPEC-8 Mårten Lindahl
2021-12-02  8:41   ` Krzysztof Kozlowski
2021-12-03 12:00     ` Marten Lindahl [this message]
2021-12-01 15:38 ` [PATCH 2/4] mmc: dw_mmc-exynos: " Mårten Lindahl
2021-12-01 15:38 ` [PATCH 3/4] mmc: dw_mmc: Add quirk for extended data read timeout Mårten Lindahl
2021-12-02  8:39   ` Krzysztof Kozlowski
2021-12-03 12:02     ` Marten Lindahl
2021-12-01 15:38 ` [PATCH 4/4] mmc: dw_mmc: Do not wait for DTO in case of error Mårten Lindahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211203120007.GA23260@axis.com \
    --to=martenli@axis.com \
    --cc=Marten.Lindahl@axis.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@google.com \
    --cc=jh80.chung@samsung.com \
    --cc=kernel@axis.com \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).