devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: imx8mq: remove interconnect property from lcdif
@ 2021-11-24  8:37 Martin Kepplinger
  2021-12-06  1:38 ` Shawn Guo
  0 siblings, 1 reply; 2+ messages in thread
From: Martin Kepplinger @ 2021-11-24  8:37 UTC (permalink / raw)
  To: martin.kepplinger, shawnguo
  Cc: devicetree, festevam, kernel, kernel, krzk, linux-arm-kernel,
	linux-imx, linux-kernel, robh

The mxsfb driver handling imx8mq lcdif doesn't yet request the
interconnect bandwidth that's needed at runtime when the description is
present in the DT node.

So remove that description and bring it back when it's supported.

Fixes: ad1abc8a03fd ("arm64: dts: imx8mq: Add interconnect for lcdif")
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---

revision history
----------------
this patch replaces the wrong 1:1 revert previously sent:
https://lore.kernel.org/linux-arm-kernel/20211123114545.411787-1-martin.kepplinger@puri.sm/


 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 972766b67a15..71bf497f99c2 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -524,8 +524,6 @@ lcdif: lcd-controller@30320000 {
 						  <&clk IMX8MQ_VIDEO_PLL1>,
 						  <&clk IMX8MQ_VIDEO_PLL1_OUT>;
 				assigned-clock-rates = <0>, <0>, <0>, <594000000>;
-				interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>;
-				interconnect-names = "dram";
 				status = "disabled";
 
 				port@0 {
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: imx8mq: remove interconnect property from lcdif
  2021-11-24  8:37 [PATCH] arm64: dts: imx8mq: remove interconnect property from lcdif Martin Kepplinger
@ 2021-12-06  1:38 ` Shawn Guo
  0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2021-12-06  1:38 UTC (permalink / raw)
  To: Martin Kepplinger
  Cc: devicetree, festevam, kernel, Abel Vesa, kernel, krzk,
	linux-arm-kernel, linux-imx, linux-kernel, robh

+ Abel

On Wed, Nov 24, 2021 at 09:37:03AM +0100, Martin Kepplinger wrote:
> The mxsfb driver handling imx8mq lcdif doesn't yet request the
> interconnect bandwidth that's needed at runtime when the description is
> present in the DT node.
> 
> So remove that description and bring it back when it's supported.
> 
> Fixes: ad1abc8a03fd ("arm64: dts: imx8mq: Add interconnect for lcdif")
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>

Applied, thanks.

> ---
> 
> revision history
> ----------------
> this patch replaces the wrong 1:1 revert previously sent:
> https://lore.kernel.org/linux-arm-kernel/20211123114545.411787-1-martin.kepplinger@puri.sm/
> 
> 
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 972766b67a15..71bf497f99c2 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -524,8 +524,6 @@ lcdif: lcd-controller@30320000 {
>  						  <&clk IMX8MQ_VIDEO_PLL1>,
>  						  <&clk IMX8MQ_VIDEO_PLL1_OUT>;
>  				assigned-clock-rates = <0>, <0>, <0>, <594000000>;
> -				interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>;
> -				interconnect-names = "dram";
>  				status = "disabled";
>  
>  				port@0 {
> -- 
> 2.30.2
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-06  1:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-24  8:37 [PATCH] arm64: dts: imx8mq: remove interconnect property from lcdif Martin Kepplinger
2021-12-06  1:38 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).