* [PATCH v2] ARM: dts: imx6ull-pinfunc: Fix CSI_DATA07__ESAI_TX0 pad name
@ 2021-11-24 18:45 Fabio Estevam
2021-12-01 22:19 ` Rob Herring
2021-12-06 1:41 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Fabio Estevam @ 2021-11-24 18:45 UTC (permalink / raw)
To: shawnguo
Cc: robh+dt, devicetree, linux-arm-kernel, otavio, georgemakarov1,
Fabio Estevam
According to the i.MX6ULL Reference Manual, pad CSI_DATA07 may
have the ESAI_TX0 functionality, not ESAI_T0.
Also, NXP's i.MX Config Tools 10.0 generates dtsi with the
MX6ULL_PAD_CSI_DATA07__ESAI_TX0 naming, so fix it accordingly.
There are no devicetree users in mainline that use the old name,
so just remove the old entry.
Fixes: c201369d4aa5 ("ARM: dts: imx6ull: add imx6ull support")
Reported-by: George Makarov <georgemakarov1@gmail.com>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v1:
- Remove the old name (Shawn, Otavio)
arch/arm/boot/dts/imx6ull-pinfunc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6ull-pinfunc.h b/arch/arm/boot/dts/imx6ull-pinfunc.h
index eb025a9d4759..7328d4ef8559 100644
--- a/arch/arm/boot/dts/imx6ull-pinfunc.h
+++ b/arch/arm/boot/dts/imx6ull-pinfunc.h
@@ -82,6 +82,6 @@
#define MX6ULL_PAD_CSI_DATA04__ESAI_TX_FS 0x01F4 0x0480 0x0000 0x9 0x0
#define MX6ULL_PAD_CSI_DATA05__ESAI_TX_CLK 0x01F8 0x0484 0x0000 0x9 0x0
#define MX6ULL_PAD_CSI_DATA06__ESAI_TX5_RX0 0x01FC 0x0488 0x0000 0x9 0x0
-#define MX6ULL_PAD_CSI_DATA07__ESAI_T0 0x0200 0x048C 0x0000 0x9 0x0
+#define MX6ULL_PAD_CSI_DATA07__ESAI_TX0 0x0200 0x048C 0x0000 0x9 0x0
#endif /* __DTS_IMX6ULL_PINFUNC_H */
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] ARM: dts: imx6ull-pinfunc: Fix CSI_DATA07__ESAI_TX0 pad name
2021-11-24 18:45 [PATCH v2] ARM: dts: imx6ull-pinfunc: Fix CSI_DATA07__ESAI_TX0 pad name Fabio Estevam
@ 2021-12-01 22:19 ` Rob Herring
2021-12-06 1:41 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-12-01 22:19 UTC (permalink / raw)
To: Fabio Estevam
Cc: devicetree, georgemakarov1, robh+dt, linux-arm-kernel, otavio,
shawnguo
On Wed, 24 Nov 2021 15:45:41 -0300, Fabio Estevam wrote:
> According to the i.MX6ULL Reference Manual, pad CSI_DATA07 may
> have the ESAI_TX0 functionality, not ESAI_T0.
>
> Also, NXP's i.MX Config Tools 10.0 generates dtsi with the
> MX6ULL_PAD_CSI_DATA07__ESAI_TX0 naming, so fix it accordingly.
>
> There are no devicetree users in mainline that use the old name,
> so just remove the old entry.
>
> Fixes: c201369d4aa5 ("ARM: dts: imx6ull: add imx6ull support")
> Reported-by: George Makarov <georgemakarov1@gmail.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Changes since v1:
> - Remove the old name (Shawn, Otavio)
>
> arch/arm/boot/dts/imx6ull-pinfunc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] ARM: dts: imx6ull-pinfunc: Fix CSI_DATA07__ESAI_TX0 pad name
2021-11-24 18:45 [PATCH v2] ARM: dts: imx6ull-pinfunc: Fix CSI_DATA07__ESAI_TX0 pad name Fabio Estevam
2021-12-01 22:19 ` Rob Herring
@ 2021-12-06 1:41 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2021-12-06 1:41 UTC (permalink / raw)
To: Fabio Estevam
Cc: robh+dt, devicetree, linux-arm-kernel, otavio, georgemakarov1
On Wed, Nov 24, 2021 at 03:45:41PM -0300, Fabio Estevam wrote:
> According to the i.MX6ULL Reference Manual, pad CSI_DATA07 may
> have the ESAI_TX0 functionality, not ESAI_T0.
>
> Also, NXP's i.MX Config Tools 10.0 generates dtsi with the
> MX6ULL_PAD_CSI_DATA07__ESAI_TX0 naming, so fix it accordingly.
>
> There are no devicetree users in mainline that use the old name,
> so just remove the old entry.
>
> Fixes: c201369d4aa5 ("ARM: dts: imx6ull: add imx6ull support")
> Reported-by: George Makarov <georgemakarov1@gmail.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-06 1:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-24 18:45 [PATCH v2] ARM: dts: imx6ull-pinfunc: Fix CSI_DATA07__ESAI_TX0 pad name Fabio Estevam
2021-12-01 22:19 ` Rob Herring
2021-12-06 1:41 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).