* [PATCH v2] arm64: dts: mt8183: kukui: Add Type C node
@ 2021-12-09 19:51 Prashant Malani
2021-12-09 22:49 ` Alexandru M Stan
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Prashant Malani @ 2021-12-09 19:51 UTC (permalink / raw)
To: linux-kernel, linux-mediatek
Cc: Prashant Malani, Alexandru M Stan, Benson Leung,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Mediatek SoC support, Matthias Brugger,
Rob Herring
Add a node describing the USB Type C connector, in order to utilize the
Chromium OS USB Type-C driver that enumerates Type-C ports and connected
cables/peripherals and makes them visible to userspace.
Cc: Alexandru M Stan <amstan@chromium.org>
Cc: Benson Leung <bleung@chromium.org>
Signed-off-by: Prashant Malani <pmalani@chromium.org>
---
Changes in v2:
- Alexandru mentioned that HW specs suggest preferred power role for
devices like kukui to be sink, so changed try-power-role to "sink".
arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
index 94c13c459194..0f9480f91261 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
@@ -886,6 +886,20 @@ usbc_extcon: extcon0 {
cbas {
compatible = "google,cros-cbas";
};
+
+ typec {
+ compatible = "google,cros-ec-typec";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ usb_c0: connector@0 {
+ compatible = "usb-c-connector";
+ reg = <0>;
+ power-role = "dual";
+ data-role = "host";
+ try-power-role = "sink";
+ };
+ };
};
};
--
2.34.1.173.g76aa8bc2d0-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] arm64: dts: mt8183: kukui: Add Type C node
2021-12-09 19:51 [PATCH v2] arm64: dts: mt8183: kukui: Add Type C node Prashant Malani
@ 2021-12-09 22:49 ` Alexandru M Stan
2021-12-09 23:04 ` Benson Leung
2021-12-15 20:02 ` Matthias Brugger
2 siblings, 0 replies; 4+ messages in thread
From: Alexandru M Stan @ 2021-12-09 22:49 UTC (permalink / raw)
To: Prashant Malani
Cc: linux-kernel, linux-mediatek, Benson Leung,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Mediatek SoC support, Matthias Brugger,
Rob Herring
On Thu, Dec 9, 2021 at 11:51 AM Prashant Malani <pmalani@chromium.org> wrote:
>
> Add a node describing the USB Type C connector, in order to utilize the
> Chromium OS USB Type-C driver that enumerates Type-C ports and connected
> cables/peripherals and makes them visible to userspace.
>
> Cc: Alexandru M Stan <amstan@chromium.org>
> Cc: Benson Leung <bleung@chromium.org>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
> ---
>
> Changes in v2:
> - Alexandru mentioned that HW specs suggest preferred power role for
> devices like kukui to be sink, so changed try-power-role to "sink".
>
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index 94c13c459194..0f9480f91261 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -886,6 +886,20 @@ usbc_extcon: extcon0 {
> cbas {
> compatible = "google,cros-cbas";
> };
> +
> + typec {
> + compatible = "google,cros-ec-typec";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + usb_c0: connector@0 {
> + compatible = "usb-c-connector";
> + reg = <0>;
> + power-role = "dual";
> + data-role = "host";
> + try-power-role = "sink";
> + };
> + };
> };
> };
>
> --
> 2.34.1.173.g76aa8bc2d0-goog
>
Thanks!
Reviewed-by: Alexandru M Stan <amstan@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] arm64: dts: mt8183: kukui: Add Type C node
2021-12-09 19:51 [PATCH v2] arm64: dts: mt8183: kukui: Add Type C node Prashant Malani
2021-12-09 22:49 ` Alexandru M Stan
@ 2021-12-09 23:04 ` Benson Leung
2021-12-15 20:02 ` Matthias Brugger
2 siblings, 0 replies; 4+ messages in thread
From: Benson Leung @ 2021-12-09 23:04 UTC (permalink / raw)
To: Prashant Malani
Cc: linux-kernel, linux-mediatek, Alexandru M Stan, Benson Leung,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Mediatek SoC support, Matthias Brugger,
Rob Herring
[-- Attachment #1: Type: text/plain, Size: 1664 bytes --]
On Thu, Dec 09, 2021 at 11:51:12AM -0800, Prashant Malani wrote:
> Add a node describing the USB Type C connector, in order to utilize the
> Chromium OS USB Type-C driver that enumerates Type-C ports and connected
> cables/peripherals and makes them visible to userspace.
>
> Cc: Alexandru M Stan <amstan@chromium.org>
> Cc: Benson Leung <bleung@chromium.org>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>
> ---
>
> Changes in v2:
> - Alexandru mentioned that HW specs suggest preferred power role for
> devices like kukui to be sink, so changed try-power-role to "sink".
>
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index 94c13c459194..0f9480f91261 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -886,6 +886,20 @@ usbc_extcon: extcon0 {
> cbas {
> compatible = "google,cros-cbas";
> };
> +
> + typec {
> + compatible = "google,cros-ec-typec";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + usb_c0: connector@0 {
> + compatible = "usb-c-connector";
> + reg = <0>;
> + power-role = "dual";
> + data-role = "host";
> + try-power-role = "sink";
> + };
> + };
> };
> };
>
> --
> 2.34.1.173.g76aa8bc2d0-goog
>
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] arm64: dts: mt8183: kukui: Add Type C node
2021-12-09 19:51 [PATCH v2] arm64: dts: mt8183: kukui: Add Type C node Prashant Malani
2021-12-09 22:49 ` Alexandru M Stan
2021-12-09 23:04 ` Benson Leung
@ 2021-12-15 20:02 ` Matthias Brugger
2 siblings, 0 replies; 4+ messages in thread
From: Matthias Brugger @ 2021-12-15 20:02 UTC (permalink / raw)
To: Prashant Malani, linux-kernel, linux-mediatek
Cc: Alexandru M Stan, Benson Leung,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Mediatek SoC support, Rob Herring
On 09/12/2021 20:51, Prashant Malani wrote:
> Add a node describing the USB Type C connector, in order to utilize the
> Chromium OS USB Type-C driver that enumerates Type-C ports and connected
> cables/peripherals and makes them visible to userspace.
>
> Cc: Alexandru M Stan <amstan@chromium.org>
> Cc: Benson Leung <bleung@chromium.org>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>
Applied to v5.16-next/dts64
Thanks
> ---
>
> Changes in v2:
> - Alexandru mentioned that HW specs suggest preferred power role for
> devices like kukui to be sink, so changed try-power-role to "sink".
>
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index 94c13c459194..0f9480f91261 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -886,6 +886,20 @@ usbc_extcon: extcon0 {
> cbas {
> compatible = "google,cros-cbas";
> };
> +
> + typec {
> + compatible = "google,cros-ec-typec";
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + usb_c0: connector@0 {
> + compatible = "usb-c-connector";
> + reg = <0>;
> + power-role = "dual";
> + data-role = "host";
> + try-power-role = "sink";
> + };
> + };
> };
> };
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-15 20:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-09 19:51 [PATCH v2] arm64: dts: mt8183: kukui: Add Type C node Prashant Malani
2021-12-09 22:49 ` Alexandru M Stan
2021-12-09 23:04 ` Benson Leung
2021-12-15 20:02 ` Matthias Brugger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).