* [PATCH] arm64: dts: qcom: apq8016-sbc: Fix dtbs_check warnings for &sound
@ 2021-12-14 13:51 Stephan Gerhold
  2022-02-01  5:20 ` (subset) " Bjorn Andersson
  0 siblings, 1 reply; 2+ messages in thread
From: Stephan Gerhold @ 2021-12-14 13:51 UTC (permalink / raw)
  To: Bjorn Andersson
  Cc: Andy Gross, linux-arm-msm, devicetree, Rob Herring,
	Stephan Gerhold, Srinivas Kandagatla
qcom,apq8016-sbc-sndcard is now covered by the qcom,sm8250.yaml schema
which has slightly different recommendations for the naming of
properties and nodes. The old naming is still functional but
deprecated. Update the &sound node in apq8016-sbc to fix the following
dtbs_check warnings:
  apq8016-sbc.dt.yaml: sound@7702000: 'model' is a required property
    From schema: sound/qcom,sm8250.yaml
  apq8016-sbc.dt.yaml: sound@7702000: 'external-dai-link@0', ...
    do not match any of the regexes: '.*-dai-link$', ...
    From schema: sound/qcom,sm8250.yaml
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
---
 arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
index a5320d6d30e7..0c566876333a 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
@@ -351,12 +351,12 @@ &sound {
 	pinctrl-0 = <&cdc_pdm_lines_act &ext_sec_tlmm_lines_act &ext_mclk_tlmm_lines_act>;
 	pinctrl-1 = <&cdc_pdm_lines_sus &ext_sec_tlmm_lines_sus &ext_mclk_tlmm_lines_sus>;
 	pinctrl-names = "default", "sleep";
-	qcom,model = "DB410c";
-	qcom,audio-routing =
+	model = "DB410c";
+	audio-routing =
 		"AMIC2", "MIC BIAS Internal2",
 		"AMIC3", "MIC BIAS External1";
 
-	external-dai-link@0 {
+	quaternary-dai-link {
 		link-name = "ADV7533";
 		cpu {
 			sound-dai = <&lpass MI2S_QUATERNARY>;
@@ -366,7 +366,7 @@ codec {
 		};
 	};
 
-	internal-codec-playback-dai-link@0 {
+	primary-dai-link {
 		link-name = "WCD";
 		cpu {
 			sound-dai = <&lpass MI2S_PRIMARY>;
@@ -376,7 +376,7 @@ codec {
 		};
 	};
 
-	internal-codec-capture-dai-link@0 {
+	tertiary-dai-link {
 		link-name = "WCD-Capture";
 		cpu {
 			sound-dai = <&lpass MI2S_TERTIARY>;
-- 
2.34.1
^ permalink raw reply related	[flat|nested] 2+ messages in thread
* Re: (subset) [PATCH] arm64: dts: qcom: apq8016-sbc: Fix dtbs_check warnings for &sound
  2021-12-14 13:51 [PATCH] arm64: dts: qcom: apq8016-sbc: Fix dtbs_check warnings for &sound Stephan Gerhold
@ 2022-02-01  5:20 ` Bjorn Andersson
  0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2022-02-01  5:20 UTC (permalink / raw)
  To: Stephan Gerhold
  Cc: Rob Herring, devicetree, Andy Gross, Srinivas Kandagatla,
	linux-arm-msm
On Tue, 14 Dec 2021 14:51:24 +0100, Stephan Gerhold wrote:
> qcom,apq8016-sbc-sndcard is now covered by the qcom,sm8250.yaml schema
> which has slightly different recommendations for the naming of
> properties and nodes. The old naming is still functional but
> deprecated. Update the &sound node in apq8016-sbc to fix the following
> dtbs_check warnings:
> 
>   apq8016-sbc.dt.yaml: sound@7702000: 'model' is a required property
>     From schema: sound/qcom,sm8250.yaml
>   apq8016-sbc.dt.yaml: sound@7702000: 'external-dai-link@0', ...
>     do not match any of the regexes: '.*-dai-link$', ...
>     From schema: sound/qcom,sm8250.yaml
> 
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: apq8016-sbc: Fix dtbs_check warnings for &sound
      commit: ff15ae73eeee62d8eb7554ecc21f2908f32f33a9
Best regards,
-- 
Bjorn Andersson <bjorn.andersson@linaro.org>
^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-01  5:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-14 13:51 [PATCH] arm64: dts: qcom: apq8016-sbc: Fix dtbs_check warnings for &sound Stephan Gerhold
2022-02-01  5:20 ` (subset) " Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).