* [PATCH v2] arm64: dts: imx8mp-evk: configure multiple queues on eqos
@ 2021-12-13 4:45 Xiaoliang Yang
2021-12-13 6:22 ` Joakim Zhang
2021-12-16 6:49 ` Shawn Guo
0 siblings, 2 replies; 3+ messages in thread
From: Xiaoliang Yang @ 2021-12-13 4:45 UTC (permalink / raw)
To: robh+dt, shawnguo, s.hauer, festevam
Cc: linux-arm-kernel, linux-tegra, linux-imx, kernel, devicetree,
qiangqing.zhang, xiaoliang.yang_1
Eqos ethernet support five queues on hardware, enable these queues and
configure the priority of each queue. Uses Strict Priority as scheduling
algorithms to ensure that the TSN function works.
The priority of each queue is a bitmask value that maps VLAN tag
priority to the queue. Since the hardware only supports five queues,
this patch maps priority 0-4 to queues one by one, and priority 5-7 to
queue 4.
The total fifo size of 5 queues is 8192 bytes, if enable 5 queues with
store-and-forward mode, it's not enough for large packets, which would
trigger fifo overflow frequently. This patch set DMA to thresh mode to
enable all 5 queues.
Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 57 ++++++++++++++++++++
1 file changed, 57 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
index 7b99fad6e4d6..e4c69594f067 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
@@ -86,6 +86,9 @@
pinctrl-0 = <&pinctrl_eqos>;
phy-mode = "rgmii-id";
phy-handle = <ðphy0>;
+ snps,force_thresh_dma_mode;
+ snps,mtl-tx-config = <&mtl_tx_setup>;
+ snps,mtl-rx-config = <&mtl_rx_setup>;
status = "okay";
mdio {
@@ -99,6 +102,60 @@
eee-broken-1000t;
};
};
+
+ mtl_tx_setup: tx-queues-config {
+ snps,tx-queues-to-use = <5>;
+ snps,tx-sched-sp;
+ queue0 {
+ snps,dcb-algorithm;
+ snps,priority = <0x1>;
+ };
+ queue1 {
+ snps,dcb-algorithm;
+ snps,priority = <0x2>;
+ };
+ queue2 {
+ snps,dcb-algorithm;
+ snps,priority = <0x4>;
+ };
+ queue3 {
+ snps,dcb-algorithm;
+ snps,priority = <0x8>;
+ };
+ queue4 {
+ snps,dcb-algorithm;
+ snps,priority = <0xf0>;
+ };
+ };
+ mtl_rx_setup: rx-queues-config {
+ snps,rx-queues-to-use = <5>;
+ snps,rx-sched-sp;
+ queue0 {
+ snps,dcb-algorithm;
+ snps,priority = <0x1>;
+ snps,map-to-dma-channel = <0>;
+ };
+ queue1 {
+ snps,dcb-algorithm;
+ snps,priority = <0x2>;
+ snps,map-to-dma-channel = <1>;
+ };
+ queue2 {
+ snps,dcb-algorithm;
+ snps,priority = <0x4>;
+ snps,map-to-dma-channel = <2>;
+ };
+ queue3 {
+ snps,dcb-algorithm;
+ snps,priority = <0x8>;
+ snps,map-to-dma-channel = <3>;
+ };
+ queue4 {
+ snps,dcb-algorithm;
+ snps,priority = <0xf0>;
+ snps,map-to-dma-channel = <4>;
+ };
+ };
};
&fec {
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH v2] arm64: dts: imx8mp-evk: configure multiple queues on eqos
2021-12-13 4:45 [PATCH v2] arm64: dts: imx8mp-evk: configure multiple queues on eqos Xiaoliang Yang
@ 2021-12-13 6:22 ` Joakim Zhang
2021-12-16 6:49 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Joakim Zhang @ 2021-12-13 6:22 UTC (permalink / raw)
To: Xiaoliang Yang, robh+dt@kernel.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, festevam@gmail.com
Cc: linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org,
dl-linux-imx, kernel@pengutronix.de, devicetree@vger.kernel.org,
Xiaoliang Yang
> -----Original Message-----
> From: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
> Sent: 2021年12月13日 12:46
> To: robh+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> festevam@gmail.com
> Cc: linux-arm-kernel@lists.infradead.org; linux-tegra@vger.kernel.org;
> dl-linux-imx <linux-imx@nxp.com>; kernel@pengutronix.de;
> devicetree@vger.kernel.org; Joakim Zhang <qiangqing.zhang@nxp.com>;
> Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
> Subject: [PATCH v2] arm64: dts: imx8mp-evk: configure multiple queues on
> eqos
>
> Eqos ethernet support five queues on hardware, enable these queues and
> configure the priority of each queue. Uses Strict Priority as scheduling
> algorithms to ensure that the TSN function works.
>
> The priority of each queue is a bitmask value that maps VLAN tag priority to
> the queue. Since the hardware only supports five queues, this patch maps
> priority 0-4 to queues one by one, and priority 5-7 to queue 4.
>
> The total fifo size of 5 queues is 8192 bytes, if enable 5 queues with
> store-and-forward mode, it's not enough for large packets, which would
> trigger fifo overflow frequently. This patch set DMA to thresh mode to
> enable all 5 queues.
>
> Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
> ---
Reviewed-by: Joakim Zhang <qiangqing.zhang@nxp.com>
Best Regards,
Joakim Zhang
> arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 57
> ++++++++++++++++++++
> 1 file changed, 57 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> index 7b99fad6e4d6..e4c69594f067 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> @@ -86,6 +86,9 @@
> pinctrl-0 = <&pinctrl_eqos>;
> phy-mode = "rgmii-id";
> phy-handle = <ðphy0>;
> + snps,force_thresh_dma_mode;
> + snps,mtl-tx-config = <&mtl_tx_setup>;
> + snps,mtl-rx-config = <&mtl_rx_setup>;
> status = "okay";
>
> mdio {
> @@ -99,6 +102,60 @@
> eee-broken-1000t;
> };
> };
> +
> + mtl_tx_setup: tx-queues-config {
> + snps,tx-queues-to-use = <5>;
> + snps,tx-sched-sp;
> + queue0 {
> + snps,dcb-algorithm;
> + snps,priority = <0x1>;
> + };
> + queue1 {
> + snps,dcb-algorithm;
> + snps,priority = <0x2>;
> + };
> + queue2 {
> + snps,dcb-algorithm;
> + snps,priority = <0x4>;
> + };
> + queue3 {
> + snps,dcb-algorithm;
> + snps,priority = <0x8>;
> + };
> + queue4 {
> + snps,dcb-algorithm;
> + snps,priority = <0xf0>;
> + };
> + };
> + mtl_rx_setup: rx-queues-config {
> + snps,rx-queues-to-use = <5>;
> + snps,rx-sched-sp;
> + queue0 {
> + snps,dcb-algorithm;
> + snps,priority = <0x1>;
> + snps,map-to-dma-channel = <0>;
> + };
> + queue1 {
> + snps,dcb-algorithm;
> + snps,priority = <0x2>;
> + snps,map-to-dma-channel = <1>;
> + };
> + queue2 {
> + snps,dcb-algorithm;
> + snps,priority = <0x4>;
> + snps,map-to-dma-channel = <2>;
> + };
> + queue3 {
> + snps,dcb-algorithm;
> + snps,priority = <0x8>;
> + snps,map-to-dma-channel = <3>;
> + };
> + queue4 {
> + snps,dcb-algorithm;
> + snps,priority = <0xf0>;
> + snps,map-to-dma-channel = <4>;
> + };
> + };
> };
>
> &fec {
> --
> 2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] arm64: dts: imx8mp-evk: configure multiple queues on eqos
2021-12-13 4:45 [PATCH v2] arm64: dts: imx8mp-evk: configure multiple queues on eqos Xiaoliang Yang
2021-12-13 6:22 ` Joakim Zhang
@ 2021-12-16 6:49 ` Shawn Guo
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2021-12-16 6:49 UTC (permalink / raw)
To: Xiaoliang Yang
Cc: robh+dt, s.hauer, festevam, linux-arm-kernel, linux-tegra,
linux-imx, kernel, devicetree, qiangqing.zhang
On Mon, Dec 13, 2021 at 12:45:46PM +0800, Xiaoliang Yang wrote:
> Eqos ethernet support five queues on hardware, enable these queues and
> configure the priority of each queue. Uses Strict Priority as scheduling
> algorithms to ensure that the TSN function works.
>
> The priority of each queue is a bitmask value that maps VLAN tag
> priority to the queue. Since the hardware only supports five queues,
> this patch maps priority 0-4 to queues one by one, and priority 5-7 to
> queue 4.
>
> The total fifo size of 5 queues is 8192 bytes, if enable 5 queues with
> store-and-forward mode, it's not enough for large packets, which would
> trigger fifo overflow frequently. This patch set DMA to thresh mode to
> enable all 5 queues.
>
> Signed-off-by: Xiaoliang Yang <xiaoliang.yang_1@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 57 ++++++++++++++++++++
> 1 file changed, 57 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> index 7b99fad6e4d6..e4c69594f067 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
> @@ -86,6 +86,9 @@
> pinctrl-0 = <&pinctrl_eqos>;
> phy-mode = "rgmii-id";
> phy-handle = <ðphy0>;
> + snps,force_thresh_dma_mode;
> + snps,mtl-tx-config = <&mtl_tx_setup>;
> + snps,mtl-rx-config = <&mtl_rx_setup>;
> status = "okay";
>
> mdio {
> @@ -99,6 +102,60 @@
> eee-broken-1000t;
> };
> };
> +
> + mtl_tx_setup: tx-queues-config {
> + snps,tx-queues-to-use = <5>;
> + snps,tx-sched-sp;
Please have a newline between properties and child node ...
> + queue0 {
> + snps,dcb-algorithm;
> + snps,priority = <0x1>;
> + };
... and also between nodes.
> + queue1 {
> + snps,dcb-algorithm;
> + snps,priority = <0x2>;
> + };
> + queue2 {
> + snps,dcb-algorithm;
> + snps,priority = <0x4>;
> + };
> + queue3 {
> + snps,dcb-algorithm;
> + snps,priority = <0x8>;
> + };
> + queue4 {
> + snps,dcb-algorithm;
> + snps,priority = <0xf0>;
> + };
> + };
Ditto
Shawn
> + mtl_rx_setup: rx-queues-config {
> + snps,rx-queues-to-use = <5>;
> + snps,rx-sched-sp;
> + queue0 {
> + snps,dcb-algorithm;
> + snps,priority = <0x1>;
> + snps,map-to-dma-channel = <0>;
> + };
> + queue1 {
> + snps,dcb-algorithm;
> + snps,priority = <0x2>;
> + snps,map-to-dma-channel = <1>;
> + };
> + queue2 {
> + snps,dcb-algorithm;
> + snps,priority = <0x4>;
> + snps,map-to-dma-channel = <2>;
> + };
> + queue3 {
> + snps,dcb-algorithm;
> + snps,priority = <0x8>;
> + snps,map-to-dma-channel = <3>;
> + };
> + queue4 {
> + snps,dcb-algorithm;
> + snps,priority = <0xf0>;
> + snps,map-to-dma-channel = <4>;
> + };
> + };
> };
>
> &fec {
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-16 6:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-13 4:45 [PATCH v2] arm64: dts: imx8mp-evk: configure multiple queues on eqos Xiaoliang Yang
2021-12-13 6:22 ` Joakim Zhang
2021-12-16 6:49 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).