From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: "Nuno Sá" <nuno.sa@analog.com>
Cc: <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>
Subject: Re: [PATCH 2/3] iio: ABI: add ABI file for the LTC2688 DAC
Date: Thu, 16 Dec 2021 13:35:12 +0000 [thread overview]
Message-ID: <20211216133458.307acea4@jic23-huawei> (raw)
In-Reply-To: <20211214165608.7903-3-nuno.sa@analog.com>
On Tue, 14 Dec 2021 17:56:07 +0100
Nuno Sá <nuno.sa@analog.com> wrote:
> Define the sysfs interface for toggle or dither capable channels. Dither
> capable channels will have the extended interface:
>
> * out_voltageY_dither_en
> * out_voltageY_dither_raw
> * out_voltageY_dither_raw_available
> * out_voltageY_dither_frequency
> * out_voltageY_dither_frequency_available
> * out_voltageY_dither_phase
> * out_voltageY_dither_phase_available
>
> Toggle enabled channels will have:
>
> * out_voltageY_toggle_en
> * out_voltageY_raw1
> * out_voltageY_symbol
>
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> ---
> +What: /sys/bus/iio/devices/iio:deviceX/out_voltageY_raw1
I was thinking more raw0 and raw1 rather than not having the 0 for the
first one. If someone has the device in a circuit where they want to use
the toggle mode then I'd assume they know about the special ABI and can
cope with this.
> +KernelVersion: 5.16
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + It has the same meaning as out_voltageY_raw. This attribute is
> + specific to toggle enabled channels and refers to the DAC output
> + code in the INPUT_B register while regular out_voltageY_raw
> + refers to INPUT_A. The same scale, offset, etc applies.
next prev parent reply other threads:[~2021-12-16 13:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 16:56 [PATCH 0/3] Add support for LTC2688 Nuno Sá
2021-12-14 16:56 ` [PATCH 1/3] iio: dac: add support for ltc2688 Nuno Sá
2021-12-15 10:23 ` Lars-Peter Clausen
2021-12-15 13:40 ` Sa, Nuno
2021-12-15 13:55 ` Sa, Nuno
2021-12-15 15:58 ` Lars-Peter Clausen
2021-12-15 17:08 ` Sa, Nuno
2021-12-16 14:11 ` Jonathan Cameron
2021-12-17 12:31 ` Sa, Nuno
2021-12-30 15:28 ` Jonathan Cameron
2022-01-07 15:44 ` Sa, Nuno
2021-12-14 16:56 ` [PATCH 2/3] iio: ABI: add ABI file for the LTC2688 DAC Nuno Sá
2021-12-16 13:35 ` Jonathan Cameron [this message]
2021-12-17 11:59 ` Sa, Nuno
2021-12-14 16:56 ` [PATCH 3/3] dt-bindings: iio: Add ltc2688 documentation Nuno Sá
2021-12-15 21:30 ` Rob Herring
2021-12-16 13:32 ` Jonathan Cameron
2021-12-17 9:09 ` Sa, Nuno
2021-12-30 15:43 ` Jonathan Cameron
2022-01-07 15:49 ` Sa, Nuno
2021-12-30 15:13 ` [PATCH 0/3] Add support for LTC2688 Jonathan Cameron
2022-01-07 15:32 ` Sa, Nuno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211216133458.307acea4@jic23-huawei \
--to=jic23@jic23.retrosnub.co.uk \
--cc=Michael.Hennerich@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox