Re: [PATCH net-next v7 7/9] net: lan966x: Add vlan support.

Horatiu Vultur
2021-12-18T12:58:40Z

The 12/17/2021 18:14, Vladimir Oltean wrote:
>
> On Fri, Dec 17, 2021 at 04:53:51PM +0100, Horatiu Vultur wrote:
> > @@ -120,7 +124,12 @@ static void lan966x_port_bridge_leave(struct lan966x_port *port,
> > if (!lan966x->bridge_mask)
> > lan966x->bridge = NULL;
> >
> > - lan966x_mac_cpu_learn(lan966x, port->dev->dev_addr, PORT_PVID);
> > + /* Set the port back to host mode */
> > + lan966x_vlan_port_set_vlan_aware(port, false);
> > + lan966x_vlan_port_set_vid(port, HOST_PVID, false, false);
> > + lan966x_vlan_port_apply(port);
> > +
> > + lan966x_mac_cpu_learn(lan966x, port->dev->dev_addr, HOST_PVID);
>
> Do you still need to re-learn the port MAC address?

It is not needed. I will remove this in the next version.

>
> > }

--
/Horatiu