From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: David Heidelberg <david@ixit.cz>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
~okias/devicetree@lists.sr.ht, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sdm845: add missing power-controller compatible
Date: Tue, 21 Dec 2021 12:28:45 +0530 [thread overview]
Message-ID: <20211221065845.GC26872@thinkpad> (raw)
In-Reply-To: <20211220211443.106754-1-david@ixit.cz>
On Mon, Dec 20, 2021 at 10:14:43PM +0100, David Heidelberg wrote:
> dt-schema expect to have fallback compatible, which is now in-place.
>
> Fixes warning generated by `make qcom/sdm845-oneplus-fajita.dtb`:
> arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: power-controller@c300000: compatible: ['qcom,sdm845-aoss-qmp'] is too short
> From schema: Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.yaml
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 92ab4513a08b..dbdb4243499c 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -4619,7 +4619,7 @@ aoss_reset: reset-controller@c2a0000 {
> };
>
> aoss_qmp: power-controller@c300000 {
> - compatible = "qcom,sdm845-aoss-qmp";
> + compatible = "qcom,sdm845-aoss-qmp", "qcom,aoss-qmp";
"qcom,sdm845-aoss-qmp" compatible is supported by the driver. So ideally we
don't need a fallback here.
Is this something for DT backwards compatibility?
Thanks,
Mani
> reg = <0 0x0c300000 0 0x100000>;
> interrupts = <GIC_SPI 389 IRQ_TYPE_EDGE_RISING>;
> mboxes = <&apss_shared 0>;
> --
> 2.34.1
>
next prev parent reply other threads:[~2021-12-21 6:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 21:14 [PATCH] arm64: dts: qcom: sdm845: add missing power-controller compatible David Heidelberg
2021-12-21 6:58 ` Manivannan Sadhasivam [this message]
2021-12-21 8:46 ` David Heidelberg
2022-02-01 5:19 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211221065845.GC26872@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~okias/devicetree@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).