* [PATCH] dt-bindings: remoteproc: ti: Fix the number of mailboxes
@ 2022-01-07 3:04 Rob Herring
2022-01-07 14:13 ` Suman Anna
0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2022-01-07 3:04 UTC (permalink / raw)
To: Ohad Ben-Cohen, Bjorn Andersson, Mathieu Poirier, Suman Anna
Cc: linux-remoteproc, devicetree, linux-kernel
Based on the example, the TI K3 DSP and R5 have 2 mailboxes, but the schema
says 1. Fix the schema.
Signed-off-by: Rob Herring <robh@kernel.org>
---
.../devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml | 2 +-
.../devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
index 5ec6505ac408..648144fa1582 100644
--- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
@@ -53,7 +53,7 @@ properties:
OMAP Mailbox specifier denoting the sub-mailbox, to be used for
communication with the remote processor. This property should match
with the sub-mailbox node used in the firmware image.
- maxItems: 1
+ maxItems: 2
memory-region:
minItems: 2
diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
index eeef255c4045..2c5f91ea5296 100644
--- a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
@@ -135,7 +135,7 @@ patternProperties:
OMAP Mailbox specifier denoting the sub-mailbox, to be used for
communication with the remote processor. This property should match
with the sub-mailbox node used in the firmware image.
- maxItems: 1
+ maxItems: 2
memory-region:
description: |
--
2.32.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: remoteproc: ti: Fix the number of mailboxes
2022-01-07 3:04 [PATCH] dt-bindings: remoteproc: ti: Fix the number of mailboxes Rob Herring
@ 2022-01-07 14:13 ` Suman Anna
2022-01-07 14:17 ` Suman Anna
0 siblings, 1 reply; 4+ messages in thread
From: Suman Anna @ 2022-01-07 14:13 UTC (permalink / raw)
To: Rob Herring, Ohad Ben-Cohen, Bjorn Andersson, Mathieu Poirier
Cc: linux-remoteproc, devicetree, linux-kernel, Nagalla, Hari
Hi Rob,
On 1/6/22 9:04 PM, Rob Herring wrote:
> Based on the example, the TI K3 DSP and R5 have 2 mailboxes, but the schema
> says 1. Fix the schema.
No, 1 is correct. The OMAP Mailbox binding uses #mbox-cells as 1 and not 0, and
uses a phandle as the cell-value.
regards
Suman
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml | 2 +-
> .../devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> index 5ec6505ac408..648144fa1582 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> @@ -53,7 +53,7 @@ properties:
> OMAP Mailbox specifier denoting the sub-mailbox, to be used for
> communication with the remote processor. This property should match
> with the sub-mailbox node used in the firmware image.
> - maxItems: 1
> + maxItems: 2
>
> memory-region:
> minItems: 2
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> index eeef255c4045..2c5f91ea5296 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
> @@ -135,7 +135,7 @@ patternProperties:
> OMAP Mailbox specifier denoting the sub-mailbox, to be used for
> communication with the remote processor. This property should match
> with the sub-mailbox node used in the firmware image.
> - maxItems: 1
> + maxItems: 2
>
> memory-region:
> description: |
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: remoteproc: ti: Fix the number of mailboxes
2022-01-07 14:13 ` Suman Anna
@ 2022-01-07 14:17 ` Suman Anna
2022-01-07 17:21 ` Rob Herring
0 siblings, 1 reply; 4+ messages in thread
From: Suman Anna @ 2022-01-07 14:17 UTC (permalink / raw)
To: Rob Herring, Ohad Ben-Cohen, Bjorn Andersson, Mathieu Poirier
Cc: linux-remoteproc, devicetree, linux-kernel, Nagalla, Hari
On 1/7/22 8:13 AM, Suman Anna wrote:
> Hi Rob,
>
> On 1/6/22 9:04 PM, Rob Herring wrote:
>> Based on the example, the TI K3 DSP and R5 have 2 mailboxes, but the schema
>> says 1. Fix the schema.
>
> No, 1 is correct. The OMAP Mailbox binding uses #mbox-cells as 1 and not 0, and
> uses a phandle as the cell-value.
The following is what you get with your current patch,
Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.example.dt.yaml:
dsp@4d80800000: mboxes: [[4294967295, 4294967295]] is too short
Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.example.dt.yaml:
dsp@64800000: mboxes: [[4294967295, 4294967295]] is too short
regards
Suman
>
> regards
> Suman
>
>>
>> Signed-off-by: Rob Herring <robh@kernel.org>
>> ---
>> .../devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml | 2 +-
>> .../devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
>> index 5ec6505ac408..648144fa1582 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
>> @@ -53,7 +53,7 @@ properties:
>> OMAP Mailbox specifier denoting the sub-mailbox, to be used for
>> communication with the remote processor. This property should match
>> with the sub-mailbox node used in the firmware image.
>> - maxItems: 1
>> + maxItems: 2
>>
>> memory-region:
>> minItems: 2
>> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
>> index eeef255c4045..2c5f91ea5296 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml
>> @@ -135,7 +135,7 @@ patternProperties:
>> OMAP Mailbox specifier denoting the sub-mailbox, to be used for
>> communication with the remote processor. This property should match
>> with the sub-mailbox node used in the firmware image.
>> - maxItems: 1
>> + maxItems: 2
>>
>> memory-region:
>> description: |
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: remoteproc: ti: Fix the number of mailboxes
2022-01-07 14:17 ` Suman Anna
@ 2022-01-07 17:21 ` Rob Herring
0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-01-07 17:21 UTC (permalink / raw)
To: Suman Anna
Cc: Ohad Ben-Cohen, Bjorn Andersson, Mathieu Poirier,
open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM, devicetree,
linux-kernel@vger.kernel.org, Nagalla, Hari
On Fri, Jan 7, 2022 at 8:17 AM Suman Anna <s-anna@ti.com> wrote:
>
> On 1/7/22 8:13 AM, Suman Anna wrote:
> > Hi Rob,
> >
> > On 1/6/22 9:04 PM, Rob Herring wrote:
> >> Based on the example, the TI K3 DSP and R5 have 2 mailboxes, but the schema
> >> says 1. Fix the schema.
> >
> > No, 1 is correct. The OMAP Mailbox binding uses #mbox-cells as 1 and not 0, and
> > uses a phandle as the cell-value.
That's unfortunate. Really, ti,mbox-tx/rx should have been the mbox
cells with 2 entries (rx and tx)...
>
> The following is what you get with your current patch,
>
> Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.example.dt.yaml:
> dsp@4d80800000: mboxes: [[4294967295, 4294967295]] is too short
> Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.example.dt.yaml:
> dsp@64800000: mboxes: [[4294967295, 4294967295]] is too short
Ugg, yes. What I'm working on is getting validation on dtb files to
work. That means the dts <> are lost and we have to either parse the
properties properly (look up #foo-cells) or use __fixups__ to find
unresolved phandles (the case for most examples). The latter works
most of the time except a few cases like above. So the fix here is to
add a mbox provider node to the example.
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-07 17:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-07 3:04 [PATCH] dt-bindings: remoteproc: ti: Fix the number of mailboxes Rob Herring
2022-01-07 14:13 ` Suman Anna
2022-01-07 14:17 ` Suman Anna
2022-01-07 17:21 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).