* [PATCH v2] ARM: dts: at91: sama5d2: Fix PMERRLOC resource size
@ 2022-01-11 13:23 Tudor Ambarus
2022-01-11 13:34 ` Alexander Dahl
2022-02-24 15:10 ` Nicolas Ferre
0 siblings, 2 replies; 3+ messages in thread
From: Tudor Ambarus @ 2022-01-11 13:23 UTC (permalink / raw)
To: Nicolas.Ferre, ada
Cc: alexandre.belloni, ludovic.desroches, robh+dt, bbrezillon,
linux-arm-kernel, devicetree, linux-kernel, Tudor Ambarus, stable
PMERRLOC resource size was set to 0x100, which resulted in HSMC_ERRLOCx
register being truncated to offset x = 21, causing error correction to
fail if more than 22 bit errors and if 24 or 32 bit error correction
was supported.
Fixes: d9c41bf30cf8 ("ARM: dts: at91: Declare EBI/NAND controllers")
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Cc: <stable@vger.kernel.org> # 4.13.x
---
v2:
- update commit description
- Cc stable@vger.kernel.org
arch/arm/boot/dts/sama5d2.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
index 09c741e8ecb8..c700c3b19e4c 100644
--- a/arch/arm/boot/dts/sama5d2.dtsi
+++ b/arch/arm/boot/dts/sama5d2.dtsi
@@ -415,7 +415,7 @@ hsmc: hsmc@f8014000 {
pmecc: ecc-engine@f8014070 {
compatible = "atmel,sama5d2-pmecc";
reg = <0xf8014070 0x490>,
- <0xf8014500 0x100>;
+ <0xf8014500 0x200>;
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] ARM: dts: at91: sama5d2: Fix PMERRLOC resource size
2022-01-11 13:23 [PATCH v2] ARM: dts: at91: sama5d2: Fix PMERRLOC resource size Tudor Ambarus
@ 2022-01-11 13:34 ` Alexander Dahl
2022-02-24 15:10 ` Nicolas Ferre
1 sibling, 0 replies; 3+ messages in thread
From: Alexander Dahl @ 2022-01-11 13:34 UTC (permalink / raw)
To: Tudor Ambarus
Cc: Nicolas.Ferre, alexandre.belloni, ludovic.desroches, robh+dt,
bbrezillon, linux-arm-kernel, devicetree, linux-kernel, stable,
Alexander Dahl
Hei hei,
Am Dienstag, 11. Januar 2022, 14:23:01 CET schrieb Tudor Ambarus:
> PMERRLOC resource size was set to 0x100, which resulted in HSMC_ERRLOCx
> register being truncated to offset x = 21, causing error correction to
> fail if more than 22 bit errors and if 24 or 32 bit error correction
> was supported.
>
> Fixes: d9c41bf30cf8 ("ARM: dts: at91: Declare EBI/NAND controllers")
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> Cc: <stable@vger.kernel.org> # 4.13.x
Acked-by: Alexander Dahl <ada@thorsis.com>
Greets
Alex
> ---
> v2:
> - update commit description
> - Cc stable@vger.kernel.org
>
> arch/arm/boot/dts/sama5d2.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 09c741e8ecb8..c700c3b19e4c 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -415,7 +415,7 @@ hsmc: hsmc@f8014000 {
> pmecc: ecc-engine@f8014070 {
> compatible = "atmel,sama5d2-pmecc";
> reg = <0xf8014070 0x490>,
> - <0xf8014500 0x100>;
> + <0xf8014500 0x200>;
> };
> };
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] ARM: dts: at91: sama5d2: Fix PMERRLOC resource size
2022-01-11 13:23 [PATCH v2] ARM: dts: at91: sama5d2: Fix PMERRLOC resource size Tudor Ambarus
2022-01-11 13:34 ` Alexander Dahl
@ 2022-02-24 15:10 ` Nicolas Ferre
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Ferre @ 2022-02-24 15:10 UTC (permalink / raw)
To: Tudor Ambarus, ada
Cc: alexandre.belloni, ludovic.desroches, robh+dt, bbrezillon,
linux-arm-kernel, devicetree, linux-kernel, stable
On 11/01/2022 at 14:23, Tudor Ambarus wrote:
> PMERRLOC resource size was set to 0x100, which resulted in HSMC_ERRLOCx
> register being truncated to offset x = 21, causing error correction to
> fail if more than 22 bit errors and if 24 or 32 bit error correction
> was supported.
>
> Fixes: d9c41bf30cf8 ("ARM: dts: at91: Declare EBI/NAND controllers")
> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> Cc: <stable@vger.kernel.org> # 4.13.x
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Even if it's a fix, as we have this bug for a long time and that we are
already at rc5 of the stabilization phase, I take it in at91-dt branch
for 5.18 and not in another "fixes" batch.
Best regards,
Nicolas
> ---
> v2:
> - update commit description
> - Cc stable@vger.kernel.org
>
> arch/arm/boot/dts/sama5d2.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 09c741e8ecb8..c700c3b19e4c 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -415,7 +415,7 @@ hsmc: hsmc@f8014000 {
> pmecc: ecc-engine@f8014070 {
> compatible = "atmel,sama5d2-pmecc";
> reg = <0xf8014070 0x490>,
> - <0xf8014500 0x100>;
> + <0xf8014500 0x200>;
> };
> };
>
--
Nicolas Ferre
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-24 15:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-11 13:23 [PATCH v2] ARM: dts: at91: sama5d2: Fix PMERRLOC resource size Tudor Ambarus
2022-01-11 13:34 ` Alexander Dahl
2022-02-24 15:10 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).