From: Daniel Beer <daniel.beer@igorinstitute.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Andy Liu <andy-liu@ti.com>,
Derek Simkowiak <derek.simkowiak@igorinstitute.com>,
Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 1/2] ASoC: add support for TAS5805M digital amplifier
Date: Wed, 12 Jan 2022 08:28:06 +1300 [thread overview]
Message-ID: <20220111192806.GA10345@nyquist.nev> (raw)
In-Reply-To: <Yd26p8rF3arufd2R@sirena.org.uk>
On Tue, Jan 11, 2022 at 05:13:11PM +0000, Mark Brown wrote:
> > +static void tas5805m_refresh_unlocked(struct snd_soc_component *component)
> > +{
> > + struct tas5805m_priv *tas5805m =
> > + snd_soc_component_get_drvdata(component);
> > + uint8_t v[4];
> > + unsigned int i;
> > + uint32_t x;
>
> > + snd_soc_component_write(component, REG_PAGE, 0x00);
> > + snd_soc_component_write(component, REG_BOOK, 0x8c);
> > + snd_soc_component_write(component, REG_PAGE, 0x2a);
>
> This isn't using the regmap paging support and I'm not seeing anything
> that resets the page here.
Hi Mark,
The blob of register writes we get given from PPC3 contains a whole lot
of explicit page and book changes, and there's not an easy way to tell
regmap about this, as far as I know. Do you think it's acceptable to
stick with explicit paging for this reason, or is there a way to make
this work with regmap's paging?
I'll go ahead and address your other comments before resubmitting.
Cheers,
Daniel
--
Daniel Beer
Firmware Engineer at Igor Institute
daniel.beer@igorinstitute.com or +64-27-420-8101
Offices in Seattle, San Francisco, and Vancouver BC or (206) 494-3312
next prev parent reply other threads:[~2022-01-11 19:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 23:53 [PATCH 1/2] ASoC: add support for TAS5805M digital amplifier Daniel Beer
2022-01-11 17:13 ` Mark Brown
2022-01-11 19:28 ` Daniel Beer [this message]
2022-01-12 20:26 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220111192806.GA10345@nyquist.nev \
--to=daniel.beer@igorinstitute.com \
--cc=alsa-devel@alsa-project.org \
--cc=andy-liu@ti.com \
--cc=broonie@kernel.org \
--cc=derek.simkowiak@igorinstitute.com \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).