From: Yong Wu <yong.wu@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Joerg Roedel <joro@8bytes.org>, Tomasz Figa <tfiga@chromium.org>,
<linux-mediatek@lists.infradead.org>,
<srv_heupstream@mediatek.com>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<iommu@lists.linux-foundation.org>, <yong.wu@mediatek.com>,
<youlin.pei@mediatek.com>, <anan.sun@mediatek.com>,
<lc.kan@mediatek.com>, <yi.kuo@mediatek.com>,
<anthony.huang@mediatek.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: [PATCH v3 5/7] memory: mtk-smi: Fix the return value for clk_bulk_prepare_enable
Date: Thu, 13 Jan 2022 19:10:55 +0800 [thread overview]
Message-ID: <20220113111057.29918-6-yong.wu@mediatek.com> (raw)
In-Reply-To: <20220113111057.29918-1-yong.wu@mediatek.com>
Function clk_bulk_prepare_enable() returns 0 for success or a negative
number for error. Fix this code style issue.
Signed-off-by: Yong Wu <yong.wu@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
drivers/memory/mtk-smi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
index b883dcc0bbfa..e7b1a22b12ea 100644
--- a/drivers/memory/mtk-smi.c
+++ b/drivers/memory/mtk-smi.c
@@ -480,7 +480,7 @@ static int __maybe_unused mtk_smi_larb_resume(struct device *dev)
int ret;
ret = clk_bulk_prepare_enable(larb->smi.clk_num, larb->smi.clks);
- if (ret < 0)
+ if (ret)
return ret;
/* Configure the basic setting for this larb */
--
2.18.0
next prev parent reply other threads:[~2022-01-13 11:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 11:10 [PATCH v3 0/7] MT8186 SMI SUPPORT Yong Wu
2022-01-13 11:10 ` [PATCH v3 1/7] dt-bindings: memory: mtk-smi: Rename clock to clocks Yong Wu
2022-01-13 15:41 ` AngeloGioacchino Del Regno
2022-01-13 11:10 ` [PATCH v3 2/7] dt-bindings: memory: mtk-smi: No need mediatek,larb-id for mt8167 Yong Wu
2022-01-13 15:44 ` AngeloGioacchino Del Regno
2022-01-13 11:10 ` [PATCH v3 3/7] dt-bindings: memory: mtk-smi: Correct minItems to 2 for the gals clocks Yong Wu
2022-01-13 15:44 ` AngeloGioacchino Del Regno
2022-01-13 11:10 ` [PATCH v3 4/7] dt-bindings: memory: mediatek: Add mt8186 support Yong Wu
2022-01-13 15:44 ` AngeloGioacchino Del Regno
2022-01-13 11:10 ` Yong Wu [this message]
2022-01-17 12:01 ` [PATCH v3 5/7] memory: mtk-smi: Fix the return value for clk_bulk_prepare_enable Krzysztof Kozlowski
2022-01-17 12:25 ` Yong Wu
2022-01-13 11:10 ` [PATCH v3 6/7] memory: mtk-smi: Add sleep ctrl function Yong Wu
2022-01-13 11:10 ` [PATCH v3 7/7] memory: mtk-smi: mt8186: Add smi support Yong Wu
2022-01-25 16:55 ` [PATCH v3 0/7] MT8186 SMI SUPPORT Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220113111057.29918-6-yong.wu@mediatek.com \
--to=yong.wu@mediatek.com \
--cc=anan.sun@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=anthony.huang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=lc.kan@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
--cc=yi.kuo@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).