From: Jonathan Cameron <jic23@kernel.org>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: <robh+dt@kernel.org>, <linux-iio@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] Documentation:ABI:testing:admv1014: add ABI docs
Date: Sun, 16 Jan 2022 13:00:43 +0000 [thread overview]
Message-ID: <20220116130043.2639b0c2@jic23-huawei> (raw)
In-Reply-To: <20220110151350.164095-2-antoniu.miclaus@analog.com>
On Mon, 10 Jan 2022 17:13:50 +0200
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:
> Add documentation for the use of the Digital Attenuator gain.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
Hi Antoniu,
Looks good to me though I'm keen to get other people's opinions as
it is a little unusual. So even if rest of the set is fine I'll
leave this on list for a little longer. (I'm reviewing backwards through
your series as makes more sense to me that way ;)
Thanks,
Jonathan
> ---
> .../testing/sysfs-bus-iio-frequency-admv1014 | 23 +++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014 b/Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014
> new file mode 100644
> index 000000000000..5bcd96d77f45
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014
> @@ -0,0 +1,23 @@
> +What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_i_calibscale_coarse
> +KernelVersion:
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Read/write value for the digital attenuator gain (IF_I) with coarse steps.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_q_calibscale_coarse
> +KernelVersion:
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Read/write value for the digital attenuator gain (IF_Q) with coarse steps.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_i_calibscale_fine
> +KernelVersion:
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Read/write value for the digital attenuator gain (IF_I) with fine steps.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_q_calibscale_fine
> +KernelVersion:
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Read/write value for the digital attenuator gain (IF_Q) with fine steps.
next prev parent reply other threads:[~2022-01-16 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 15:13 [PATCH v2 2/3] dt-bindings:iio:frequency: add admv1014 binding Antoniu Miclaus
2022-01-10 15:13 ` [PATCH v2 3/3] Documentation:ABI:testing:admv1014: add ABI docs Antoniu Miclaus
2022-01-16 13:00 ` Jonathan Cameron [this message]
2022-01-16 13:04 ` [PATCH v2 2/3] dt-bindings:iio:frequency: add admv1014 binding Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220116130043.2639b0c2@jic23-huawei \
--to=jic23@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox