Re: [PATCH v8 4/7] arm64: dts: renesas: condor: Enable MAX9286

[Jacopo Mondi <jacopo@jmondi.org>]

Hi Geert, Kieran,

On Thu, Jan 20, 2022 at 10:14:34AM +0100, Geert Uytterhoeven wrote:
> Hi Jacopo,
>
> On Thu, Dec 16, 2021 at 5:34 PM Jacopo Mondi <jacopo+renesas@jmondi.org> wrote:
> > Enable the MAX9286 GMSL deserializers on Condor-V3H board.
> >
> > Connected cameras should be defined in a device-tree overlay or included
> > after these definitions.
> >
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r8a77980-condor.dts
> > +++ b/arch/arm64/boot/dts/renesas/r8a77980-condor.dts
> > @@ -6,6 +6,8 @@
> >   * Copyright (C) 2018 Cogent Embedded, Inc.
> >   */
> >
> > +#include <dt-bindings/gpio/gpio.h>
>
> Already included below.
>
> > +
> >  /dts-v1/;
> >  #include "r8a77980.dtsi"
> >  #include <dt-bindings/gpio/gpio.h>
>
> I can fix that while applying, but I'm interested in hearing the answer
> to Kieran's question first.

I can confirm that without including "gmsl-cameras.dtsi" no media
graph is registered. This is expected as the VINs and GSML device
nodes are enabled in the .dtsi only

        #ifdef GMSL_0
        &vin0 {
                status = "okay";
        };

        &vin1 {
                status = "okay";
        };

        &vin2 {
                status = "okay";
        };

        &vin3 {
                status = "okay";
        };

        &gmsl0 {
                status = "okay";
               ...

I think that's the expected behavior, isn't it ?

Thanks
   j




>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds