From: Florian Eckert <fe@dev.tdt.de>
To: pavel@ucw.cz, robh+dt@kernel.org, andy.shevchenko@gmail.com
Cc: Eckert.Florian@googlemail.com, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org
Subject: [PATCH v4 0/2] leds: add ktd20xx LED driver support
Date: Fri, 21 Jan 2022 15:01:48 +0100 [thread overview]
Message-ID: <20220121140150.1729-1-fe@dev.tdt.de> (raw)
v1: Initial send
v2: Remove variant 1 from source
v3: Changes requested by Andy Shevchenko added. Thanks for reviewing
- Removing OF dependency
- Add missing includes
- Use device_property_read_u32() instead of fwnode_property_read_u32()
- Use one liner function pattern <test> ? <value-true> : <value-false>
- Remove switch case call for intensity color selection use BIT()
instead
- Remove not needed fwnode_handle_put() in ktd200xx_probe_dt()
function
- Use dev_get_drvdata() instead of i2c_get_clientdata() function call
- Use sysfs_emit() function call
- Use kstrtobool() function call
- Remove not needed comma after last array element
- Use dev_err_probe() instead of dev_error() in driver probe function
- Do not use dev_group registration function set .dev_groups directly
into ktd20xx_driver struct.
v4: Changes requested by Andy Shevchenko. Thanks again for your review
- Fix Author indentation
- Reduce logging noise
- Use 'if' standard pattern
- Use set_bit function to make code cleaner
- Use meaningful jump labels
- Updating the logging output to better match the source code
- Remove duplicate dev pointer usage. This is not necessary as the
information can be used directly from the client structure
- Do not hide return value from kstrbool function
- Do not use mutex_destroy function in devm mananged structs
Florian Eckert (2):
leds: ktd20xx: Extension of the KTD20xx family of LED drivers from
Kinetic
dt: bindings: KTD20xx: Introduce the ktd20xx family of RGB drivers
.../bindings/leds/leds-ktd20xx.yaml | 130 ++++
MAINTAINERS | 7 +
drivers/leds/Kconfig | 12 +
drivers/leds/Makefile | 1 +
drivers/leds/leds-ktd20xx.c | 582 ++++++++++++++++++
5 files changed, 732 insertions(+)
create mode 100644 Documentation/devicetree/bindings/leds/leds-ktd20xx.yaml
create mode 100644 drivers/leds/leds-ktd20xx.c
--
2.20.1
next reply other threads:[~2022-01-21 14:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 14:01 Florian Eckert [this message]
2022-01-21 14:01 ` [PATCH v4 1/2] leds: ktd20xx: Extension of the KTD20xx family of LED drivers from Kinetic Florian Eckert
2022-01-21 15:46 ` Andy Shevchenko
2022-02-12 12:08 ` Pavel Machek
2022-03-18 7:26 ` Florian Eckert
2022-01-21 14:01 ` [PATCH v4 2/2] dt: bindings: KTD20xx: Introduce the ktd20xx family of RGB drivers Florian Eckert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220121140150.1729-1-fe@dev.tdt.de \
--to=fe@dev.tdt.de \
--cc=Eckert.Florian@googlemail.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).