From: Jonathan Cameron <jic23@kernel.org>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: <robh+dt@kernel.org>, <linux-iio@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/4] Documentation:ABI:testing:admv1014: add ABI docs
Date: Sat, 22 Jan 2022 17:38:31 +0000 [thread overview]
Message-ID: <20220122173831.2d2c2b0d@jic23-huawei> (raw)
In-Reply-To: <20220119081838.70210-3-antoniu.miclaus@analog.com>
On Wed, 19 Jan 2022 10:18:37 +0200
Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:
> Add documentation for the use of the Digital Attenuator gain.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
One entry that should be in the generic docs rather than here.
Given the documentation generation scripts don't support multiple
entries for a given attribute name an that one is 'standard'
we should just add it to the main file as otherwise the chances
are very high of accidentally getting duplication when it
turns up in another driver ABI doc.
We may need to move some of the others later if they turn out
to occur in multiple drivers but they are obscure enough to
be fine in this file for now.
Thanks,
Jonathan
> ---
> changes in v3:
> - add description for calibscale in I/Q mode
> .../testing/sysfs-bus-iio-frequency-admv1014 | 29 +++++++++++++++++++
> 1 file changed, 29 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014 b/Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014
> new file mode 100644
> index 000000000000..77c1691e6910
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1014
> @@ -0,0 +1,29 @@
> +What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_i_calibscale_coarse
> +KernelVersion:
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Read/write value for the digital attenuator gain (IF_I) with coarse steps.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_q_calibscale_coarse
> +KernelVersion:
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Read/write value for the digital attenuator gain (IF_Q) with coarse steps.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_i_calibscale_fine
> +KernelVersion:
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Read/write value for the digital attenuator gain (IF_I) with fine steps.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0_q_calibscale_fine
> +KernelVersion:
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Read/write value for the digital attenuator gain (IF_Q) with fine steps.
> +
> +What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage_calibscale
This particular one is normal ABI, so should just be added to the list
in sysfs-bus-iio alongside all the other calibscale entries.
> +KernelVersion:
> +Contact: linux-iio@vger.kernel.org
> +Description:
> + Read/write value for the digital attenuator gain (I/Q).
next prev parent reply other threads:[~2022-01-22 17:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 8:18 [PATCH v3 1/4] iio:frequency:admv1014: add support for ADMV1014 Antoniu Miclaus
2022-01-19 8:18 ` [PATCH v3 2/4] dt-bindings:iio:frequency: add admv1014 binding Antoniu Miclaus
2022-01-22 17:32 ` Jonathan Cameron
2022-01-22 17:43 ` Jonathan Cameron
2022-01-19 8:18 ` [PATCH v3 3/4] Documentation:ABI:testing:admv1014: add ABI docs Antoniu Miclaus
2022-01-22 17:38 ` Jonathan Cameron [this message]
2022-01-19 8:18 ` [PATCH v3 4/4] MAINTAINERS: add maintainer for ADMV1014 driver Antoniu Miclaus
2022-01-22 18:01 ` [PATCH v3 1/4] iio:frequency:admv1014: add support for ADMV1014 Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220122173831.2d2c2b0d@jic23-huawei \
--to=jic23@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).