From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C018CC433EF for ; Mon, 24 Jan 2022 11:03:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237178AbiAXLDj (ORCPT ); Mon, 24 Jan 2022 06:03:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237185AbiAXLDj (ORCPT ); Mon, 24 Jan 2022 06:03:39 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 442B9C06173D for ; Mon, 24 Jan 2022 03:03:39 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nBx8G-0000Si-PS; Mon, 24 Jan 2022 12:03:32 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nBx8F-0000Dm-Ea; Mon, 24 Jan 2022 12:03:31 +0100 Date: Mon, 24 Jan 2022 12:03:31 +0100 From: Sascha Hauer To: Frank Wunderlich Cc: Frank Wunderlich , linux-rockchip@lists.infradead.org, Rob Herring , Heiko Stuebner , Peter Geis , Johan Jonker , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: Re: [PATCH v2 2/2] arm64: dts: rockchip: Add Bananapi R2 Pro Message-ID: <20220124110331.GZ23490@pengutronix.de> References: <20220123135116.136846-1-linux@fw-web.de> <20220123135116.136846-3-linux@fw-web.de> <20220124083102.GW23490@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 12:01:28 up 44 days, 19:47, 85 users, load average: 0.47, 0.32, 0.21 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Jan 24, 2022 at 09:55:05AM +0100, Frank Wunderlich wrote: > Hi > > > Gesendet: Montag, 24. Januar 2022 um 09:31 Uhr > > Von: "Sascha Hauer" > > An: "Frank Wunderlich" > > Cc: linux-rockchip@lists.infradead.org, "Frank Wunderlich" , "Rob Herring" , "Heiko Stuebner" , "Peter Geis" , "Johan Jonker" , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org > > Betreff: Re: [PATCH v2 2/2] arm64: dts: rockchip: Add Bananapi R2 Pro > > > > On Sun, Jan 23, 2022 at 02:51:16PM +0100, Frank Wunderlich wrote: > > > From: Frank Wunderlich > > > > > > This patch adds Devicetree for Bananapi R2 Pro based on RK3568. > > > Add uart/sd/emmc/i2c/rk809/tsadc nodes for basic function. > > > Gmac0 is directly connected to wan-port so usable without additional > > > driver. > > > On gmac1 there is a switch (rtl8367rb) connected which have not yet a > > > driver in mainline. > > > > > > Patch also prepares nodes for GPIO header. > > > > > > Co-developed-by: Peter Geis > > > Signed-off-by: Peter Geis > > > Signed-off-by: Frank Wunderlich > > > --- > > > +&gmac0 { > > > + assigned-clocks = <&cru SCLK_GMAC0_RX_TX>, <&cru SCLK_GMAC0>; > > > + assigned-clock-parents = <&cru SCLK_GMAC0_RGMII_SPEED>, <&cru CLK_MAC0_2TOP>; > > > + clock_in_out = "input"; > > > + phy-handle = <&rgmii_phy0>; > > > + phy-mode = "rgmii"; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&gmac0_miim > > > + &gmac0_tx_bus2 > > > + &gmac0_rx_bus2 > > > + &gmac0_rgmii_clk > > > + &gmac0_rgmii_bus>; > > > + > > > + snps,reset-gpio = <&gpio3 RK_PB7 GPIO_ACTIVE_LOW>; > > > + snps,reset-active-low; > > > + /* Reset time is 20ms, 100ms for rtl8211f */ > > > > Is this really a rtl8211f? I don't know and it could indeed be a > > rtl8211f, I'm just asking because the comment is copy pasted from > > the Quartz64 board. > > i know thats a RTL8211 phy, but i see no additional letter on the > chip, based on shematics it's a RTL8211F-CG Ok. I just wanted to make sure you checked that. > > > > + snps,reset-delays-us = <0 20000 100000>; > > > + > > > +&mdio0 { > > > + rgmii_phy0: ethernet-phy@0 { > > > + compatible = "ethernet-phy-ieee802.3-c22"; > > > + reg = <0x0>; > > > + }; > > > > 0 is the broadcast address. I'm not sure if it's a good idea to use it. > > There should be another address the phy listens on. > > took this from the 3568-EVB (like the most parts, as the board is > mostly the same), and in linux it's the same and working. The switch > have also phy-id 0 on mdio bus #1, are you sure this is invalid? It's not invalid, it's just the broadcast address to which other phys might answer as well. Anyway, as long as there's only a single phy on the bus it's probably okay. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |