devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Rob Herring <robh@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	linux-can@vger.kernel.org,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	devicetree@vger.kernel.org, lrich Hecht <uli+renesas@fpond.eu>
Subject: Re: [PATCH net-next 4/4] dt-binding: can: rcar-can: include common CAN controller bindings
Date: Tue, 25 Jan 2022 08:55:06 +0100	[thread overview]
Message-ID: <20220125075506.5z3myalobo3quvv2@pengutronix.de> (raw)
In-Reply-To: <1643084091.565337.1221464.nullmailer@robh.at.kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1309 bytes --]

On 24.01.2022 22:14:51, Rob Herring wrote:
> On Mon, 24 Jan 2022 23:06:53 +0100, Marc Kleine-Budde wrote:
> > Since commit
> > 
> > | 1f9234401ce0 ("dt-bindings: can: add can-controller.yaml")
> > 
> > there is a common CAN controller binding. Add this to the rcar-can
> > binding.
> > 
> > Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > Cc: lrich Hecht <uli+renesas@fpond.eu>
> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> > ---
> >  .../devicetree/bindings/net/can/renesas,rcar-can.yaml          | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> 
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):

Good bot!

> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/net/can/renesas,rcar-can.yaml:102:1: [error] duplication of key "allOf" in mapping (key-duplicates)

Right, the renesas,rcar-can.yaml already contains a "allOf: $ref:
can-controller.yaml", I'll drop that patch.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2022-01-25  9:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-24 22:06 [PATCH net-next 0/4] dt-binding: can: add common CAN controller bindings to existing CAN driver bindings Marc Kleine-Budde
2022-01-24 22:06 ` [PATCH net-next 1/4] dt-binding: can: mcp251xfd: include common CAN controller bindings Marc Kleine-Budde
2022-02-09  3:12   ` Rob Herring
2022-01-24 22:06 ` [PATCH net-next 2/4] dt-binding: can: sun4i_can: " Marc Kleine-Budde
2022-02-09  3:13   ` Rob Herring
2022-01-24 22:06 ` [PATCH net-next 3/4] dt-binding: can: m_can: " Marc Kleine-Budde
2022-02-09  3:13   ` Rob Herring
2022-01-24 22:06 ` [PATCH net-next 4/4] dt-binding: can: rcar-can: " Marc Kleine-Budde
2022-01-25  4:14   ` Rob Herring
2022-01-25  7:55     ` Marc Kleine-Budde [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220125075506.5z3myalobo3quvv2@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=uli+renesas@fpond.eu \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).