From: Shawn Guo <shawnguo@kernel.org>
To: Andrej Picej <andrej.picej@norik.com>
Cc: robh+dt@kernel.org, s.hauer@pengutronix.de,
devicetree@vger.kernel.org, festevam@gmail.com,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
y.bas@phytec.com
Subject: Re: [PATCH RESEND 1/2] ARM: dts: imx6: phyFLEX: add missing pmic mfd subdevices
Date: Wed, 26 Jan 2022 17:24:26 +0800 [thread overview]
Message-ID: <20220126092426.GJ4686@dragon> (raw)
In-Reply-To: <20211216115529.2331475-1-andrej.picej@norik.com>
On Thu, Dec 16, 2021 at 12:55:28PM +0100, Andrej Picej wrote:
> phyFLEX PMIC DA9063 has also RTC and watchdog support. Add both
> mfd subdevices so they can be used.
>
> Signed-off-by: Andrej Picej <andrej.picej@norik.com>
> ---
> arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> index f3236204cb5a..2ec154756bbc 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> @@ -205,6 +205,14 @@ vdd_mx6_high_reg: ldo11 {
> regulator-always-on;
> };
> };
> +
> + pmic_rtc: rtc {
Maybe a more specific label like the following?
da9063_rtc: rtc
And it's more aligned with da9063_wdog below.
> + compatible = "dlg,da9063-rtc";
> + };
> +
> + da9063_wdog: wdt {
watchdog for the node name.
Shawn
> + compatible = "dlg,da9063-watchdog";
> + };
> };
> };
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-01-26 9:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 11:55 [PATCH RESEND 1/2] ARM: dts: imx6: phyFLEX: add missing pmic mfd subdevices Andrej Picej
2021-12-16 11:55 ` [PATCH RESEND 2/2] ARM: dts: imx6qdl: Handle unneeded MFD-subdevices correctly Andrej Picej
2022-01-26 9:27 ` Shawn Guo
2022-01-27 6:29 ` Andrej Picej
2022-01-26 9:24 ` Shawn Guo [this message]
2022-01-27 6:28 ` [PATCH RESEND 1/2] ARM: dts: imx6: phyFLEX: add missing pmic mfd subdevices Andrej Picej
2022-01-28 3:55 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220126092426.GJ4686@dragon \
--to=shawnguo@kernel.org \
--cc=andrej.picej@norik.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=y.bas@phytec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).