From: Andre Przywara <andre.przywara@foss.arm.com>
To: Jesse Taube <mr.bossman075@gmail.com>
Cc: devicetree@vger.kernel.org, robh+dt@kernel.org,
linux-sunxi@lists.linux.dev, mripard@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/4] ARM: dts: suniv: Enable mmc for f1c100s.
Date: Mon, 31 Jan 2022 10:17:49 +0000 [thread overview]
Message-ID: <20220131101749.5a6d743c@donnerap.cambridge.arm.com> (raw)
In-Reply-To: <20220130220325.1983918-4-Mr.Bossman075@gmail.com>
On Sun, 30 Jan 2022 17:03:25 -0500
Jesse Taube <mr.bossman075@gmail.com> wrote:
> Enable mmc0 in f1c100s-licheepi-nano device tree.
>
> Signed-off-by: Jesse Taube <Mr.Bossman075@gmail.com>
> ---
> V1 -> V2:
> * New patch
> ---
> arch/arm/boot/dts/suniv-f1c100s-licheepi-nano.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/suniv-f1c100s-licheepi-nano.dts b/arch/arm/boot/dts/suniv-f1c100s-licheepi-nano.dts
> index a1154e6c7cb5..c856a6a20dc8 100644
> --- a/arch/arm/boot/dts/suniv-f1c100s-licheepi-nano.dts
> +++ b/arch/arm/boot/dts/suniv-f1c100s-licheepi-nano.dts
> @@ -24,3 +24,9 @@ &uart0 {
> pinctrl-0 = <&uart0_pe_pins>;
> status = "okay";
> };
> +
> +&mmc0 {
> + bus-width = <4>;
> + broken-cd;
> + status = "okay";
Do we need a vmmc-supply?
Otherwise looks alright.
Cheers,
Andre
> +};
next prev parent reply other threads:[~2022-01-31 10:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-30 22:03 [PATCH v2 1/4] ARM: dtsi: suniv: F1c100s add clock and reset macros Jesse Taube
2022-01-30 22:03 ` [PATCH v2 2/4] dt-bindings: mmc: sunxi: Add Allwinner F1c100s compatibles Jesse Taube
2022-01-31 9:45 ` Maxime Ripard
2022-01-31 10:19 ` Andre Przywara
2022-02-09 21:15 ` Rob Herring
2022-01-30 22:03 ` [PATCH v2 3/4] ARM: dtsi: suniv: Add mmc to f1c100s dtsi Jesse Taube
2022-01-31 9:46 ` Maxime Ripard
2022-01-31 10:14 ` Andre Przywara
2022-01-30 22:03 ` [PATCH v2 4/4] ARM: dts: suniv: Enable mmc for f1c100s Jesse Taube
2022-01-31 9:46 ` Maxime Ripard
2022-01-31 10:17 ` Andre Przywara [this message]
2022-01-31 9:50 ` [PATCH v2 1/4] ARM: dtsi: suniv: F1c100s add clock and reset macros Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220131101749.5a6d743c@donnerap.cambridge.arm.com \
--to=andre.przywara@foss.arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mr.bossman075@gmail.com \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).