From: Thomas Bracht Laumann Jespersen <t@laumann.xyz>
To: robh+dt@kernel.org, frowand.list@gmail.com
Cc: masahiroy@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Thomas Bracht Laumann Jespersen <t@laumann.xyz>
Subject: [PATCH] scripts/dtc: Call pkg-config POSIXly correct
Date: Mon, 31 Jan 2022 12:20:28 +0100 [thread overview]
Message-ID: <20220131112028.7907-1-t@laumann.xyz> (raw)
Running with POSIXLY_CORRECT=1 in the environment the scripts/dtc build
fails, because pkg-config doesn't output anything when the flags come
after the arguments.
Fixes: f8d8b46cd20e ("scripts/dtc: use pkg-config to include <yaml.h> in non-standard path")
Signed-off-by: Thomas Bracht Laumann Jespersen <t@laumann.xyz>
---
I'm aware that the full kernel doesn't build with POSIXLY_CORRECT set, but I
asked around and was told just to submit a patch.
This is based on the v5.17-rc2 tag, not sure if that's the right tree to work
from, I'll happily cherry-pick to another tree if desired.
scripts/dtc/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/dtc/Makefile b/scripts/dtc/Makefile
index 95aaf7431bff..1cba78e1dce6 100644
--- a/scripts/dtc/Makefile
+++ b/scripts/dtc/Makefile
@@ -29,7 +29,7 @@ dtc-objs += yamltree.o
# To include <yaml.h> installed in a non-default path
HOSTCFLAGS_yamltree.o := $(shell pkg-config --cflags yaml-0.1)
# To link libyaml installed in a non-default path
-HOSTLDLIBS_dtc := $(shell pkg-config yaml-0.1 --libs)
+HOSTLDLIBS_dtc := $(shell pkg-config --libs yaml-0.1)
endif
# Generated files need one more search path to include headers in source tree
--
2.34.1
next reply other threads:[~2022-01-31 11:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-31 11:20 Thomas Bracht Laumann Jespersen [this message]
2022-01-31 14:43 ` [PATCH] scripts/dtc: Call pkg-config POSIXly correct Rob Herring
2022-01-31 15:13 ` Thomas Bracht Laumann Jespersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220131112028.7907-1-t@laumann.xyz \
--to=t@laumann.xyz \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).