devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Martin Jücker" <martin.juecker@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Martin Jücker" <martin.juecker@gmail.com>
Subject: Re: [PATCH] ARM: dts: add 533 MHz step to p4note GPU opp table
Date: Mon, 31 Jan 2022 13:15:59 +0100	[thread overview]
Message-ID: <20220131121559.GA4022@adroid> (raw)
In-Reply-To: <131c9bd9-b035-8a75-ca27-f9c2b3993566@canonical.com>

On Mon, Jan 31, 2022 at 09:54:00AM +0100, Krzysztof Kozlowski wrote:
> On 29/01/2022 23:14, Martin Jücker wrote:
> > The p4note devices support 533 MHz GPU speed, so let's make use of it.
> > 
> 
> If there is going to be resend, please add prefix "exynos:" in subject.
> Just like other commits (git log --oneline arch/arm/boot/dts/exynos*).
> 
> > Signed-off-by: Martin Jücker <martin.juecker@gmail.com>
> > ---
> >  arch/arm/boot/dts/exynos4412-p4note.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/exynos4412-p4note.dtsi b/arch/arm/boot/dts/exynos4412-p4note.dtsi
> > index 4ae6eb3091c4..d277b2337ae0 100644
> > --- a/arch/arm/boot/dts/exynos4412-p4note.dtsi
> > +++ b/arch/arm/boot/dts/exynos4412-p4note.dtsi
> > @@ -355,6 +355,13 @@ &gpu {
> >  	status = "okay";
> >  };
> >  
> > +&gpu_opp_table {
> > +	opp-533000000 {
> > +		opp-hz = /bits/ 64 <533000000>;
> > +		opp-microvolt = <1075000>;
> > +	};
> > +};
> 
> This looks like Exynos4412 Prime. Please check also CPU frequencies and
> if they match, just include exynos4412-prime.dtsi (like Odroid U3).
> 
> > +
> >  &hsotg {
> >  	vusb_a-supply = <&ldo12_reg>;
> >  	dr_mode = "peripheral";
> 
> 
> Best regards,
> Krzysztof

I just noticed, that I overlooked a condition in the code which
decreases the step count by one which eliminates the 533 MHz step.
Please ignore this patch.

Kind Regards
Martin

  parent reply	other threads:[~2022-01-31 12:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-29 22:14 [PATCH] ARM: dts: add 533 MHz step to p4note GPU opp table Martin Jücker
2022-01-31  8:54 ` Krzysztof Kozlowski
2022-01-31 11:36   ` Martin Jücker
2022-01-31 12:15   ` Martin Jücker [this message]
2022-01-31 12:24     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220131121559.GA4022@adroid \
    --to=martin.juecker@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).