From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F0A7C433EF for ; Wed, 2 Feb 2022 09:48:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245566AbiBBJst (ORCPT ); Wed, 2 Feb 2022 04:48:49 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:45779 "EHLO wout1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245565AbiBBJst (ORCPT ); Wed, 2 Feb 2022 04:48:49 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 65CF132022E7; Wed, 2 Feb 2022 04:48:48 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 02 Feb 2022 04:48:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; bh=mvttCoDxEmNSX3VfTvVqa/R3/CbmzT2hj3kMEv HCk0Y=; b=tHMBvloRnmuWkysYytaejOfMmrUlaS05Gy6WvAMaFKSCHQGbTyKT46 +mttsXFlVcfXP8s5l1dXFMFQ7dojoGxunaeYZUkwmAxGLW8kQ+qxTz1oHjnz0Blw /Y0jkaI/YtsE503hS6y1dC9el0qpAWRoFRDJIYW/GJSUc7+TAPcx5OhK7BwSJGd4 eX0JHgEXJYFx7VVP0Da5nZMZuafiQ1mGlkj2s/otgKlE00WsmkQjL6J17To53yFE 6k1QlEzpwzg7YfLGXrMmQNafbqW6kucxVszajMFqd2RkFU2AUt/NhvJDCuVpdG6f ByAt7eGrr+zlpT3yqzG4EvVYKrAnokow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=mvttCoDxEmNSX3VfT vVqa/R3/CbmzT2hj3kMEvHCk0Y=; b=olO5y7TULxYTntOJ/dc27lHM1ELkRlDk5 x21iZGqsQQBCHMnoF18lTKg258exO//Tk/pINWLFSyD9Mm6/BCYfpHZRcSp3xHnm EuS0LnTW1cVgztoeS1XGArJ2OSO4wWrXugUquU15aQcRjbdNMIlHeEXx4zZ3RkVi WmRM/+How3+nxCv3xhwgAjSRCwvULxU0nQuNHqk/V4KEMCAIjumrZLjnQk8c60pX EuA1HPx9e1BXYmzaCXjSxc9DP+EcbzxGJOtw1W8bACFdnTIVYnfWxabFrBMltHz9 GhCIAMx40bd9ZppiOg8fHUVcmQgfuWPgjVC73WEO2PJoNOY1+Z1rQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrgeehgddtkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeffteetveeijeetuefhffegkeetgffhieelheehtdduudethffhjedtvddtudel vdenucffohhmrghinhepuggvvhhitggvthhrvggvrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrgihimhgvsegtvghrnhhordht vggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 2 Feb 2022 04:48:47 -0500 (EST) Date: Wed, 2 Feb 2022 10:48:45 +0100 From: Maxime Ripard To: Laurent Pinchart Cc: Thierry Reding , Sam Ravnborg , Daniel Vetter , David Airlie , Rob Herring , Frank Rowand , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring Subject: Re: [PATCH v3 2/2] dt-bindings: panel: Introduce a panel-lvds binding Message-ID: <20220202094845.r7td65zxfo5uqg5x@houat> References: <20220111110635.804371-1-maxime@cerno.tech> <20220111110635.804371-2-maxime@cerno.tech> <20220127142215.fesipdslabur43sx@houat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="56zeyuukc3asnzuk" Content-Disposition: inline In-Reply-To: <20220127142215.fesipdslabur43sx@houat> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --56zeyuukc3asnzuk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 27, 2022 at 03:22:15PM +0100, Maxime Ripard wrote: > Hi Laurent, >=20 > On Tue, Jan 11, 2022 at 03:05:10PM +0200, Laurent Pinchart wrote: > > On Tue, Jan 11, 2022 at 12:06:35PM +0100, Maxime Ripard wrote: > > > Following the previous patch, let's introduce a generic panel-lvds > > > binding that documents the panels that don't have any particular > > > constraint documented. > > >=20 > > > Reviewed-by: Rob Herring > > > Signed-off-by: Maxime Ripard > > >=20 > > > --- > > >=20 > > > Changes from v2: > > > - Added a MAINTAINERS entry > > >=20 > > > Changes from v1: > > > - Added missing compatible > > > - Fixed lint > > > --- > > > .../bindings/display/panel/panel-lvds.yaml | 57 +++++++++++++++++= ++ > > > MAINTAINERS | 1 + > > > 2 files changed, 58 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/display/panel/p= anel-lvds.yaml > > >=20 > > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-lv= ds.yaml b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml > > > new file mode 100644 > > > index 000000000000..fcc50db6a812 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml > > > @@ -0,0 +1,57 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/display/panel/panel-lvds.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Generic LVDS Display Panel Device Tree Bindings > > > + > > > +maintainers: > > > + - Lad Prabhakar > > > + - Thierry Reding > > > + > > > +allOf: > > > + - $ref: panel-common.yaml# > > > + - $ref: /schemas/display/lvds.yaml/# > > > + > > > +select: > > > + properties: > > > + compatible: > > > + contains: > > > + const: panel-lvds > > > + > > > + not: > > > + properties: > > > + compatible: > > > + contains: > > > + enum: > > > + - advantech,idk-1110wr > > > + - advantech,idk-2121wr > > > + - innolux,ee101ia-01d > > > + - mitsubishi,aa104xd12 > > > + - mitsubishi,aa121td01 > > > + - sgd,gktw70sdae4se > >=20 > > I still don't like this :-( Couldn't we instead do > >=20 > > select: > > properties: > > compatible: > > contains: > > enum: > > - auo,b101ew05 > > - tbs,a711-panel > >=20 > > ? >=20 > That works too, I'll send another version. Actually, no, it doesn't work. If we do this, if we were to have a panel that has panel-lvds but none of the other compatible (because of a typo, or downright invalid binding) we won't validate it and report any error. I'll merge this version (together with the v4 version of patch 1) Maxime --56zeyuukc3asnzuk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYfpTfQAKCRDj7w1vZxhR xVS5AP43Ygo51GOlm2AVd9y0d5io7X75oqP7eO0QejtACduRxwEA/mTSShcWWSTX n262O8BX2oXwr8En6g34f7pBOZt1DAU= =A7Ja -----END PGP SIGNATURE----- --56zeyuukc3asnzuk--