* [PATCH 2/2] nvmem: sunxi_sid: Add support for D1 variant
2022-02-03 1:25 [PATCH 1/2] dt-bindings: nvmem: SID: Add compatible for D1 Samuel Holland
@ 2022-02-03 1:25 ` Samuel Holland
2022-02-03 8:13 ` Maxime Ripard
2022-02-03 8:13 ` [PATCH 1/2] dt-bindings: nvmem: SID: Add compatible for D1 Maxime Ripard
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Samuel Holland @ 2022-02-03 1:25 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec, linux-sunxi,
linux-arm-kernel, linux-kernel, Rob Herring, devicetree,
Samuel Holland
D1 has a smaller eFuse block than some other recent SoCs, and it no
longer requires a workaround to read the eFuse data.
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
drivers/nvmem/sunxi_sid.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/nvmem/sunxi_sid.c b/drivers/nvmem/sunxi_sid.c
index 275b9155e473..5750e1f4bcdb 100644
--- a/drivers/nvmem/sunxi_sid.c
+++ b/drivers/nvmem/sunxi_sid.c
@@ -184,6 +184,11 @@ static const struct sunxi_sid_cfg sun8i_h3_cfg = {
.need_register_readout = true,
};
+static const struct sunxi_sid_cfg sun20i_d1_cfg = {
+ .value_offset = 0x200,
+ .size = 0x100,
+};
+
static const struct sunxi_sid_cfg sun50i_a64_cfg = {
.value_offset = 0x200,
.size = 0x100,
@@ -200,6 +205,7 @@ static const struct of_device_id sunxi_sid_of_match[] = {
{ .compatible = "allwinner,sun7i-a20-sid", .data = &sun7i_a20_cfg },
{ .compatible = "allwinner,sun8i-a83t-sid", .data = &sun50i_a64_cfg },
{ .compatible = "allwinner,sun8i-h3-sid", .data = &sun8i_h3_cfg },
+ { .compatible = "allwinner,sun20i-d1-sid", .data = &sun20i_d1_cfg },
{ .compatible = "allwinner,sun50i-a64-sid", .data = &sun50i_a64_cfg },
{ .compatible = "allwinner,sun50i-h5-sid", .data = &sun50i_a64_cfg },
{ .compatible = "allwinner,sun50i-h6-sid", .data = &sun50i_h6_cfg },
--
2.33.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] nvmem: sunxi_sid: Add support for D1 variant
2022-02-03 1:25 ` [PATCH 2/2] nvmem: sunxi_sid: Add support for D1 variant Samuel Holland
@ 2022-02-03 8:13 ` Maxime Ripard
0 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2022-02-03 8:13 UTC (permalink / raw)
To: Samuel Holland
Cc: Srinivas Kandagatla, Chen-Yu Tsai, Jernej Skrabec, linux-sunxi,
linux-arm-kernel, linux-kernel, Rob Herring, devicetree
[-- Attachment #1: Type: text/plain, Size: 308 bytes --]
On Wed, Feb 02, 2022 at 07:25:01PM -0600, Samuel Holland wrote:
> D1 has a smaller eFuse block than some other recent SoCs, and it no
> longer requires a workaround to read the eFuse data.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Acked-by: Maxime Ripard <maxime@cerno.tech>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: nvmem: SID: Add compatible for D1
2022-02-03 1:25 [PATCH 1/2] dt-bindings: nvmem: SID: Add compatible for D1 Samuel Holland
2022-02-03 1:25 ` [PATCH 2/2] nvmem: sunxi_sid: Add support for D1 variant Samuel Holland
@ 2022-02-03 8:13 ` Maxime Ripard
2022-02-11 14:10 ` Rob Herring
2022-02-14 10:49 ` Srinivas Kandagatla
3 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2022-02-03 8:13 UTC (permalink / raw)
To: Samuel Holland
Cc: Srinivas Kandagatla, Chen-Yu Tsai, Jernej Skrabec, linux-sunxi,
linux-arm-kernel, linux-kernel, Rob Herring, devicetree
[-- Attachment #1: Type: text/plain, Size: 295 bytes --]
On Wed, Feb 02, 2022 at 07:25:00PM -0600, Samuel Holland wrote:
> D1 has a SID like other Allwinner SoCs, but with a unique eFuse layout.
> Add a new compatible string for it.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Acked-by: Maxime Ripard <maxime@cerno.tech>
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: nvmem: SID: Add compatible for D1
2022-02-03 1:25 [PATCH 1/2] dt-bindings: nvmem: SID: Add compatible for D1 Samuel Holland
2022-02-03 1:25 ` [PATCH 2/2] nvmem: sunxi_sid: Add support for D1 variant Samuel Holland
2022-02-03 8:13 ` [PATCH 1/2] dt-bindings: nvmem: SID: Add compatible for D1 Maxime Ripard
@ 2022-02-11 14:10 ` Rob Herring
2022-02-14 10:49 ` Srinivas Kandagatla
3 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2022-02-11 14:10 UTC (permalink / raw)
To: Samuel Holland
Cc: Jernej Skrabec, linux-sunxi, Maxime Ripard, Rob Herring,
linux-kernel, Chen-Yu Tsai, Srinivas Kandagatla, linux-arm-kernel,
devicetree
On Wed, 02 Feb 2022 19:25:00 -0600, Samuel Holland wrote:
> D1 has a SID like other Allwinner SoCs, but with a unique eFuse layout.
> Add a new compatible string for it.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
>
> .../devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] dt-bindings: nvmem: SID: Add compatible for D1
2022-02-03 1:25 [PATCH 1/2] dt-bindings: nvmem: SID: Add compatible for D1 Samuel Holland
` (2 preceding siblings ...)
2022-02-11 14:10 ` Rob Herring
@ 2022-02-14 10:49 ` Srinivas Kandagatla
3 siblings, 0 replies; 6+ messages in thread
From: Srinivas Kandagatla @ 2022-02-14 10:49 UTC (permalink / raw)
To: Samuel Holland
Cc: Maxime Ripard, Chen-Yu Tsai, Jernej Skrabec, linux-sunxi,
linux-arm-kernel, linux-kernel, Rob Herring, devicetree
On 03/02/2022 01:25, Samuel Holland wrote:
> D1 has a SID like other Allwinner SoCs, but with a unique eFuse layout.
> Add a new compatible string for it.
>
> Signed-off-by: Samuel Holland <samuel@sholland.org>
> ---
Applied both thanks,
--srini
>
> .../devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> index 6687ab720304..e558587ff885 100644
> --- a/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/allwinner,sun4i-a10-sid.yaml
> @@ -20,6 +20,7 @@ properties:
> - const: allwinner,sun7i-a20-sid
> - const: allwinner,sun8i-a83t-sid
> - const: allwinner,sun8i-h3-sid
> + - const: allwinner,sun20i-d1-sid
> - const: allwinner,sun50i-a64-sid
> - items:
> - const: allwinner,sun50i-a100-sid
^ permalink raw reply [flat|nested] 6+ messages in thread