From: Maxime Ripard <maxime@cerno.tech>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: "Noralf Trønnes" <noralf@tronnes.org>,
robh+dt@kernel.org, thierry.reding@gmail.com,
dave.stevenson@raspberrypi.com, david@lechnology.com,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver
Date: Thu, 3 Feb 2022 16:06:05 +0100 [thread overview]
Message-ID: <20220203150605.pkdckq64hyoengqv@houat> (raw)
In-Reply-To: <Yfq76Mx6O8x9sxZW@ravnborg.org>
[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]
Hi Sam,
On Wed, Feb 02, 2022 at 06:14:16PM +0100, Sam Ravnborg wrote:
> Hi Noralf,
>
> > >
> > > Parts of it is ergonomics I guess. We're used to having all those
> > > properties either in the DT or the driver, but here we introduce a new
> > > way that isn't done anywhere else.
> > >
> > > And I don't see any real downside to putting it in the DT? It's going to
> > > be in an overlay, under the user's control anyway, right?
> > >
> >
> > Ok, I'll spin a new version using DT properties.
>
> I like this better than anything else as we then have everything in
> a single place when we add a new panel and more.
> I just recall some resistance to add such HW specific setup - but the
> usecase here is kinda special.
The main issue was to put the initialisation sequence in the device
tree. We solved that with by using a firmware instead. Given that the
timings, size and so on are already used by multiple, widely used,
panels, it should work just fine
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-02-03 15:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 17:56 [PATCH v2 0/3] drm/panel: Add MIPI DBI compatible SPI driver Noralf Trønnes
2022-01-25 17:56 ` [PATCH v2 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels Noralf Trønnes
2022-01-27 9:37 ` Maxime Ripard
2022-02-07 23:20 ` Rob Herring
2022-02-08 12:16 ` Noralf Trønnes
2022-02-09 9:04 ` Maxime Ripard
2022-02-09 12:29 ` Noralf Trønnes
2022-01-25 17:56 ` [PATCH v2 2/3] drm/mipi-dbi: Add driver_private member to struct mipi_dbi_dev Noralf Trønnes
2022-01-25 17:57 ` [PATCH v2 3/3] drm/panel: Add MIPI DBI compatible SPI driver Noralf Trønnes
2022-01-27 10:04 ` Maxime Ripard
2022-01-27 17:53 ` Noralf Trønnes
2022-02-02 10:09 ` Maxime Ripard
2022-02-02 13:53 ` Noralf Trønnes
2022-02-02 17:14 ` Sam Ravnborg
2022-02-03 15:06 ` Maxime Ripard [this message]
2022-01-27 17:19 ` David Lechner
2022-01-27 20:08 ` Noralf Trønnes
[not found] ` <YfL5ptT3Kw1ohC/1@ravnborg.org>
2022-01-27 20:26 ` Noralf Trønnes
2022-01-27 17:13 ` [PATCH v2 0/3] " David Lechner
2022-01-27 20:02 ` Noralf Trønnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220203150605.pkdckq64hyoengqv@houat \
--to=maxime@cerno.tech \
--cc=dave.stevenson@raspberrypi.com \
--cc=david@lechnology.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=noralf@tronnes.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox