From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH] dt-bindings: pwm: mtk-disp: add compatible string for MT8183 SoC
Date: Mon, 7 Feb 2022 13:51:58 +0100 [thread overview]
Message-ID: <20220207125158.t5362u2dddccdmsq@pengutronix.de> (raw)
In-Reply-To: <20220207112657.18246-1-allen-kh.cheng@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]
Hello,
On Mon, Feb 07, 2022 at 07:26:57PM +0800, Allen-KH Cheng wrote:
> From: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com>
>
> Add compatible string for MT8183 SoC in device tree binding.
>
> Signed-off-by: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com>
> ---
> Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt b/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
> index 902b271891ae..691e58b6c223 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
> +++ b/Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
> @@ -6,6 +6,7 @@ Required properties:
> - "mediatek,mt6595-disp-pwm": found on mt6595 SoC.
> - "mediatek,mt8167-disp-pwm", "mediatek,mt8173-disp-pwm": found on mt8167 SoC.
> - "mediatek,mt8173-disp-pwm": found on mt8173 SoC.
> + - "mediatek,mt8183-disp-pwm": found on mt8183 SoC.$
The patch looks good in principle. I'd like to see the .txt file
converted to .yaml though. Would you care for that please?
Also it would be good if you'd care that sender email address and author
address match.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-02-07 13:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 11:26 [PATCH] dt-bindings: pwm: mtk-disp: add compatible string for MT8183 SoC Allen-KH Cheng
2022-02-07 12:51 ` Uwe Kleine-König [this message]
[not found] ` <f6633fc82c4fa899c7f4ca27d9751d9e61fb90ac.camel@mediatek.com>
2022-02-08 9:10 ` Uwe Kleine-König
2022-02-24 13:27 ` Thierry Reding
2022-02-11 16:24 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220207125158.t5362u2dddccdmsq@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=allen-kh.cheng@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).