From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC19DC4332F for ; Wed, 9 Feb 2022 10:16:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233832AbiBIKQu (ORCPT ); Wed, 9 Feb 2022 05:16:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232965AbiBIKQt (ORCPT ); Wed, 9 Feb 2022 05:16:49 -0500 Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 426D0E04AC97; Wed, 9 Feb 2022 02:13:08 -0800 (PST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id 776AF2B00246; Wed, 9 Feb 2022 04:26:45 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 09 Feb 2022 04:26:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; bh=Yst7o+x5EtjXnl33aAZq4gosVv6gXJnBpoVn39 4TOHM=; b=ZpBgYdgJXi4cgTd2jIrh7o0vMx/f5jSOVxlKfvr2bC/EVLUhib//y0 +9la+HhPPoaLIVv7YsYEPSFEdw/FAJg2YaNc99THHsSU97m6w6wjCXbFXmt3n3t5 vPE2WKMv5XYIfnxodrSruxN70ye9IZYtyhoKN+ajkooexyppjjfk1zw+yQju7ETN 5F5wr+Ev5qDDaM5J2/0Wx8QQIo7bPAV70m2R66gQS4F4ynVhSRLTBExxw+QyJWlU +7TQqwGJafgyuZiTgehN9wLXxPb8pfr7nxmMXeYjS8n+SdF6EmbghkDB0enUlX17 vr4IQ4vQlCepHCrixpv8/QPGbMQUEJvg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Yst7o+x5EtjXnl33a AZq4gosVv6gXJnBpoVn394TOHM=; b=VO8XXfMVkaKkzAcPxAOsWlpy9P2Mr7HoG yDa+wCRtVfanK3hE58CxKm5hcLrf0HK5wAxIGZpU7reFl9WfR8K+uFY3SihJmyiX E3eNUaHXhghVHkDK2xlXny4mDVbxPumcqjOh56DXJDTCbu+1hjd2GprCfjZwVGF+ frj8Po4MDFdlqYUbtFhi4N4OEkZfAGBVPKa5FSPVqHYE8M7BbWoG4O2hfDp1ZMbz n7sUkkcdVuWMtFn/52mdV3Ror9VYTCMr6YMpVocRKffhPzWlzLq4cTEK3pwvJeuF NegHi8sK4kWOgJOJ/+Is0WGnFn22Bxp393MhUM0MaXxsNsvhYySXA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrheelgddtfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 9 Feb 2022 04:26:43 -0500 (EST) Date: Wed, 9 Feb 2022 10:26:42 +0100 From: Maxime Ripard To: Paul Kocialkowski Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-clk@vger.kernel.org, linux-staging@lists.linux.dev, Yong Deng , Mauro Carvalho Chehab , Rob Herring , Sakari Ailus , Hans Verkuil , Chen-Yu Tsai , Jernej Skrabec , Greg Kroah-Hartman , Helen Koike , Laurent Pinchart , Thomas Petazzoni Subject: Re: [PATCH v2 32/66] media: sun6i-csi: Add capture state using vsync for page flip Message-ID: <20220209092642.hhppmrrekj7zrorj@houat> References: <20220205185429.2278860-1-paul.kocialkowski@bootlin.com> <20220205185429.2278860-33-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jklumgcplfx32qie" Content-Disposition: inline In-Reply-To: <20220205185429.2278860-33-paul.kocialkowski@bootlin.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --jklumgcplfx32qie Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Feb 05, 2022 at 07:53:55PM +0100, Paul Kocialkowski wrote: > This introduces a new state structure and associated helpers for > capture, which handles the buffer queue and state for each submitted > buffer. >=20 > Besides from the code refactoring, this changes the page flip point > to vsync instead of frame done, which allows working with only > two buffers without losing frames. This is apparently a more > appropriate thing to do with this controller. Why? What issues were you seeing before, how does using a separate interrupt addresses it, and what makes you think it's more appropriate? Maxime --jklumgcplfx32qie Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYgOI0gAKCRDj7w1vZxhR xYZPAQDrDko84tq9LXCvMRtIUy/RSXOSvfU/BhWGM/EPZPpjHAEArGovoU+NnCqt aFGVF658ZsgVaRo6Oorm0BIvOnUZLgg= =J6MU -----END PGP SIGNATURE----- --jklumgcplfx32qie--