* [PATCH] dt-bindings: crypto: convert rockchip-crypto to yaml
@ 2022-02-09 12:47 Corentin Labbe
2022-02-09 12:52 ` Heiko Stübner
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Corentin Labbe @ 2022-02-09 12:47 UTC (permalink / raw)
To: davem, heiko, herbert, krzysztof.kozlowski, robh+dt
Cc: devicetree, linux-arm-kernel, linux-crypto, linux-kernel,
linux-rockchip, Corentin Labbe
Convert rockchip-crypto to yaml.
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
.../bindings/crypto/rockchip-crypto.txt | 28 --------
.../bindings/crypto/rockchip-crypto.yaml | 64 +++++++++++++++++++
2 files changed, 64 insertions(+), 28 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
create mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml
diff --git a/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt b/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
deleted file mode 100644
index 5e2ba385b8c9..000000000000
--- a/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
+++ /dev/null
@@ -1,28 +0,0 @@
-Rockchip Electronics And Security Accelerator
-
-Required properties:
-- compatible: Should be "rockchip,rk3288-crypto"
-- reg: Base physical address of the engine and length of memory mapped
- region
-- interrupts: Interrupt number
-- clocks: Reference to the clocks about crypto
-- clock-names: "aclk" used to clock data
- "hclk" used to clock data
- "sclk" used to clock crypto accelerator
- "apb_pclk" used to clock dma
-- resets: Must contain an entry for each entry in reset-names.
- See ../reset/reset.txt for details.
-- reset-names: Must include the name "crypto-rst".
-
-Examples:
-
- crypto: cypto-controller@ff8a0000 {
- compatible = "rockchip,rk3288-crypto";
- reg = <0xff8a0000 0x4000>;
- interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&cru ACLK_CRYPTO>, <&cru HCLK_CRYPTO>,
- <&cru SCLK_CRYPTO>, <&cru ACLK_DMAC1>;
- clock-names = "aclk", "hclk", "sclk", "apb_pclk";
- resets = <&cru SRST_CRYPTO>;
- reset-names = "crypto-rst";
- };
diff --git a/Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml b/Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml
new file mode 100644
index 000000000000..392d89055398
--- /dev/null
+++ b/Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml
@@ -0,0 +1,64 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/crypto/rockchip-crypto.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Rockchip Electronics And Security Accelerator
+
+maintainers:
+ - Heiko Stuebner <heiko@sntech.de>
+
+properties:
+ compatible:
+ const: rockchip,rk3288-crypto
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: clock data
+ - description: clock data
+ - description: clock crypto accelerator
+ - description: clock dma
+
+ clock-names:
+ items:
+ - const: aclk
+ - const: hclk
+ - const: sclk
+ - const: apb_pclk
+
+ resets:
+ minItems: 1
+
+ reset-names:
+ const: crypto-rst
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - clocks
+ - clock-names
+ - resets
+ - reset-names
+
+additionalProperties: false
+
+examples:
+ - |
+ crypto: crypto@ff8a0000 {
+ compatible = "rockchip,rk3288-crypto";
+ reg = <0xff8a0000 0x4000>;
+ interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cru ACLK_CRYPTO>, <&cru HCLK_CRYPTO>,
+ <&cru SCLK_CRYPTO>, <&cru ACLK_DMAC1>;
+ clock-names = "aclk", "hclk", "sclk", "apb_pclk";
+ resets = <&cru SRST_CRYPTO>;
+ reset-names = "crypto-rst";
+ };
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: crypto: convert rockchip-crypto to yaml
2022-02-09 12:47 [PATCH] dt-bindings: crypto: convert rockchip-crypto to yaml Corentin Labbe
@ 2022-02-09 12:52 ` Heiko Stübner
2022-02-09 13:42 ` Corentin Labbe
2022-02-09 13:46 ` Krzysztof Kozlowski
2022-02-09 15:35 ` Rob Herring
2 siblings, 1 reply; 5+ messages in thread
From: Heiko Stübner @ 2022-02-09 12:52 UTC (permalink / raw)
To: davem, herbert, krzysztof.kozlowski, robh+dt, Corentin Labbe
Cc: devicetree, linux-arm-kernel, linux-crypto, linux-kernel,
linux-rockchip, Corentin Labbe
Am Mittwoch, 9. Februar 2022, 13:47:25 CET schrieb Corentin Labbe:
> Convert rockchip-crypto to yaml.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> .../bindings/crypto/rockchip-crypto.txt | 28 --------
> .../bindings/crypto/rockchip-crypto.yaml | 64 +++++++++++++++++++
> 2 files changed, 64 insertions(+), 28 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
> create mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml
>
> diff --git a/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt b/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
> deleted file mode 100644
> index 5e2ba385b8c9..000000000000
> --- a/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
> +++ /dev/null
> @@ -1,28 +0,0 @@
> -Rockchip Electronics And Security Accelerator
> -
> -Required properties:
> -- compatible: Should be "rockchip,rk3288-crypto"
> -- reg: Base physical address of the engine and length of memory mapped
> - region
> -- interrupts: Interrupt number
> -- clocks: Reference to the clocks about crypto
> -- clock-names: "aclk" used to clock data
> - "hclk" used to clock data
> - "sclk" used to clock crypto accelerator
> - "apb_pclk" used to clock dma
> -- resets: Must contain an entry for each entry in reset-names.
> - See ../reset/reset.txt for details.
> -- reset-names: Must include the name "crypto-rst".
> -
> -Examples:
> -
> - crypto: cypto-controller@ff8a0000 {
> - compatible = "rockchip,rk3288-crypto";
> - reg = <0xff8a0000 0x4000>;
> - interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cru ACLK_CRYPTO>, <&cru HCLK_CRYPTO>,
> - <&cru SCLK_CRYPTO>, <&cru ACLK_DMAC1>;
> - clock-names = "aclk", "hclk", "sclk", "apb_pclk";
> - resets = <&cru SRST_CRYPTO>;
> - reset-names = "crypto-rst";
> - };
> diff --git a/Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml b/Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml
> new file mode 100644
> index 000000000000..392d89055398
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/crypto/rockchip-crypto.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rockchip Electronics And Security Accelerator
> +
> +maintainers:
> + - Heiko Stuebner <heiko@sntech.de>
> +
> +properties:
> + compatible:
> + const: rockchip,rk3288-crypto
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: clock data
> + - description: clock data
> + - description: clock crypto accelerator
> + - description: clock dma
> +
> + clock-names:
> + items:
> + - const: aclk
> + - const: hclk
> + - const: sclk
> + - const: apb_pclk
> +
> + resets:
> + minItems: 1
> +
> + reset-names:
> + const: crypto-rst
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - resets
> + - reset-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
Binding itself looks good.
But the constants below will probably trigger a compiler-error and
therefore Rob's bot.
You will need something like
#include <dt-bindings/clock/rk3399-cru.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
here.
A "make ..... dt_binding_check" should show the issue and also
it going away with the right includes ;-)
Heiko
> + crypto: crypto@ff8a0000 {
> + compatible = "rockchip,rk3288-crypto";
> + reg = <0xff8a0000 0x4000>;
> + interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru ACLK_CRYPTO>, <&cru HCLK_CRYPTO>,
> + <&cru SCLK_CRYPTO>, <&cru ACLK_DMAC1>;
> + clock-names = "aclk", "hclk", "sclk", "apb_pclk";
> + resets = <&cru SRST_CRYPTO>;
> + reset-names = "crypto-rst";
> + };
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: crypto: convert rockchip-crypto to yaml
2022-02-09 12:52 ` Heiko Stübner
@ 2022-02-09 13:42 ` Corentin Labbe
0 siblings, 0 replies; 5+ messages in thread
From: Corentin Labbe @ 2022-02-09 13:42 UTC (permalink / raw)
To: Heiko Stübner
Cc: davem, herbert, krzysztof.kozlowski, robh+dt, Corentin Labbe,
devicetree, linux-arm-kernel, linux-crypto, linux-kernel,
linux-rockchip
Le Wed, Feb 09, 2022 at 01:52:45PM +0100, Heiko Stübner a écrit :
> Am Mittwoch, 9. Februar 2022, 13:47:25 CET schrieb Corentin Labbe:
> > Convert rockchip-crypto to yaml.
> >
> > Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> > ---
> > .../bindings/crypto/rockchip-crypto.txt | 28 --------
> > .../bindings/crypto/rockchip-crypto.yaml | 64 +++++++++++++++++++
> > 2 files changed, 64 insertions(+), 28 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
> > create mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt b/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
> > deleted file mode 100644
> > index 5e2ba385b8c9..000000000000
> > --- a/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
> > +++ /dev/null
> > @@ -1,28 +0,0 @@
> > -Rockchip Electronics And Security Accelerator
> > -
> > -Required properties:
> > -- compatible: Should be "rockchip,rk3288-crypto"
> > -- reg: Base physical address of the engine and length of memory mapped
> > - region
> > -- interrupts: Interrupt number
> > -- clocks: Reference to the clocks about crypto
> > -- clock-names: "aclk" used to clock data
> > - "hclk" used to clock data
> > - "sclk" used to clock crypto accelerator
> > - "apb_pclk" used to clock dma
> > -- resets: Must contain an entry for each entry in reset-names.
> > - See ../reset/reset.txt for details.
> > -- reset-names: Must include the name "crypto-rst".
> > -
> > -Examples:
> > -
> > - crypto: cypto-controller@ff8a0000 {
> > - compatible = "rockchip,rk3288-crypto";
> > - reg = <0xff8a0000 0x4000>;
> > - interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
> > - clocks = <&cru ACLK_CRYPTO>, <&cru HCLK_CRYPTO>,
> > - <&cru SCLK_CRYPTO>, <&cru ACLK_DMAC1>;
> > - clock-names = "aclk", "hclk", "sclk", "apb_pclk";
> > - resets = <&cru SRST_CRYPTO>;
> > - reset-names = "crypto-rst";
> > - };
> > diff --git a/Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml b/Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml
> > new file mode 100644
> > index 000000000000..392d89055398
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml
> > @@ -0,0 +1,64 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/crypto/rockchip-crypto.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Rockchip Electronics And Security Accelerator
> > +
> > +maintainers:
> > + - Heiko Stuebner <heiko@sntech.de>
> > +
> > +properties:
> > + compatible:
> > + const: rockchip,rk3288-crypto
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + clocks:
> > + items:
> > + - description: clock data
> > + - description: clock data
> > + - description: clock crypto accelerator
> > + - description: clock dma
> > +
> > + clock-names:
> > + items:
> > + - const: aclk
> > + - const: hclk
> > + - const: sclk
> > + - const: apb_pclk
> > +
> > + resets:
> > + minItems: 1
> > +
> > + reset-names:
> > + const: crypto-rst
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - clocks
> > + - clock-names
> > + - resets
> > + - reset-names
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
>
> Binding itself looks good.
>
> But the constants below will probably trigger a compiler-error and
> therefore Rob's bot.
>
> You will need something like
>
> #include <dt-bindings/clock/rk3399-cru.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
>
> here.
>
> A "make ..... dt_binding_check" should show the issue and also
> it going away with the right includes ;-)
>
> Heiko
>
Right, I forgot to add this file in my "dt to check" via dt_binding_check, but the following make dtbs_check made me believe it was tested.
I will send a v2 soon.
Regards
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: crypto: convert rockchip-crypto to yaml
2022-02-09 12:47 [PATCH] dt-bindings: crypto: convert rockchip-crypto to yaml Corentin Labbe
2022-02-09 12:52 ` Heiko Stübner
@ 2022-02-09 13:46 ` Krzysztof Kozlowski
2022-02-09 15:35 ` Rob Herring
2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-02-09 13:46 UTC (permalink / raw)
To: Corentin Labbe, davem, heiko, herbert, robh+dt
Cc: devicetree, linux-arm-kernel, linux-crypto, linux-kernel,
linux-rockchip
On 09/02/2022 13:47, Corentin Labbe wrote:
> Convert rockchip-crypto to yaml.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> .../bindings/crypto/rockchip-crypto.txt | 28 --------
> .../bindings/crypto/rockchip-crypto.yaml | 64 +++++++++++++++++++
> 2 files changed, 64 insertions(+), 28 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
> create mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml
>
> diff --git a/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt b/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
> deleted file mode 100644
> index 5e2ba385b8c9..000000000000
> --- a/Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
> +++ /dev/null
> @@ -1,28 +0,0 @@
> -Rockchip Electronics And Security Accelerator
> -
> -Required properties:
> -- compatible: Should be "rockchip,rk3288-crypto"
> -- reg: Base physical address of the engine and length of memory mapped
> - region
> -- interrupts: Interrupt number
> -- clocks: Reference to the clocks about crypto
> -- clock-names: "aclk" used to clock data
> - "hclk" used to clock data
> - "sclk" used to clock crypto accelerator
> - "apb_pclk" used to clock dma
> -- resets: Must contain an entry for each entry in reset-names.
> - See ../reset/reset.txt for details.
> -- reset-names: Must include the name "crypto-rst".
> -
> -Examples:
> -
> - crypto: cypto-controller@ff8a0000 {
> - compatible = "rockchip,rk3288-crypto";
> - reg = <0xff8a0000 0x4000>;
> - interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cru ACLK_CRYPTO>, <&cru HCLK_CRYPTO>,
> - <&cru SCLK_CRYPTO>, <&cru ACLK_DMAC1>;
> - clock-names = "aclk", "hclk", "sclk", "apb_pclk";
> - resets = <&cru SRST_CRYPTO>;
> - reset-names = "crypto-rst";
> - };
> diff --git a/Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml b/Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml
> new file mode 100644
> index 000000000000..392d89055398
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml
file name: rockchip,crypto.yaml or rockchip,rk3288-crypto.yaml.
Kind of depends whether there is another binding possible for newer
Crypto blocks from Rockchip. I guess it is quite possible, so maybe the
latter version.
> @@ -0,0 +1,64 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/crypto/rockchip-crypto.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Rockchip Electronics And Security Accelerator
> +
> +maintainers:
> + - Heiko Stuebner <heiko@sntech.de>
> +
> +properties:
> + compatible:
> + const: rockchip,rk3288-crypto
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: clock data
> + - description: clock data
> + - description: clock crypto accelerator
> + - description: clock dma
> +
> + clock-names:
> + items:
> + - const: aclk
> + - const: hclk
> + - const: sclk
> + - const: apb_pclk
> +
> + resets:
> + minItems: 1
Instead maxItems: 1
> +
> + reset-names:
> + const: crypto-rst
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - resets
> + - reset-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + crypto: crypto@ff8a0000 {
> + compatible = "rockchip,rk3288-crypto";
> + reg = <0xff8a0000 0x4000>;
> + interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru ACLK_CRYPTO>, <&cru HCLK_CRYPTO>,
> + <&cru SCLK_CRYPTO>, <&cru ACLK_DMAC1>;
Does it work? Did you run dt_binding_check?
> + clock-names = "aclk", "hclk", "sclk", "apb_pclk";
> + resets = <&cru SRST_CRYPTO>;
> + reset-names = "crypto-rst";
> + };
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: crypto: convert rockchip-crypto to yaml
2022-02-09 12:47 [PATCH] dt-bindings: crypto: convert rockchip-crypto to yaml Corentin Labbe
2022-02-09 12:52 ` Heiko Stübner
2022-02-09 13:46 ` Krzysztof Kozlowski
@ 2022-02-09 15:35 ` Rob Herring
2 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2022-02-09 15:35 UTC (permalink / raw)
To: Corentin Labbe
Cc: devicetree, linux-arm-kernel, heiko, robh+dt, linux-crypto,
krzysztof.kozlowski, davem, linux-rockchip, herbert, linux-kernel
On Wed, 09 Feb 2022 12:47:25 +0000, Corentin Labbe wrote:
> Convert rockchip-crypto to yaml.
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
> ---
> .../bindings/crypto/rockchip-crypto.txt | 28 --------
> .../bindings/crypto/rockchip-crypto.yaml | 64 +++++++++++++++++++
> 2 files changed, 64 insertions(+), 28 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
> create mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/crypto/rockchip-crypto.example.dts:22.25-26 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:378: Documentation/devicetree/bindings/crypto/rockchip-crypto.example.dt.yaml] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1398: dt_binding_check] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1590370
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-09 15:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-09 12:47 [PATCH] dt-bindings: crypto: convert rockchip-crypto to yaml Corentin Labbe
2022-02-09 12:52 ` Heiko Stübner
2022-02-09 13:42 ` Corentin Labbe
2022-02-09 13:46 ` Krzysztof Kozlowski
2022-02-09 15:35 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).