Re: [PATCH] arm64: dts: ti: k3-am65-main: Remove "syscon" nodes added for pcieX_mode/pcie_devid

[Nishanth Menon <nm@ti.com>]

On 12:57-20220209, Kishon Vijay Abraham I wrote:
> Remove "syscon" nodes added for pcieX_mode/pcie_devid and have the PCIe
> node point to the parent with an offset argument. This change is as
> discussed in [1].
> 
> commit 7dcf07ac8867 ("PCI: keystone: Use phandle argument from
> "ti,syscon-pcie-id"/"ti,syscon-pcie-mode"") added the corresponding driver
> changes.
> 
> [1] -> http://lore.kernel.org/r/CAL_JsqKiUcO76bo1GoepWM1TusJWoty_BRy2hFSgtEVMqtrvvQ@mail.gmail.com
> 
> Cc: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
> Cc: Jan Kiszka <jan.kiszka@siemens.com>

I think Reported-by is due here.


Jan, Matthias: will appreciate any one of your acks/reviews..

> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 27 ++++++------------------
>  1 file changed, 6 insertions(+), 21 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> index ce8bb4a61011..ff52e16ff603 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> @@ -304,21 +304,6 @@
>  		#size-cells = <1>;
>  		ranges = <0x0 0x0 0x00100000 0x1c000>;
>  
> -		pcie0_mode: pcie-mode@4060 {
> -			compatible = "syscon";
> -			reg = <0x00004060 0x4>;
> -		};
> -
> -		pcie1_mode: pcie-mode@4070 {
> -			compatible = "syscon";
> -			reg = <0x00004070 0x4>;
> -		};
> -
> -		pcie_devid: pcie-devid@210 {
> -			compatible = "syscon";
> -			reg = <0x00000210 0x4>;
> -		};
> -
>  		serdes0_clk: clock@4080 {
>  			compatible = "syscon";
>  			reg = <0x00004080 0x4>;
> @@ -694,8 +679,8 @@
>  		#size-cells = <2>;
>  		ranges = <0x81000000 0 0          0x0 0x10020000 0 0x00010000>,
>  			 <0x82000000 0 0x10030000 0x0 0x10030000 0 0x07FD0000>;
> -		ti,syscon-pcie-id = <&pcie_devid>;
> -		ti,syscon-pcie-mode = <&pcie0_mode>;
> +		ti,syscon-pcie-id = <&scm_conf 0x210>;
> +		ti,syscon-pcie-mode = <&scm_conf 0x4060>;
>  		bus-range = <0x0 0xff>;
>  		num-viewport = <16>;
>  		max-link-speed = <2>;
> @@ -710,7 +695,7 @@
>  		reg =  <0x0 0x5500000 0x0 0x1000>, <0x0 0x5501000 0x0 0x1000>, <0x0 0x10000000 0x0 0x8000000>, <0x0 0x5506000 0x0 0x1000>;
>  		reg-names = "app", "dbics", "addr_space", "atu";
>  		power-domains = <&k3_pds 120 TI_SCI_PD_EXCLUSIVE>;
> -		ti,syscon-pcie-mode = <&pcie0_mode>;
> +		ti,syscon-pcie-mode = <&scm_conf 0x4060>;
>  		num-ib-windows = <16>;
>  		num-ob-windows = <16>;
>  		max-link-speed = <2>;
> @@ -727,8 +712,8 @@
>  		#size-cells = <2>;
>  		ranges = <0x81000000 0 0          0x0   0x18020000 0 0x00010000>,
>  			 <0x82000000 0 0x18030000 0x0   0x18030000 0 0x07FD0000>;
> -		ti,syscon-pcie-id = <&pcie_devid>;
> -		ti,syscon-pcie-mode = <&pcie1_mode>;
> +		ti,syscon-pcie-id = <&scm_conf 0x210>;
> +		ti,syscon-pcie-mode = <&scm_conf 0x4070>;
>  		bus-range = <0x0 0xff>;
>  		num-viewport = <16>;
>  		max-link-speed = <2>;
> @@ -743,7 +728,7 @@
>  		reg =  <0x0 0x5600000 0x0 0x1000>, <0x0 0x5601000 0x0 0x1000>, <0x0 0x18000000 0x0 0x4000000>, <0x0 0x5606000 0x0 0x1000>;
>  		reg-names = "app", "dbics", "addr_space", "atu";
>  		power-domains = <&k3_pds 121 TI_SCI_PD_EXCLUSIVE>;
> -		ti,syscon-pcie-mode = <&pcie1_mode>;
> +		ti,syscon-pcie-mode = <&scm_conf 0x4070>;
>  		num-ib-windows = <16>;
>  		num-ob-windows = <16>;
>  		max-link-speed = <2>;
> -- 
> 2.17.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D