devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] arm64: dts: ti: Introduce base support for AM62x SoC
Date: Thu, 10 Feb 2022 13:34:59 -0600	[thread overview]
Message-ID: <20220210193459.nl6baranvmqs46bi@coastal> (raw)
In-Reply-To: <bc6cb6e1adcf6860a595b71246778733@kernel.org>

On 19:10-20220209, Marc Zyngier wrote:
[...]

> > +&cbass_main {
> > +	gic500: interrupt-controller@1800000 {
> > +		compatible = "arm,gic-v3";
> > +		#address-cells = <2>;
> > +		#size-cells = <2>;
> > +		ranges;
> > +		#interrupt-cells = <3>;
> > +		interrupt-controller;
> > +		reg = <0x00 0x01800000 0x00 0x10000>,	/* GICD */
> > +		      <0x00 0x01880000 0x00 0xC0000>;	/* GICR */
> 
> Usual rant: you are missing the GICC, GICH and GICV regions
> that are implemented by the CPU. Cortex-A53 implements them
> (they are not optional), so please describe them.
> 


-ECONFUSED. TRM for GIC500 refers to just GICD, GICR and ITS range[1].

Same thing is indicated by Generic Interrupt Controller Architecture
Specification[2] See table 1-1 (page 23).

I think you are expecting GICV3's backward compatibility mode (Table 1-2
in page 24), But in K3 architecture, are_option meant for backward
compatibility is set to true (aka no backward compatibility). I think
this did popup sometime back as well (first k3 SoC)[3]. I think the more
clearer description is available in [4].

I believe the argumentation that GICC/H/V is mandatory for A53 if GIC500
is used is not accurate. Please correct me if I am mistaken.


[1] https://developer.arm.com/documentation/ddi0516/e/programmers-model/the-gic-500-register-map?lang=en
[2] https://developer.arm.com/documentation/ihi0069/d
[3] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20180607233853.p7iw7nlxxuyi66og@kahuna/
[4] https://developer.arm.com/documentation/ddi0516/e/functional-description/operation/backwards-compatibility?lang=en

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

  reply	other threads:[~2022-02-10 19:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-08 13:18 [PATCH 0/5] arm64: Initial support for Texas Instruments AM62 Platform Vignesh Raghavendra
2022-02-08 13:18 ` [PATCH 1/5] soc: ti: k3-socinfo: Add AM62x JTAG ID Vignesh Raghavendra
2022-02-08 13:18 ` [PATCH 2/5] dt-bindings: arm: ti: Add bindings for AM625 SoC Vignesh Raghavendra
2022-02-08 17:01   ` Krzysztof Kozlowski
2022-02-09 19:04     ` Vignesh Raghavendra
2022-02-09 21:29       ` Krzysztof Kozlowski
2022-02-11 16:39   ` Rob Herring
2022-02-08 13:18 ` [PATCH 3/5] dt-bindings: pinctrl: k3: Introduce pinmux definitions for AM62 Vignesh Raghavendra
2022-02-11 16:41   ` Rob Herring
2022-02-08 13:18 ` [PATCH 4/5] arm64: dts: ti: Introduce base support for AM62x SoC Vignesh Raghavendra
2022-02-08 17:05   ` Krzysztof Kozlowski
2022-02-09 19:04     ` Vignesh Raghavendra
2022-02-09 21:36       ` Krzysztof Kozlowski
2022-02-09 19:10   ` Marc Zyngier
2022-02-10 19:34     ` Nishanth Menon [this message]
2022-02-11 11:33       ` Marc Zyngier
2022-02-11 23:55         ` Nishanth Menon
2022-02-12 11:40           ` Marc Zyngier
2022-02-15 21:12             ` Nishanth Menon
2022-02-08 13:18 ` [PATCH 5/5] arm64: dts: ti: Add support for AM62-SK Vignesh Raghavendra
2022-02-08 17:08   ` Krzysztof Kozlowski
2022-02-09 19:05     ` Vignesh Raghavendra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220210193459.nl6baranvmqs46bi@coastal \
    --to=nm@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=ssantosh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).