devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	NXP Linux Team <linux-imx@nxp.com>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/8] ARM: dts: imx6ul: fix adc node compatible
Date: Fri, 11 Feb 2022 11:47:07 +0800	[thread overview]
Message-ID: <20220211034707.GK4909@dragon> (raw)
In-Reply-To: <20220125135014.3041002-5-alexander.stein@ew.tq-group.com>

On Tue, Jan 25, 2022 at 02:50:10PM +0100, Alexander Stein wrote:
> fsl,imx6ul-adc is not listed in the binding, so remove it. Fixes the
> dt_binding_check warning:
> adc@2198000: compatible:0: 'fsl,vf610-adc' was expected
> adc@2198000: compatible: ['fsl,imx6ul-adc', 'fsl,vf610-adc'] is too long
> adc@2198000: compatible: Additional items are not allowed ('fsl,vf610-adc'
> was unexpected)
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  arch/arm/boot/dts/imx6ul.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi
> index df8b4ad62418..d6c2b0ad3eac 100644
> --- a/arch/arm/boot/dts/imx6ul.dtsi
> +++ b/arch/arm/boot/dts/imx6ul.dtsi
> @@ -920,7 +920,7 @@ usdhc2: mmc@2194000 {
>  			};
>  
>  			adc1: adc@2198000 {
> -				compatible = "fsl,imx6ul-adc", "fsl,vf610-adc";
> +				compatible = "fsl,vf610-adc";

Maybe we should add compatible "fsl,imx6ul-adc" to bindings?

Shawn

>  				reg = <0x02198000 0x4000>;
>  				interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clks IMX6UL_CLK_ADC1>;
> -- 
> 2.25.1
> 

  reply	other threads:[~2022-02-11  3:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25 13:50 [PATCH 0/8] various imx6ul DT fixes Alexander Stein
2022-01-25 13:50 ` [PATCH 1/8] ARM: dts: imx6ul: add missing properties for sram Alexander Stein
2022-02-11  3:42   ` Shawn Guo
2022-02-11 14:36     ` (EXT) " Alexander Stein
2022-01-25 13:50 ` [PATCH 2/8] ARM: dts: imx6ul: change operating-points to uint32-matrix Alexander Stein
2022-01-25 13:50 ` [PATCH 3/8] ARM: dts: imx6ul: fix keypad compatible Alexander Stein
2022-01-25 13:50 ` [PATCH 4/8] ARM: dts: imx6ul: fix adc node compatible Alexander Stein
2022-02-11  3:47   ` Shawn Guo [this message]
2022-02-11 14:47     ` (EXT) " Alexander Stein
2022-01-25 13:50 ` [PATCH 5/8] ARM: dts: imx6ul: remove unsupported adc property Alexander Stein
2022-01-25 13:50 ` [PATCH 6/8] ARM: dts: imx6ul: fix csi node compatible Alexander Stein
2022-01-25 13:50 ` [PATCH 7/8] ARM: dts: imx6ul: fix lcdif " Alexander Stein
2022-01-25 13:50 ` [PATCH 8/8] ARM: dts: imx6ul: fix qspi " Alexander Stein
2022-02-11  3:37 ` [PATCH 0/8] various imx6ul DT fixes Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220211034707.GK4909@dragon \
    --to=shawnguo@kernel.org \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).