public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: "Noralf Trønnes" <noralf@tronnes.org>
To: robh+dt@kernel.org, thierry.reding@gmail.com
Cc: sam@ravnborg.org, maxime@cerno.tech,
	dave.stevenson@raspberrypi.com, david@lechnology.com,
	devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	"Noralf Trønnes" <noralf@tronnes.org>
Subject: [PATCH v3 0/3] drm/panel: Add MIPI DBI compatible SPI driver
Date: Fri, 11 Feb 2022 14:04:31 +0100	[thread overview]
Message-ID: <20220211130434.20732-1-noralf@tronnes.org> (raw)

Hi,

This patchset adds a driver that will work with most MIPI DBI compatible
SPI panels out there.

Maxime gave[1] a good overview of the situation with these displays and
proposed to make a driver that works with all MIPI DBI compatible
controllers and use a firmware file to provide the controller setup for
a particular panel.

I have now made a script[2] that can create the firmware file, example
in the wiki[3]

Main change since version 2:
- Use Device Tree for all properties (Maxime)

The MIPI DPI specification has optional support for DPI where the
controller is configured over DBI. Because of this I put the driver in
drm/panel so it could be extended in the future to support
panel-mipi-dpi-spi. I have now looked at this more closely and the only
thing that can be shared between the two are the firmware command
functions. These functions can be moved to the drm_mipi_dbi_helper for
sharing. Now that I know that there won't be one driver module that
supports both use cases, I'm thinking of moving the driver to drm/tiny
where the other drivers of its kind are located. I'll move the driver in
the next version of the patchset unless someone have reasons for leaving
it in drm/panel.

Noralf.

[1] https://lore.kernel.org/dri-devel/20211129093946.xhp22mvdut3m67sc@houat/
[2] https://github.com/notro/panel-mipi-dbi/blob/main/mipi-dbi-cmd
[3] https://github.com/notro/panel-mipi-dbi/wiki


Noralf Trønnes (3):
  dt-bindings: display: add bindings for MIPI DBI compatible SPI panels
  drm/mipi-dbi: Add driver_private member to struct mipi_dbi_dev
  drm/panel: Add MIPI DBI compatible SPI driver

 .../display/panel/panel-mipi-dbi-spi.yaml     | 124 ++++++
 MAINTAINERS                                   |   8 +
 drivers/gpu/drm/panel/Kconfig                 |  13 +
 drivers/gpu/drm/panel/Makefile                |   1 +
 drivers/gpu/drm/panel/panel-mipi-dbi.c        | 413 ++++++++++++++++++
 include/drm/drm_mipi_dbi.h                    |   8 +
 6 files changed, 567 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
 create mode 100644 drivers/gpu/drm/panel/panel-mipi-dbi.c

-- 
2.33.0


             reply	other threads:[~2022-02-11 13:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-11 13:04 Noralf Trønnes [this message]
2022-02-11 13:04 ` [PATCH v3 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels Noralf Trønnes
2022-02-11 13:27   ` Maxime Ripard
2022-02-11 14:05     ` Noralf Trønnes
2022-02-11 13:04 ` [PATCH v3 2/3] drm/mipi-dbi: Add driver_private member to struct mipi_dbi_dev Noralf Trønnes
2022-02-11 13:28   ` Maxime Ripard
2022-02-11 13:04 ` [PATCH v3 3/3] drm/panel: Add MIPI DBI compatible SPI driver Noralf Trønnes
2022-02-11 13:28   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220211130434.20732-1-noralf@tronnes.org \
    --to=noralf@tronnes.org \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=david@lechnology.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=maxime@cerno.tech \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox