From: Liam Beguin <liambeguin@gmail.com>
To: liambeguin@gmail.com, peda@axentia.se, jic23@kernel.org,
andy.shevchenko@gmail.com, lars@metafoo.de
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org
Subject: [PATCH v15 04/10] iio: afe: rescale: fix accuracy for small fractional scales
Date: Sat, 12 Feb 2022 21:57:33 -0500 [thread overview]
Message-ID: <20220213025739.2561834-5-liambeguin@gmail.com> (raw)
In-Reply-To: <20220213025739.2561834-1-liambeguin@gmail.com>
The approximation caused by integer divisions can be costly on smaller
scale values since the decimal part is significant compared to the
integer part. Switch to an IIO_VAL_INT_PLUS_NANO scale type in such
cases to maintain accuracy.
Signed-off-by: Liam Beguin <liambeguin@gmail.com>
Reviewed-by: Peter Rosin <peda@axentia.se>
---
drivers/iio/afe/iio-rescale.c | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/afe/iio-rescale.c b/drivers/iio/afe/iio-rescale.c
index 8eaf766e28cc..5d78f0cf47d2 100644
--- a/drivers/iio/afe/iio-rescale.c
+++ b/drivers/iio/afe/iio-rescale.c
@@ -24,7 +24,7 @@ int rescale_process_scale(struct rescale *rescale, int scale_type,
int *val, int *val2)
{
s64 tmp;
- s32 rem;
+ s32 rem, rem2;
u32 mult;
u32 neg;
@@ -43,9 +43,23 @@ int rescale_process_scale(struct rescale *rescale, int scale_type,
tmp = (s64)*val * 1000000000LL;
tmp = div_s64(tmp, rescale->denominator);
tmp *= rescale->numerator;
- tmp = div_s64(tmp, 1000000000LL);
+
+ tmp = div_s64_rem(tmp, 1000000000LL, &rem);
*val = tmp;
- return scale_type;
+
+ if (!rem)
+ return scale_type;
+
+ tmp = 1 << *val2;
+
+ rem2 = *val % (int)tmp;
+ *val = *val / (int)tmp;
+
+ *val2 = rem / (int)tmp;
+ if (rem2)
+ *val2 += div_s64((s64)rem2 * 1000000000LL, tmp);
+
+ return IIO_VAL_INT_PLUS_NANO;
case IIO_VAL_INT_PLUS_NANO:
case IIO_VAL_INT_PLUS_MICRO:
mult = scale_type == IIO_VAL_INT_PLUS_NANO ? 1000000000L : 1000000L;
--
2.35.1.4.g5d01301f2b86
next prev parent reply other threads:[~2022-02-13 2:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-13 2:57 [PATCH v15 00/10] iio: afe: add temperature rescaling support Liam Beguin
2022-02-13 2:57 ` [PATCH v15 01/10] iio: afe: rescale: expose scale processing function Liam Beguin
2022-02-13 2:57 ` [PATCH v15 02/10] iio: afe: rescale: add INT_PLUS_{MICRO,NANO} support Liam Beguin
2022-02-13 2:57 ` [PATCH v15 03/10] iio: afe: rescale: add offset support Liam Beguin
2022-02-13 2:57 ` Liam Beguin [this message]
2022-02-13 2:57 ` [PATCH v15 05/10] iio: afe: rescale: reduce risk of integer overflow Liam Beguin
2022-02-13 2:57 ` [PATCH v15 06/10] iio: test: add basic tests for the iio-rescale driver Liam Beguin
2022-06-27 7:22 ` Geert Uytterhoeven
2022-06-28 17:06 ` Liam Beguin
2022-02-13 2:57 ` [PATCH v15 07/10] iio: afe: rescale: add RTD temperature sensor support Liam Beguin
2022-02-13 2:57 ` [PATCH v15 08/10] iio: afe: rescale: add temperature transducers Liam Beguin
2022-02-13 2:57 ` [PATCH v15 09/10] dt-bindings: iio: afe: add bindings for temperature-sense-rtd Liam Beguin
2022-02-13 2:57 ` [PATCH v15 10/10] dt-bindings: iio: afe: add bindings for temperature transducers Liam Beguin
2022-02-27 12:55 ` [PATCH v15 00/10] iio: afe: add temperature rescaling support Jonathan Cameron
2022-02-27 13:05 ` Jonathan Cameron
2022-02-27 13:25 ` Andy Shevchenko
2022-02-27 13:39 ` Jonathan Cameron
2022-02-28 16:45 ` Liam Beguin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220213025739.2561834-5-liambeguin@gmail.com \
--to=liambeguin@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).