Re: [PATCH 1/2] dt-bindings: ps2-gpio: convert binding to json-schema

Danilo Krummrich
2022-02-15T17:53:43Z

On Tue, Feb 15, 2022 at 05:59:36PM +0100, Krzysztof Kozlowski wrote:
> On 15/02/2022 17:51, Danilo Krummrich wrote:
> > Convert the ps2-gpio dt-binding documentation to DT schema format using
> > the json-schema.
> >
> > Signed-off-by: Danilo Krummrich <danilokrummrich@dk-develop.de>
> > ---
> > .../devicetree/bindings/serio/ps2-gpio.txt | 23 --------
> > .../devicetree/bindings/serio/ps2-gpio.yaml | 58 +++++++++++++++++++
> > 2 files changed, 58 insertions(+), 23 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/serio/ps2-gpio.txt
> > create mode 100644 Documentation/devicetree/bindings/serio/ps2-gpio.yaml
> >
>
> Please version your patches in the subject. You can achieve it manually
> or with `git format-patch -v2`. I think lack of v2 confuses b4 diff
> ("ERROR: Could not auto-find previous revision
> ").
Yes, I accidentally missed the `-v2` parameter.
>
> > +
> > +additionalProperties: true
> > +
>
> I missed this part (lack of) in your v1. This has to be false.
I'll send a v3.
>
> Best regards,
> Krzysztof

Thanks.

- Danilo