Re: [PATCH 1/2] dt-bindings: ps2-gpio: convert binding to json-schema

Krzysztof Kozlowski
2022-02-15T16:59:42Z

On 15/02/2022 17:51, Danilo Krummrich wrote:
> Convert the ps2-gpio dt-binding documentation to DT schema format using
> the json-schema.
>
> Signed-off-by: Danilo Krummrich <danilokrummrich@dk-develop.de>
> ---
> .../devicetree/bindings/serio/ps2-gpio.txt | 23 --------
> .../devicetree/bindings/serio/ps2-gpio.yaml | 58 +++++++++++++++++++
> 2 files changed, 58 insertions(+), 23 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/serio/ps2-gpio.txt
> create mode 100644 Documentation/devicetree/bindings/serio/ps2-gpio.yaml
>

Please version your patches in the subject. You can achieve it manually
or with `git format-patch -v2`. I think lack of v2 confuses b4 diff
("ERROR: Could not auto-find previous revision
").

> diff --git a/Documentation/devicetree/bindings/serio/ps2-gpio.yaml b/Documentation/devicetree/bindings/serio/ps2-gpio.yaml
> new file mode 100644
> index 000000000000..41e43d797651
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serio/ps2-gpio.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/serio/ps2-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Bindings for GPIO based PS/2
> +
> +maintainers:
> + - Danilo Krummrich <danilokrummrich@dk-develop.de>
> +
> +properties:
> + compatible:
> + const: ps2-gpio
> +
> + data-gpios:
> + description:
> + the gpio used for the data signal
> + maxItems: 1
> +
> + clk-gpios:
> + description:
> + the gpio used for the clock signal
> + maxItems: 1
> +
> + interrupts:
> + description:
> + The given interrupt should trigger on the falling edge of the clock line.
> + maxItems: 1
> +
> + write-enable:
> + type: boolean
> + description:
> + Indicates whether write function is provided to serio device. Possibly
> + providing the write function will not work, because of the tough timing
> + requirements.
> +
> +required:
> + - compatible
> + - data-gpios
> + - clk-gpios
> + - interrupts
> +
> +additionalProperties: true
> +

I missed this part (lack of) in your v1. This has to be false.

Best regards,
Krzysztof