devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Cristian Marussi <cristian.marussi@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: firmware: arm,scpi: Add missing maxItems to shmem property
Date: Wed, 16 Feb 2022 14:39:26 +0000	[thread overview]
Message-ID: <20220216143926.t3dadlsjtkotkv6o@bogus> (raw)
In-Reply-To: <f6d1ea27e8b8dc47fbe849661cc5a843bc2f1ba5.1645017656.git.geert+renesas@glider.be>

On Wed, Feb 16, 2022 at 02:21:43PM +0100, Geert Uytterhoeven wrote:
> "make dt_binding_check":
> 
>     Documentation/devicetree/bindings/firmware/arm,scpi.example.dt.yaml: scpi: shmem: [[2], [1]] is too long
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Exposed by commit 39bd2b6a3783b899 ("dt-bindings: Improve phandle-array
> schemas").

Interesting !

> ---
>  Documentation/devicetree/bindings/firmware/arm,scpi.yaml | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/firmware/arm,scpi.yaml b/Documentation/devicetree/bindings/firmware/arm,scpi.yaml
> index 800417a76bda0bd9..3735f221fdf24e0a 100644
> --- a/Documentation/devicetree/bindings/firmware/arm,scpi.yaml
> +++ b/Documentation/devicetree/bindings/firmware/arm,scpi.yaml
> @@ -51,6 +51,7 @@ properties:
>        be any memory reserved for the purpose of this communication between the
>        processors.
>      minItems: 1
> +    maxItems: 2
>

There is no max limit strictly speaking. The driver can use all the specified
mboxes and associated shmem in round robin fashion. That is the reason I
didn't add maxItems unlike the newer SCMI protocol which clearly restricts
to one Tx and one Rx(much saner I must admit).

-- 
Regards,
Sudeep

  parent reply	other threads:[~2022-02-16 14:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-16 13:21 [PATCH] dt-bindings: firmware: arm,scpi: Add missing maxItems to shmem property Geert Uytterhoeven
2022-02-16 13:34 ` Krzysztof Kozlowski
2022-02-16 13:42   ` Geert Uytterhoeven
2022-02-16 13:52     ` Krzysztof Kozlowski
2022-02-16 14:39 ` Sudeep Holla [this message]
2022-02-16 14:55   ` Geert Uytterhoeven
2022-02-16 16:53     ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220216143926.t3dadlsjtkotkv6o@bogus \
    --to=sudeep.holla@arm.com \
    --cc=cristian.marussi@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).