From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03804C433FE for ; Wed, 16 Feb 2022 14:50:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235254AbiBPOup (ORCPT ); Wed, 16 Feb 2022 09:50:45 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:43700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235229AbiBPOul (ORCPT ); Wed, 16 Feb 2022 09:50:41 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B64262A39D0; Wed, 16 Feb 2022 06:50:28 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7ECD1113E; Wed, 16 Feb 2022 06:50:28 -0800 (PST) Received: from bogus (unknown [10.57.3.35]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3C16E3F66F; Wed, 16 Feb 2022 06:50:26 -0800 (PST) Date: Wed, 16 Feb 2022 14:49:37 +0000 From: Sudeep Holla To: Shawn Guo Cc: Marc Zyngier , Thomas Gleixner , Maulik Shah , Sudeep Holla , Ulf Hansson , Bjorn Andersson , Lorenzo Pieralisi , "Rafael J . Wysocki" , Daniel Lezcano , Rob Herring , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 1/3] cpuidle: psci: Call cpu_cluster_pm_enter() on the last CPU Message-ID: <20220216144937.znsba7zbdenl7427@bogus> References: <20220216132830.32490-1-shawn.guo@linaro.org> <20220216132830.32490-2-shawn.guo@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220216132830.32490-2-shawn.guo@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org +Ulf (as you he is the author of cpuidle-psci-domains.c and can help you with that if you require) On Wed, Feb 16, 2022 at 09:28:28PM +0800, Shawn Guo wrote: > Make a call to cpu_cluster_pm_enter() on the last CPU going to low power > state (and cpu_cluster_pm_exit() on the firt CPU coming back), so that > platforms can be notified to set up hardware for getting into the cluster > low power state. > NACK. We are not getting the notion of CPU cluster back to cpuidle again. That must die. Remember the cluster doesn't map to idle states especially in the DSU systems where HMP CPUs are in the same cluster but can be in different power domains. You need to decide which PSCI CPU_SUSPEND mode you want to use first. If it is Platform Co-ordinated(PC), then you need not notify anything to the platform. Just request the desired idle state on each CPU and platform will take care from there. If for whatever reason you have chosen OS initiated mode(OSI), then specify the PSCI power domains correctly in the DT which will make use of the cpuidle-psci-domains and handle the so called "cluster" state correctly. -- Regards, Sudeep