devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yong Wu <yong.wu@mediatek.com>
To: Joerg Roedel <joro@8bytes.org>, Rob Herring <robh+dt@kernel.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	Will Deacon <will@kernel.org>
Cc: Robin Murphy <robin.murphy@arm.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	Tomasz Figa <tfiga@chromium.org>,
	<linux-mediatek@lists.infradead.org>,
	<srv_heupstream@mediatek.com>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<iommu@lists.linux-foundation.org>,
	Hsin-Yi Wang <hsinyi@chromium.org>, <yong.wu@mediatek.com>,
	<youlin.pei@mediatek.com>, <anan.sun@mediatek.com>,
	<xueqi.zhang@mediatek.com>, <yen-chang.chen@mediatek.com>,
	"AngeloGioacchino Del Regno" 
	<angelogioacchino.delregno@collabora.com>,
	<mingyuan.ma@mediatek.com>, <yf.wang@mediatek.com>,
	<libo.kang@mediatek.com>, <chengci.xu@mediatek.com>
Subject: [PATCH v5 19/34] iommu/mediatek: Add a PM_CLK_AO flag for infra iommu
Date: Thu, 17 Feb 2022 19:34:38 +0800	[thread overview]
Message-ID: <20220217113453.13658-20-yong.wu@mediatek.com> (raw)
In-Reply-To: <20220217113453.13658-1-yong.wu@mediatek.com>

The power/clock of infra iommu is always on, and it doesn't have the
device link with the master devices, then the infra iommu device's pm
statua is not active, thus we add A PM_CLK_AO flag for infra iommu.

The tlb operation is a bit not clear in this file, Comment them in the
code here.

Signed-off-by: Yong Wu <yong.wu@mediatek.com>
---
 drivers/iommu/mtk_iommu.c | 29 ++++++++++++++++++++++++++---
 1 file changed, 26 insertions(+), 3 deletions(-)

diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c
index ba9d61bec3e8..9634e9d8fcea 100644
--- a/drivers/iommu/mtk_iommu.c
+++ b/drivers/iommu/mtk_iommu.c
@@ -130,6 +130,8 @@
 #define MTK_IOMMU_TYPE_MM		(0x0 << 13)
 #define MTK_IOMMU_TYPE_INFRA		(0x1 << 13)
 #define MTK_IOMMU_TYPE_MASK		(0x3 << 13)
+/* PM and clock always on. e.g. infra iommu */
+#define PM_CLK_AO			BIT(15)
 
 #define MTK_IOMMU_HAS_FLAG(pdata, _x)	(!!(((pdata)->flags) & (_x)))
 
@@ -235,13 +237,33 @@ static void mtk_iommu_tlb_flush_range_sync(unsigned long iova, size_t size,
 					   struct mtk_iommu_data *data)
 {
 	struct list_head *head = data->hw_list;
+	bool check_pm_status;
 	unsigned long flags;
 	int ret;
 	u32 tmp;
 
 	for_each_m4u(data, head) {
-		if (pm_runtime_get_if_in_use(data->dev) <= 0)
-			continue;
+		/*
+		 * To avoid resume the iommu device frequently when the iommu device
+		 * is not active, it doesn't always call pm_runtime_get here, then tlb
+		 * flush depends on the tlb flush all in the runtime resume.
+		 *
+		 * There are 2 special cases:
+		 *
+		 * Case1: The iommu dev doesn't have power domain but has bclk. This case
+		 * should also avoid the tlb flush while the dev is not active to mute
+		 * the tlb timeout log. like mt8173.
+		 *
+		 * Case2: The power/clock of infra iommu is always on, and it doesn't
+		 * have the device link with the master devices. This case should avoid
+		 * the PM status check.
+		 */
+		check_pm_status = !MTK_IOMMU_HAS_FLAG(data->plat_data, PM_CLK_AO);
+
+		if (check_pm_status) {
+			if (pm_runtime_get_if_in_use(data->dev) <= 0)
+				continue;
+		}
 
 		spin_lock_irqsave(&data->tlb_lock, flags);
 		writel_relaxed(F_INVLD_EN1 | F_INVLD_EN0,
@@ -268,7 +290,8 @@ static void mtk_iommu_tlb_flush_range_sync(unsigned long iova, size_t size,
 			mtk_iommu_tlb_flush_all(data);
 		}
 
-		pm_runtime_put(data->dev);
+		if (check_pm_status)
+			pm_runtime_put(data->dev);
 	}
 }
 
-- 
2.18.0


  parent reply	other threads:[~2022-02-17 11:38 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-17 11:34 [PATCH v5 00/34] MT8195 IOMMU SUPPORT Yong Wu
2022-02-17 11:34 ` [PATCH v5 01/34] dt-bindings: mediatek: mt8195: Add binding for MM IOMMU Yong Wu
2022-02-17 11:34 ` [PATCH v5 02/34] dt-bindings: mediatek: mt8195: Add binding for infra IOMMU Yong Wu
2022-02-17 11:34 ` [PATCH v5 03/34] iommu/mediatek: Fix 2 HW sharing pgtable issue Yong Wu
2022-02-17 11:34 ` [PATCH v5 04/34] iommu/mediatek: Add list_del in mtk_iommu_remove Yong Wu
2022-02-17 11:34 ` [PATCH v5 05/34] iommu/mediatek: Remove clk_disable " Yong Wu
2022-02-17 11:34 ` [PATCH v5 06/34] iommu/mediatek: Add mutex for m4u_group and m4u_dom in data Yong Wu
2022-02-17 11:34 ` [PATCH v5 07/34] iommu/mediatek: Add mutex for data in the mtk_iommu_domain Yong Wu
2022-02-17 11:34 ` [PATCH v5 08/34] iommu/mediatek: Adapt sharing and non-sharing pgtable case Yong Wu
2022-02-17 11:34 ` [PATCH v5 09/34] iommu/mediatek: Add 12G~16G support for multi domains Yong Wu
2022-02-17 11:34 ` [PATCH v5 10/34] iommu/mediatek: Add a flag DCM_DISABLE Yong Wu
2022-02-17 11:34 ` [PATCH v5 11/34] iommu/mediatek: Add a flag NON_STD_AXI Yong Wu
2022-02-17 11:34 ` [PATCH v5 12/34] iommu/mediatek: Remove the granule in the tlb flush Yong Wu
2022-02-17 11:34 ` [PATCH v5 13/34] iommu/mediatek: Always enable output PA over 32bits in isr Yong Wu
2022-02-17 11:34 ` [PATCH v5 14/34] iommu/mediatek: Add SUB_COMMON_3BITS flag Yong Wu
2022-02-17 11:34 ` [PATCH v5 15/34] iommu/mediatek: Add IOMMU_TYPE flag Yong Wu
2022-02-17 11:34 ` [PATCH v5 16/34] iommu/mediatek: Contain MM IOMMU flow with the MM TYPE Yong Wu
2022-02-17 11:34 ` [PATCH v5 17/34] iommu/mediatek: Adjust device link when it is sub-common Yong Wu
2022-02-17 11:34 ` [PATCH v5 18/34] iommu/mediatek: Allow IOMMU_DOMAIN_UNMANAGED for PCIe VFIO Yong Wu
2022-02-17 11:34 ` Yong Wu [this message]
2022-02-18 12:52   ` [PATCH v5 19/34] iommu/mediatek: Add a PM_CLK_AO flag for infra iommu AngeloGioacchino Del Regno
2022-02-17 11:34 ` [PATCH v5 20/34] iommu/mediatek: Add infra iommu support Yong Wu
2022-02-17 11:34 ` [PATCH v5 21/34] iommu/mediatek: Add PCIe support Yong Wu
2022-02-18 12:52   ` AngeloGioacchino Del Regno
2022-02-17 11:34 ` [PATCH v5 22/34] iommu/mediatek: Add mt8195 support Yong Wu
2022-02-17 11:34 ` [PATCH v5 23/34] iommu/mediatek: Only adjust code about register base Yong Wu
2022-02-17 11:34 ` [PATCH v5 24/34] iommu/mediatek: Just move code position in hw_init Yong Wu
2022-02-17 11:34 ` [PATCH v5 25/34] iommu/mediatek: Separate mtk_iommu_data for v1 and v2 Yong Wu
2022-02-18 12:52   ` AngeloGioacchino Del Regno
2022-02-17 11:34 ` [PATCH v5 26/34] iommu/mediatek: Remove mtk_iommu.h Yong Wu
2022-02-18 12:52   ` AngeloGioacchino Del Regno
2022-02-17 11:34 ` [PATCH v5 27/34] iommu/mediatek-v1: Just rename mtk_iommu to mtk_iommu_v1 Yong Wu
2022-02-18 12:53   ` AngeloGioacchino Del Regno
2022-02-17 11:34 ` [PATCH v5 28/34] iommu/mediatek: Add mtk_iommu_bank_data structure Yong Wu
2022-02-17 11:34 ` [PATCH v5 29/34] iommu/mediatek: Initialise bank HW for each a bank Yong Wu
2022-02-17 11:34 ` [PATCH v5 30/34] iommu/mediatek: Change the domid to iova_region_id Yong Wu
2022-02-17 11:34 ` [PATCH v5 31/34] iommu/mediatek: Get the proper bankid for multi banks Yong Wu
2022-02-17 11:34 ` [PATCH v5 32/34] iommu/mediatek: Initialise/Remove for multi bank dev Yong Wu
2022-02-18 12:52   ` AngeloGioacchino Del Regno
2022-02-17 11:34 ` [PATCH v5 33/34] iommu/mediatek: Backup/restore regsiters for multi banks Yong Wu
2022-02-17 11:34 ` [PATCH v5 34/34] iommu/mediatek: mt8195: Enable multi banks for infra iommu Yong Wu
2022-02-28 12:34 ` [PATCH v5 00/34] MT8195 IOMMU SUPPORT Joerg Roedel
2022-02-28 13:50   ` AngeloGioacchino Del Regno
2022-03-01  7:49     ` Yong Wu
2022-03-04  9:20       ` Joerg Roedel
2022-03-04  9:57         ` Yong Wu
2022-03-04 10:05           ` Joerg Roedel
2022-03-04 10:07             ` AngeloGioacchino Del Regno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220217113453.13658-20-yong.wu@mediatek.com \
    --to=yong.wu@mediatek.com \
    --cc=anan.sun@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chengci.xu@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hsinyi@chromium.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=libo.kang@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mingyuan.ma@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=srv_heupstream@mediatek.com \
    --cc=tfiga@chromium.org \
    --cc=will@kernel.org \
    --cc=xueqi.zhang@mediatek.com \
    --cc=yen-chang.chen@mediatek.com \
    --cc=yf.wang@mediatek.com \
    --cc=youlin.pei@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).