[PATCH v2] dt-bindings: leds: Document mmc trigger

[PATCH v2] dt-bindings: leds: Document mmc trigger

[Marek Vasut]

The mmc subsystem supports triggering leds on card activity, document
the trigger value here. The value is a pattern in this case.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
To: linux-leds@vger.kernel.org
---
V2: Rebase on next-20220217
---
 .../devicetree/bindings/leds/common.yaml      | 39 ++++++++++---------
 1 file changed, 21 insertions(+), 18 deletions(-)

diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index 328952d7acbbc..3c14a98430e19 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -79,24 +79,27 @@ properties:
       the LED.
     $ref: /schemas/types.yaml#/definitions/string
 
-    enum:
-        # LED will act as a back-light, controlled by the framebuffer system
-      - backlight
-        # LED will turn on (but for leds-gpio see "default-state" property in
-        # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
-      - default-on
-        # LED "double" flashes at a load average based rate
-      - heartbeat
-        # LED indicates disk activity
-      - disk-activity
-        # LED indicates IDE disk activity (deprecated), in new implementations
-        # use "disk-activity"
-      - ide-disk
-        # LED flashes at a fixed, configurable rate
-      - timer
-        # LED alters the brightness for the specified duration with one software
-        # timer (requires "led-pattern" property)
-      - pattern
+    oneOf:
+      - enum:
+            # LED will act as a back-light, controlled by the framebuffer system
+          - backlight
+            # LED will turn on (but for leds-gpio see "default-state" property in
+            # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
+          - default-on
+            # LED "double" flashes at a load average based rate
+          - heartbeat
+            # LED indicates disk activity
+          - disk-activity
+            # LED indicates IDE disk activity (deprecated), in new implementations
+            # use "disk-activity"
+          - ide-disk
+            # LED flashes at a fixed, configurable rate
+          - timer
+            # LED alters the brightness for the specified duration with one software
+            # timer (requires "led-pattern" property)
+          - pattern
+        # LED is triggered by SD/MMC activity
+      - pattern: "^mmc[0-9]+$"
 
   led-pattern:
     description: |
-- 
2.34.1

Re: [PATCH v2] dt-bindings: leds: Document mmc trigger

[Rob Herring]

On Thu, Feb 17, 2022 at 06:43:57PM +0100, Marek Vasut wrote:
> The mmc subsystem supports triggering leds on card activity, document
> the trigger value here. The value is a pattern in this case.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> To: linux-leds@vger.kernel.org
> ---
> V2: Rebase on next-20220217

Why? Nobody can apply patches to linux-next. Is there something in next 
you are dependent on that you didn't tell us about?

> ---
>  .../devicetree/bindings/leds/common.yaml      | 39 ++++++++++---------
>  1 file changed, 21 insertions(+), 18 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> index 328952d7acbbc..3c14a98430e19 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -79,24 +79,27 @@ properties:
>        the LED.
>      $ref: /schemas/types.yaml#/definitions/string
>  
> -    enum:
> -        # LED will act as a back-light, controlled by the framebuffer system
> -      - backlight
> -        # LED will turn on (but for leds-gpio see "default-state" property in
> -        # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
> -      - default-on
> -        # LED "double" flashes at a load average based rate
> -      - heartbeat
> -        # LED indicates disk activity
> -      - disk-activity
> -        # LED indicates IDE disk activity (deprecated), in new implementations
> -        # use "disk-activity"
> -      - ide-disk
> -        # LED flashes at a fixed, configurable rate
> -      - timer
> -        # LED alters the brightness for the specified duration with one software
> -        # timer (requires "led-pattern" property)
> -      - pattern
> +    oneOf:
> +      - enum:
> +            # LED will act as a back-light, controlled by the framebuffer system
> +          - backlight
> +            # LED will turn on (but for leds-gpio see "default-state" property in
> +            # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
> +          - default-on
> +            # LED "double" flashes at a load average based rate
> +          - heartbeat
> +            # LED indicates disk activity
> +          - disk-activity
> +            # LED indicates IDE disk activity (deprecated), in new implementations
> +            # use "disk-activity"
> +          - ide-disk
> +            # LED flashes at a fixed, configurable rate
> +          - timer
> +            # LED alters the brightness for the specified duration with one software
> +            # timer (requires "led-pattern" property)
> +          - pattern
> +        # LED is triggered by SD/MMC activity
> +      - pattern: "^mmc[0-9]+$"
>  
>    led-pattern:
>      description: |
> -- 
> 2.34.1
> 
> 

Re: [PATCH v2] dt-bindings: leds: Document mmc trigger

[Rob Herring]

On Thu, 17 Feb 2022 18:43:57 +0100, Marek Vasut wrote:
> The mmc subsystem supports triggering leds on card activity, document
> the trigger value here. The value is a pattern in this case.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: devicetree@vger.kernel.org
> To: linux-leds@vger.kernel.org
> ---
> V2: Rebase on next-20220217
> ---
>  .../devicetree/bindings/leds/common.yaml      | 39 ++++++++++---------
>  1 file changed, 21 insertions(+), 18 deletions(-)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH v2] dt-bindings: leds: Document mmc trigger

[Marek Vasut]

On 2/24/22 23:31, Rob Herring wrote:
> On Thu, Feb 17, 2022 at 06:43:57PM +0100, Marek Vasut wrote:
>> The mmc subsystem supports triggering leds on card activity, document
>> the trigger value here. The value is a pattern in this case.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
>> Cc: Pavel Machek <pavel@ucw.cz>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: devicetree@vger.kernel.org
>> To: linux-leds@vger.kernel.org
>> ---
>> V2: Rebase on next-20220217
> 
> Why? Nobody can apply patches to linux-next. Is there something in next
> you are dependent on that you didn't tell us about?

It is just a convenience really, it is where the commits for all the 
mostly latest development exist in one place, so I can be reasonably 
sure the maintainer won't have trouble applying the patch on their tree 
due to some missing patch, and if I work also on driver stuff, I can be 
sure those drivers are also up-to-date-ish.

No, I don't think this patch specifically depends on anything in latest 
next.

Re: [PATCH v2] dt-bindings: leds: Document mmc trigger

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 861 bytes --]

On Thu 2022-02-24 16:31:52, Rob Herring wrote:
> On Thu, 17 Feb 2022 18:43:57 +0100, Marek Vasut wrote:
> > The mmc subsystem supports triggering leds on card activity, document
> > the trigger value here. The value is a pattern in this case.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
> > Cc: Pavel Machek <pavel@ucw.cz>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: devicetree@vger.kernel.org
> > To: linux-leds@vger.kernel.org
> > ---
> > V2: Rebase on next-20220217
> > ---
> >  .../devicetree/bindings/leds/common.yaml      | 39 ++++++++++---------
> >  1 file changed, 21 insertions(+), 18 deletions(-)
> > 
> 
> Reviewed-by: Rob Herring <robh@ke

Thanks, applied.

best regards,
							Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]