From: Jagath Jog J <jagathjog1996@gmail.com>
To: jic23@kernel.org, lars@metafoo.de, andy.shevchenko@gmail.com,
sst@poczta.fm, robh+dt@kernel.org
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 3/6] iio: potentiometer: Add channel information in device data
Date: Fri, 18 Feb 2022 09:50:35 +0530 [thread overview]
Message-ID: <20220218042038.15176-4-jagathjog1996@gmail.com> (raw)
In-Reply-To: <20220218042038.15176-1-jagathjog1996@gmail.com>
Adding each device wiper count and channel information into
device private data.
Utilizing addr member of struct iio_chan_spec to get the
wiper register address so that the value can be read or write
to the same address.
Signed-off-by: Jagath Jog J <jagathjog1996@gmail.com>
---
drivers/iio/potentiometer/ds1803.c | 33 ++++++++++++++++++++----------
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/drivers/iio/potentiometer/ds1803.c b/drivers/iio/potentiometer/ds1803.c
index d1e00dda337a..0ef3acb13c79 100644
--- a/drivers/iio/potentiometer/ds1803.c
+++ b/drivers/iio/potentiometer/ds1803.c
@@ -16,7 +16,8 @@
#include <linux/module.h>
#include <linux/mod_devicetable.h>
-#define DS1803_WRITE(chan) (0xa8 | ((chan) + 1))
+#define DS1803_WIPER_0 0xA9
+#define DS1803_WIPER_1 0xAA
enum ds1803_type {
DS1803_010,
@@ -25,8 +26,11 @@ enum ds1803_type {
};
struct ds1803_cfg {
+ int wipers;
int avail[3];
int kohms;
+ const struct iio_chan_spec *channels;
+ u8 num_channels;
};
struct ds1803_data {
@@ -34,25 +38,32 @@ struct ds1803_data {
const struct ds1803_cfg *cfg;
};
-#define DS1803_CHANNEL(ch) { \
+#define DS1803_CHANNEL(ch, addr) { \
.type = IIO_RESISTANCE, \
.indexed = 1, \
.output = 1, \
.channel = (ch), \
+ .address = (addr), \
.info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \
.info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), \
.info_mask_shared_by_type_available = BIT(IIO_CHAN_INFO_RAW), \
}
static const struct iio_chan_spec ds1803_channels[] = {
- DS1803_CHANNEL(0),
- DS1803_CHANNEL(1),
+ DS1803_CHANNEL(0, DS1803_WIPER_0),
+ DS1803_CHANNEL(1, DS1803_WIPER_1),
};
static const struct ds1803_cfg ds1803_cfg[] = {
- [DS1803_010] = { .avail = { 0, 1, 255 }, .kohms = 10, },
- [DS1803_050] = { .avail = { 0, 1, 255 }, .kohms = 50, },
- [DS1803_100] = { .avail = { 0, 1, 255 }, .kohms = 100, },
+ [DS1803_010] = { .wipers = 2, .avail = { 0, 1, 255 }, .kohms = 10,
+ .channels = ds1803_channels,
+ .num_channels = ARRAY_SIZE(ds1803_channels) },
+ [DS1803_050] = { .wipers = 2, .avail = { 0, 1, 255 }, .kohms = 50,
+ .channels = ds1803_channels,
+ .num_channels = ARRAY_SIZE(ds1803_channels) },
+ [DS1803_100] = { .wipers = 2, .avail = { 0, 1, 255 }, .kohms = 100,
+ .channels = ds1803_channels,
+ .num_channels = ARRAY_SIZE(ds1803_channels) },
};
static int ds1803_read_raw(struct iio_dev *indio_dev,
@@ -88,7 +99,7 @@ static int ds1803_write_raw(struct iio_dev *indio_dev,
int val, int val2, long mask)
{
struct ds1803_data *data = iio_priv(indio_dev);
- int pot = chan->channel;
+ u8 addr = chan->address;
int max_pos = data->cfg->avail[2];
if (val2 != 0)
@@ -103,7 +114,7 @@ static int ds1803_write_raw(struct iio_dev *indio_dev,
return -EINVAL;
}
- return i2c_smbus_write_byte_data(data->client, DS1803_WRITE(pot), val);
+ return i2c_smbus_write_byte_data(data->client, addr, val);
}
static int ds1803_read_avail(struct iio_dev *indio_dev, struct iio_chan_spec const *chan,
@@ -144,8 +155,8 @@ static int ds1803_probe(struct i2c_client *client, const struct i2c_device_id *i
data->cfg = &ds1803_cfg[id->driver_data];
indio_dev->info = &ds1803_info;
- indio_dev->channels = ds1803_channels;
- indio_dev->num_channels = ARRAY_SIZE(ds1803_channels);
+ indio_dev->channels = data->cfg->channels;
+ indio_dev->num_channels = data->cfg->num_channels;
indio_dev->name = client->name;
return devm_iio_device_register(dev, indio_dev);
--
2.17.1
next prev parent reply other threads:[~2022-02-18 4:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 4:20 [PATCH v3 0/6] iio: potentiometer: Add support for DS3502 Jagath Jog J
2022-02-18 4:20 ` [PATCH v3 1/6] iio: potentiometer: Alignment to match the open parenthesis Jagath Jog J
2022-02-18 4:20 ` [PATCH v3 2/6] iio: potentiometer: Add available functionality Jagath Jog J
2022-02-18 4:20 ` Jagath Jog J [this message]
2022-02-21 20:40 ` [PATCH v3 3/6] iio: potentiometer: Add channel information in device data Andy Shevchenko
2022-02-18 4:20 ` [PATCH v3 4/6] iio: potentiometer: Change to firmware provided data Jagath Jog J
2022-02-21 20:42 ` Andy Shevchenko
2022-02-18 4:20 ` [PATCH v3 5/6] iio: potentiometer: Add support for Maxim DS3502 Jagath Jog J
2022-02-18 12:32 ` Jonathan Cameron
2022-02-21 20:47 ` Andy Shevchenko
2022-02-18 4:20 ` [PATCH v3 6/6] dt-bindings: iio: potentiometer: Add Maxim DS3502 in trivial-devices Jagath Jog J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220218042038.15176-4-jagathjog1996@gmail.com \
--to=jagathjog1996@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sst@poczta.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).