devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rafał Miłecki" <zajec5@gmail.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Rob Herring <robh+dt@kernel.org>
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski@canonical.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Hauke Mehrtens" <hauke@hauke-m.de>,
	bcm-kernel-feedback-list@broadcom.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>
Subject: [PATCH V3 2/3] dt-bindings: nvmem: brcm,nvram: add basic NVMEM cells
Date: Fri, 18 Feb 2022 08:07:28 +0100	[thread overview]
Message-ID: <20220218070729.3256-3-zajec5@gmail.com> (raw)
In-Reply-To: <20220218070729.3256-1-zajec5@gmail.com>

From: Rafał Miłecki <rafal@milecki.pl>

NVRAM doesn't have cells at hardcoded addresses. They are stored in
internal struct (custom & dynamic format). It's still important to
define relevant cells in DT so NVMEM consumers can reference them.

Update binding to allow including basic cells as NVMEM device subnodes.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
V2: Add children nodes description per Rob's request
V3: Document NVMEM cells as properties
---
 .../devicetree/bindings/nvmem/brcm,nvram.yaml | 25 +++++++++++++++++--
 1 file changed, 23 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml
index 8c3f0cd22821..25033de3ef6b 100644
--- a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml
+++ b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml
@@ -14,6 +14,8 @@ description: |
   NVRAM can be accessed on Broadcom BCM47xx MIPS and Northstar ARM Cortex-A9
   devices usiong I/O mapped memory.
 
+  NVRAM variables can be defined as NVMEM device subnodes.
+
 maintainers:
   - Rafał Miłecki <rafal@milecki.pl>
 
@@ -27,11 +29,30 @@ properties:
   reg:
     maxItems: 1
 
+  board_id:
+    type: object
+    description: Board identification name
+
+  et0macaddr:
+    type: object
+    description: First Ethernet interface's MAC address
+
+  et1macaddr:
+    type: object
+    description: Second Ethernet interface's MAC address
+
+  et2macaddr:
+    type: object
+    description: Third Ethernet interface's MAC address
+
 unevaluatedProperties: false
 
 examples:
   - |
     nvram@1eff0000 {
-            compatible = "brcm,nvram";
-            reg = <0x1eff0000 0x10000>;
+        compatible = "brcm,nvram";
+        reg = <0x1eff0000 0x10000>;
+
+        mac: et0macaddr {
+        };
     };
-- 
2.34.1


  parent reply	other threads:[~2022-02-18  7:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-24 16:02 [PATCH 0/3] nvmem: allow specifying cells by just names in DT Rafał Miłecki
2022-01-24 16:02 ` [PATCH 1/3] dt-bindings: nvmem: make "reg" property optional Rafał Miłecki
2022-02-11 12:38   ` Rob Herring
2022-01-24 16:02 ` [PATCH 2/3] dt-bindings: nvmem: brcm,nvram: add NVMEM cell to example Rafał Miłecki
2022-02-11 12:45   ` Rob Herring
2022-01-24 16:03 ` [PATCH 3/3] nvmem: core: add cell name based matching of DT cell nodes Rafał Miłecki
2022-02-11 13:05 ` [PATCH V2 0/3] nvmem: allow specifying cells by just names in DT Rafał Miłecki
2022-02-11 13:05   ` [PATCH V2 1/3] dt-bindings: nvmem: make "reg" property optional Rafał Miłecki
2022-02-11 13:05   ` [PATCH V2 2/3] dt-bindings: nvmem: brcm,nvram: add NVMEM cell to example Rafał Miłecki
2022-02-17 23:58     ` Rob Herring
2022-02-11 13:05   ` [PATCH V2 3/3] nvmem: core: add cell name based matching of DT cell nodes Rafał Miłecki
2022-02-18  7:07 ` [PATCH V3 0/3] nvmem: allow specifying cells by just names in DT Rafał Miłecki
2022-02-18  7:07   ` [PATCH V3 1/3] dt-bindings: nvmem: make "reg" property optional Rafał Miłecki
2022-02-25 13:30     ` Srinivas Kandagatla
2022-02-18  7:07   ` Rafał Miłecki [this message]
2022-02-24 19:55     ` [PATCH V3 2/3] dt-bindings: nvmem: brcm,nvram: add basic NVMEM cells Rob Herring
2022-02-25 13:30     ` Srinivas Kandagatla
2022-02-18  7:07   ` [PATCH V3 3/3] nvmem: core: add cell name based matching of DT cell nodes Rafał Miłecki
2022-02-25 12:10     ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220218070729.3256-3-zajec5@gmail.com \
    --to=zajec5@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=hauke@hauke-m.de \
    --cc=krzysztof.kozlowski@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafal@milecki.pl \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).